Skip to content

Fix typos#39465

Merged
bsmth merged 6 commits intomdn:mainfrom
pulkitgarg04:main
May 9, 2025
Merged

Fix typos#39465
bsmth merged 6 commits intomdn:mainfrom
pulkitgarg04:main

Conversation

@pulkitgarg04
Copy link
Copy Markdown
Contributor

@pulkitgarg04 pulkitgarg04 commented May 9, 2025

Description

Fixed various typos across multiple documentation files to improve clarity and correctness. The updates address spelling errors in terms like "glossarysidebar," "undefines," "onprerenderingchange," "licence," "elments," and "opaquess."

Motivation

Typos can confuse readers and reduce the perceived quality of the documentation. Correcting these issues ensures accurate and professional content for users.

Additional details

Related issues and pull requests

Fixes #39390

@pulkitgarg04 pulkitgarg04 requested review from a team as code owners May 9, 2025 08:22
@pulkitgarg04 pulkitgarg04 requested review from bsmth, chrisdavidmills and wbamberg and removed request for a team May 9, 2025 08:22
@github-actions github-actions bot added Content:CSS Cascading Style Sheets docs Content:WebAPI Web API docs Content:SVG SVG docs system [PR only] Infrastructure and configuration for the project size/s [PR only] 6-50 LoC changed labels May 9, 2025
bsmth
bsmth reviewed May 9, 2025
View reviewed changes
files/en-us/web/api/document_object_model/reflected_attributes/index.md Outdated
For normal reflected properties, updates to the property are reflected in the corresponding attribute and vice versa.
For reflected element references this is not the case.
Instead, setting the property clears ("undefines") the attribute, so that the property and attribute no longer reflect each other.
Instead, setting the property clears (removes) the attribute, so that the property and attribute no longer reflect each other.
Copy link
Copy Markdown
Member

@bsmth bsmth May 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this more accurate?

Suggested change
Instead, setting the property clears (removes) the attribute, so that the property and attribute no longer reflect each other.
Instead, setting the property clears the attribute (sets as `undefined`), so that the property and attribute no longer reflect each other.

Copy link
Copy Markdown
Contributor Author

@pulkitgarg04 pulkitgarg04 May 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it is more accurate. I have fixed it.

Copy link
Copy Markdown
Member

@bsmth bsmth May 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the comment from Josh below: #39465 (comment)

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented May 9, 2025 •
edited
Loading

Preview URLs (7 pages)
Flaws (6)

Note! 4 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/API/Document_Object_Model/Reflected_attributes
Title: Attribute reflection
Flaw count: 2

  • macros:
    • Macro produces link /en-US/docs/Web/API/Document_Object_Model/Events which is a redirect
    • Macro produces link /en-US/docs/Web/API/Document_Object_Model/Whitespace_in_the_DOM which is a redirect

URL: /en-US/docs/Web/CSS/mask-clip
Title: mask-clip
Flaw count: 2

  • macros:
    • Macro produces link /en-US/docs/Web/CSS/CSS_cascade/initial_value which is a redirect
    • Macro produces link /en-US/docs/Web/CSS/CSS_cascade/computed_value which is a redirect

URL: /en-US/docs/Web/CSS/mask-repeat
Title: mask-repeat
Flaw count: 2

  • macros:
    • Macro produces link /en-US/docs/Web/CSS/CSS_cascade/initial_value which is a redirect
    • Macro produces link /en-US/docs/Web/CSS/CSS_cascade/computed_value which is a redirect

(comment last updated: 2025-05-09 12:27:51)

@Josh-Cena Josh-Cena requested a review from a team as a code owner May 9, 2025 09:42
@Josh-Cena Josh-Cena requested review from scottaohara and removed request for a team May 9, 2025 09:42
@github-actions github-actions bot added Content:Accessibility Accessibility docs Content:Meta Content in the meta docs labels May 9, 2025
@Josh-Cena Josh-Cena changed the title fix typos as per the issue(#39390) Fix typos May 9, 2025
Josh-Cena
Josh-Cena reviewed May 9, 2025
View reviewed changes
files/en-us/web/api/document_object_model/reflected_attributes/index.md Outdated
For normal reflected properties, updates to the property are reflected in the corresponding attribute and vice versa.
For reflected element references this is not the case.
Instead, setting the property clears ("undefines") the attribute, so that the property and attribute no longer reflect each other.
Instead, setting the property clears the attribute (sets as `undefined`), so that the property and attribute no longer reflect each other.
Copy link
Copy Markdown
Member

@Josh-Cena Josh-Cena May 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is correct. There's no such thing as "set to undefined" for attributes; undefined is a JavaScript code entity. Maybe some ARIA attributes have an intrinsic default value of undefined, but this is not a general thing. Instead, "undefines" as an improper analogy is better (and you can add it to the terms-abbreviations terminology), or you can say "unsets".

Copy link
Copy Markdown
Member

@bsmth bsmth May 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks:

"undefines" as an improper analogy is better (and you can add it to the terms-abbreviations terminology), or you can say "unsets".

I agree, either of those are better

bsmth
bsmth reviewed May 9, 2025
View reviewed changes
files/en-us/web/api/document_object_model/reflected_attributes/index.md Outdated
For normal reflected properties, updates to the property are reflected in the corresponding attribute and vice versa.
For reflected element references this is not the case.
Instead, setting the property clears ("undefines") the attribute, so that the property and attribute no longer reflect each other.
Instead, setting the property clears the attribute (sets as `undefined`), so that the property and attribute no longer reflect each other.
Copy link
Copy Markdown
Member

@bsmth bsmth May 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For simplicity:

Suggested change
Instead, setting the property clears the attribute (sets as `undefined`), so that the property and attribute no longer reflect each other.
Instead, setting the property clears (unsets) the attribute, so that the property and attribute no longer reflect each other.

Copy link
Copy Markdown
Contributor Author

@pulkitgarg04 pulkitgarg04 May 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay, I have updated it in the pr.

Josh-Cena
Josh-Cena approved these changes May 9, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you!

bsmth
bsmth approved these changes May 9, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@bsmth bsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too, thanks a lot for the fixes and welcome aboard!

@bsmth bsmth merged commit cb7e7fd into mdn:main May 9, 2025
9 checks passed
wbamberg added a commit to wbamberg/content that referenced this pull request May 21, 2025
@wbamberg
Merge remote-tracking branch 'upstream/main' into add-mitm-guide
12d8ac7 
* upstream/main: (40 commits)
  Add a guide on xs-leaks (mdn#38977)
  chore: Link to child pages in SVG, URI section (mdn#39470)
  Correct page title for `Uint8Array.prototype.setFromHex()` (mdn#39494)
  Bump markdownlint-cli2 from 0.17.2 to 0.18.0 (mdn#39488)
  Add more documentation for sizes=auto (mdn#39464)
  css(fix): update 'shape()' page (mdn#39454)
  Expand Compression Dictionary format description (mdn#39441)
  Add username/password section to URLs guide (mdn#39487)
  Fix typos (mdn#39481)
  CSS: mask-position property description (mdn#39449)
  Adding @starting-style to CSS nesting at-rules (mdn#39473)
  feat(aria): Add short titles, format titles for roles (mdn#39472)
  Fix Circle Collision detection algorithm (mdn#39484)
  Add warning against using element IDs as global properties. (mdn#39422)
  Fix typos in web audio spatialization basics (mdn#39476)
  More Error Messages (mdn#39419)
  Add links to CSS sidebar (mdn#39445)
  css: add 'stretch' value examples (mdn#39451)
  chore: link to unlinked child pages (mdn#39469)
  Fix typos (mdn#39465)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bsmth bsmth bsmth approved these changes

@Josh-Cena Josh-Cena Josh-Cena approved these changes

Assignees

No one assigned

Labels

Content:Accessibility Accessibility docs Content:CSS Cascading Style Sheets docs Content:Meta Content in the meta docs Content:SVG SVG docs Content:WebAPI Web API docs size/s [PR only] 6-50 LoC changed system [PR only] Infrastructure and configuration for the project

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Weekly spelling check

4 participants

@pulkitgarg04 @bsmth @Josh-Cena @mdn-bot