Skip to content

css: add 'stretch' value examples#39451

Merged
estelle merged 2 commits intomdn:mainfrom
OnkarRuikar:css_stretch
May 9, 2025
Merged

css: add 'stretch' value examples#39451
estelle merged 2 commits intomdn:mainfrom
OnkarRuikar:css_stretch

Conversation

@OnkarRuikar
Copy link
Copy Markdown
Contributor

@OnkarRuikar OnkarRuikar commented May 8, 2025

No description provided.

@OnkarRuikar OnkarRuikar requested a review from a team as a code owner May 8, 2025 06:40
@OnkarRuikar OnkarRuikar requested review from estelle and removed request for a team May 8, 2025 06:40
@github-actions github-actions bot added Content:CSS Cascading Style Sheets docs size/m [PR only] 51-500 LoC changed labels May 8, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented May 8, 2025 •
edited
Loading

Preview URLs

Flaws (6)

URL: /en-US/docs/Web/CSS/height
Title: height
Flaw count: 3

  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/intrinsic-size-keyword
  • macros:
    • Macro produces link /en-US/docs/Web/CSS/CSS_cascade/initial_value which is a redirect
    • Macro produces link /en-US/docs/Web/CSS/CSS_cascade/computed_value which is a redirect

URL: /en-US/docs/Web/CSS/width
Title: width
Flaw count: 3

  • broken_links:
    • Can't resolve /en-US/docs/Web/CSS/intrinsic-size-keyword
  • macros:
    • Macro produces link /en-US/docs/Web/CSS/CSS_cascade/initial_value which is a redirect
    • Macro produces link /en-US/docs/Web/CSS/CSS_cascade/computed_value which is a redirect

(comment last updated: 2025-05-09 07:09:23)

@OnkarRuikar OnkarRuikar mentioned this pull request May 8, 2025
Merged
@OnkarRuikar
Copy link
Copy Markdown
Contributor Author

OnkarRuikar commented May 8, 2025

Firefox needs the layout.css.stretch-size-keyword.enabled flag to be enabled on the about:config page.

estelle
estelle reviewed May 8, 2025
View reviewed changes
files/en-us/web/css/height/index.md Outdated
}

.stretch {
height: -webkit-fill-available;
Copy link
Copy Markdown
Member

@estelle estelle May 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this example is demonstrating -webkit-fill-available;, which is not explained. we should either show it working on its own, or not show it at all. so let's kill line 191.

As we're adding a working example ( the example with no prefix), we should remove the note, " To check aliases used by browsers for the stretch value and its implementation status, see the Browser compatibility section."

Copy link
Copy Markdown
Contributor Author

@OnkarRuikar OnkarRuikar May 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

killed the line 191 and the comment

estelle
estelle reviewed May 8, 2025
View reviewed changes
@OnkarRuikar
Copy link
Copy Markdown
Contributor Author

OnkarRuikar commented May 9, 2025

Now test in Firefox with layout.css.stretch-size-keyword.enabled set.

estelle
estelle approved these changes May 9, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@estelle estelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🎉

@estelle estelle merged commit 4b4b195 into mdn:main May 9, 2025
8 checks passed
@OnkarRuikar OnkarRuikar deleted the css_stretch branch May 10, 2025 02:03
wbamberg added a commit to wbamberg/content that referenced this pull request May 21, 2025
@wbamberg
Merge remote-tracking branch 'upstream/main' into add-mitm-guide
12d8ac7 
* upstream/main: (40 commits)
  Add a guide on xs-leaks (mdn#38977)
  chore: Link to child pages in SVG, URI section (mdn#39470)
  Correct page title for `Uint8Array.prototype.setFromHex()` (mdn#39494)
  Bump markdownlint-cli2 from 0.17.2 to 0.18.0 (mdn#39488)
  Add more documentation for sizes=auto (mdn#39464)
  css(fix): update 'shape()' page (mdn#39454)
  Expand Compression Dictionary format description (mdn#39441)
  Add username/password section to URLs guide (mdn#39487)
  Fix typos (mdn#39481)
  CSS: mask-position property description (mdn#39449)
  Adding @starting-style to CSS nesting at-rules (mdn#39473)
  feat(aria): Add short titles, format titles for roles (mdn#39472)
  Fix Circle Collision detection algorithm (mdn#39484)
  Add warning against using element IDs as global properties. (mdn#39422)
  Fix typos in web audio spatialization basics (mdn#39476)
  More Error Messages (mdn#39419)
  Add links to CSS sidebar (mdn#39445)
  css: add 'stretch' value examples (mdn#39451)
  chore: link to unlinked child pages (mdn#39469)
  Fix typos (mdn#39465)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@estelle estelle estelle approved these changes

Assignees

No one assigned

Labels

Content:CSS Cascading Style Sheets docs size/m [PR only] 51-500 LoC changed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@OnkarRuikar @estelle @mdn-bot