🐛 fix(home): use correct CreateGroupModal for session group creation by arvinxx · Pull Request #11752 · lobehub/lobehub

arvinxx · 2026-01-23T14:40:39Z

Summary

Fix "Add New Group" menu item opening wrong modal
Use simple session group creation modal instead of complex agent selection modal

Problem

When clicking "Add New Group" in the agent dropdown menu, it was incorrectly opening the complex CreateGroupModal (from home/_layout/CreateGroupModal) which requires selecting agents. This is meant for a different use case.

Solution

Changed the import in ModalProvider.tsx to use the correct CreateGroupModal from ./Modals/CreateGroupModal which is a simple modal that only requires entering a group name to create an agent folder (session group).

Changes

ModalProvider.tsx: Fixed import path for CreateGroupModal
ModelSelect/index.tsx: Fixed unrelated type error (removed deprecated tooltipWhenOverflow prop)

Test plan

Type check passes
Manual test: Click "Add New Group" in agent menu, verify simple name input modal appears

Related Issues

Closes: LOBE-4192

🤖 Generated with Claude Code

The "Add New Group" menu item was incorrectly opening the complex agent selection modal instead of the simple session group creation modal. This fix imports the correct CreateGroupModal component that only requires a group name input for creating agent folders. Also fixes unrelated type error in ModelSelect component. Closes: LOBE-4192 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

sourcery-ai

Sorry, we are unable to review this pull request

The GitHub API does not allow us to fetch diffs exceeding 300 files, and this pull request has 7306

vercel · 2026-01-23T14:40:45Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Review	Updated (UTC)
lobehub	Error		Jan 23, 2026 3:49pm

codecov · 2026-01-23T14:47:00Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.16%. Comparing base (1754455) to head (aa7cc04).
⚠️ Report is 8 commits behind head on next.

Additional details and impacted files

@@             Coverage Diff             @@
##             next   #11752       +/-   ##
===========================================
- Coverage   85.64%   74.16%   -11.48%     
===========================================
  Files         378     1193      +815     
  Lines       26377    94972    +68595     
  Branches     4517    12533     +8016     
===========================================
+ Hits        22590    70437    +47847     
- Misses       3697    24445    +20748     
  Partials       90       90

Flag	Coverage Δ
app	`67.21% <ø> (?)`
database	`91.48% <ø> (?)`
packages/agent-runtime	`90.20% <ø> (ø)`
packages/context-engine	`85.36% <ø> (ø)`
packages/conversation-flow	`92.28% <ø> (ø)`
packages/file-loaders	`87.04% <ø> (ø)`
packages/memory-user-memory	`69.30% <ø> (ø)`
packages/model-bank	`100.00% <ø> (ø)`
packages/model-runtime	`86.72% <ø> (ø)`
packages/prompts	`79.33% <ø> (ø)`
packages/python-interpreter	`92.90% <ø> (ø)`
packages/ssrf-safe-fetch	`0.00% <ø> (ø)`
packages/utils	`93.22% <ø> (ø)`
packages/web-crawler	`95.62% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
Store	`67.96% <ø> (∅)`
Services	`50.58% <ø> (∅)`
Server	`67.71% <ø> (∅)`
Libs	`40.36% <ø> (∅)`
Utils	`93.60% <ø> (+0.13%)`	⬆️

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

gru-agent · 2026-01-23T15:12:21Z

⏳ Processing in progress

lobehubbot · 2026-01-23T15:12:39Z

❤️ Great PR @arvinxx ❤️

The growth of project is inseparable from user feedback and contribution, thanks for your contribution! If you are interesting with the lobehub developer community, please join our discord and then dm @arvinxx or @canisminor1990. They will invite you to our private developer channel. We are talking about the lobe-chat development or sharing ai newsletter around the world.

## [Version 2.0.0-next.355](v2.0.0-next.354...v2.0.0-next.355) <sup>Released on **2026-01-23**</sup> #### 🐛 Bug Fixes - **home**: Use correct CreateGroupModal for session group creation. - **misc**: Fix favorite refresh bug and group topic refresh issue. <br/> <details> <summary><kbd>Improvements and Fixes</kbd></summary> #### What's fixed * **home**: Use correct CreateGroupModal for session group creation, closes [#11752](#11752) ([36bcc50](36bcc50)) * **misc**: Fix favorite refresh bug and group topic refresh issue, closes [#11745](#11745) ([5d115ef](5d115ef)) </details> <div align="right"> [![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top) </div>

lobehubbot · 2026-01-23T15:34:05Z

🎉 This PR is included in version 2.0.0-next.355 🎉

The release is available on:

Your semantic-release bot 📦🚀

## [Version 1.154.0](v1.153.1...v1.154.0) <sup>Released on **2026-01-23**</sup> #### ♻ Code Refactoring - **misc**: Migrate AI Rules to Claude Code Skills. #### ✨ Features - **database**: Extended async task with metadata and parent id, added index. - **misc**: Remove NextAuth. #### 🐛 Bug Fixes - **copilot**: History popover not refreshing when agentId changes. - **editor**: Prevent crash when toggling enableInputMarkdown setting. - **home**: Use correct CreateGroupModal for session group creation. - **model-runtime**: Handle null content in anthropic message builder. - **ModelSelect**: Resolve tooltip hover causing popup to close. - **pdf**: Ensure worker config before Document render. - **store**: Delete message before regeneration. - **misc**: Fix auto scroll, fix favorite refresh bug and group topic refresh issue, fixed the agent group builder tools excaution edge case crash, page content switch mismatch, when use market group, the group sys role was not used. <br/> <details> <summary><kbd>Improvements and Fixes</kbd></summary> #### Code refactoring * **misc**: Migrate AI Rules to Claude Code Skills, closes [lobehub#11737](https://github.com/jaworldwideorg/OneJA-Bot/issues/11737) ([346fc46](346fc46)) #### What's improved * **database**: Extended async task with metadata and parent id, added index, closes [lobehub#11712](https://github.com/jaworldwideorg/OneJA-Bot/issues/11712) ([31d2f26](31d2f26)) * **misc**: Remove NextAuth, closes [lobehub#11732](https://github.com/jaworldwideorg/OneJA-Bot/issues/11732) ([1eff864](1eff864)) #### What's fixed * **copilot**: History popover not refreshing when agentId changes, closes [lobehub#11731](https://github.com/jaworldwideorg/OneJA-Bot/issues/11731) ([64f39e7](64f39e7)) * **editor**: Prevent crash when toggling enableInputMarkdown setting, closes [lobehub#11755](https://github.com/jaworldwideorg/OneJA-Bot/issues/11755) ([ea5eed8](ea5eed8)) * **home**: Use correct CreateGroupModal for session group creation, closes [lobehub#11752](https://github.com/jaworldwideorg/OneJA-Bot/issues/11752) ([36bcc50](36bcc50)) * **model-runtime**: Handle null content in anthropic message builder, closes [lobehub#11756](https://github.com/jaworldwideorg/OneJA-Bot/issues/11756) ([539753a](539753a)) * **ModelSelect**: Resolve tooltip hover causing popup to close, closes [lobehub#11742](https://github.com/jaworldwideorg/OneJA-Bot/issues/11742) ([1b73f14](1b73f14)) * **pdf**: Ensure worker config before Document render, closes [lobehub#11746](https://github.com/jaworldwideorg/OneJA-Bot/issues/11746) ([ad34072](ad34072)) * **store**: Delete message before regeneration, closes [lobehub#11760](https://github.com/jaworldwideorg/OneJA-Bot/issues/11760) ([a8a6300](a8a6300)) * **misc**: Fix auto scroll, closes [lobehub#11734](https://github.com/jaworldwideorg/OneJA-Bot/issues/11734) ([892fa9f](892fa9f)) * **misc**: Fix favorite refresh bug and group topic refresh issue, closes [lobehub#11745](https://github.com/jaworldwideorg/OneJA-Bot/issues/11745) ([5d115ef](5d115ef)) * **misc**: Fixed the agent group builder tools excaution edge case crash, closes [lobehub#11735](https://github.com/jaworldwideorg/OneJA-Bot/issues/11735) ([5de4742](5de4742)) * **misc**: Page content switch mismatch, closes [lobehub#11758](https://github.com/jaworldwideorg/OneJA-Bot/issues/11758) ([fdc8f95](fdc8f95)) * **misc**: When use market group, the group sys role was not used, closes [lobehub#11739](https://github.com/jaworldwideorg/OneJA-Bot/issues/11739) ([afc76f9](afc76f9)) </details> <div align="right"> [![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top) </div>

sourcery-ai bot reviewed Jan 23, 2026

View reviewed changes

dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. 🐛 Bug labels Jan 23, 2026

arvinxx changed the base branch from main to next January 23, 2026 14:46

dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. and removed size:XXL This PR changes 1000+ lines, ignoring generated files. labels Jan 23, 2026

fix

aa7cc04

arvinxx merged commit 36bcc50 into next Jan 23, 2026
35 of 37 checks passed

arvinxx deleted the fix/LOBE-4192 branch January 23, 2026 15:12

lobehubbot added the released on @next label Jan 23, 2026

vercel bot had a problem deploying to Preview January 23, 2026 15:49 Failure

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

🐛 fix(home): use correct CreateGroupModal for session group creation#11752

🐛 fix(home): use correct CreateGroupModal for session group creation#11752
arvinxx merged 2 commits intonextfrom
fix/LOBE-4192

arvinxx commented Jan 23, 2026

Uh oh!

sourcery-ai bot left a comment

Uh oh!

vercel bot commented Jan 23, 2026 •

edited

Loading

Uh oh!

codecov bot commented Jan 23, 2026 •

edited

Loading

Uh oh!

Uh oh!

gru-agent bot commented Jan 23, 2026

Uh oh!

lobehubbot commented Jan 23, 2026

Uh oh!

lobehubbot commented Jan 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

arvinxx commented Jan 23, 2026

Summary

Problem

Solution

Changes

Test plan

Related Issues

Uh oh!

sourcery-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

vercel bot commented Jan 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Jan 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

gru-agent bot commented Jan 23, 2026

Uh oh!

lobehubbot commented Jan 23, 2026

Uh oh!

lobehubbot commented Jan 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

vercel bot commented Jan 23, 2026 •

edited

Loading

codecov bot commented Jan 23, 2026 •

edited

Loading