Skip to content

πŸ› fix(pdf): ensure worker config before Document render#11746

Merged
Innei merged 2 commits intonextfrom
fix/pdf-worker-config
Jan 23, 2026
Merged

πŸ› fix(pdf): ensure worker config before Document render#11746
Innei merged 2 commits intonextfrom
fix/pdf-worker-config

Conversation

@Innei
Copy link
Copy Markdown
Member

@Innei Innei commented Jan 23, 2026

πŸ’» Change Type

  • πŸ› fix

πŸ”— Related Issue

Closes LOBE-4108

πŸ”€ Description of Change

Fixes "No GlobalWorkerOptions.workerSrc specified" error that occurs with TurboPack bundler.

Root Cause:

  • Side-effect imports (import '@/libs/pdfjs/worker') may be optimized away by TurboPack
  • Module execution order is not guaranteed with 'use client' components

Solution:

  • Created unified @/libs/pdfjs module that wraps the Document component
  • The wrapper calls ensureWorker() before render, guaranteeing worker config is set
  • Removed unreliable side-effect import files

Changes:

  • src/libs/pdfjs/index.tsx - New unified module with wrapped Document component
  • src/features/FileViewer/Renderer/PDF/index.tsx - Import from unified module
  • src/features/ShareModal/SharePdf/PdfPreview.tsx - Import from unified module
  • Deleted src/libs/pdfjs/worker.ts and src/libs/pdfjs/pdf.worker.ts

πŸ§ͺ How to Test

  • Tested locally
  • Added/updated tests
  • No tests needed
  1. Navigate to a page that displays PDF files
  2. Verify PDF renders without "No GlobalWorkerOptions.workerSrc specified" error
  3. Test in both development (TurboPack) and production builds

Summary by Sourcery

Ensure PDF.js worker is configured before rendering PDF documents to avoid runtime errors with TurboPack bundling.

Bug Fixes:

  • Prevent "No GlobalWorkerOptions.workerSrc specified" errors when rendering PDFs by guaranteeing the PDF.js worker source is set before Document renders.

Enhancements:

  • Introduce a unified pdfjs module that wraps the react-pdf Document component and centralizes worker configuration.
  • Simplify PDF rendering usage by re-exporting Page and pdfjs from the new pdfjs module and cleaning up obsolete worker-only modules.

Fixes "No GlobalWorkerOptions.workerSrc specified" error in TurboPack by:
- Creating unified pdfjs module that ensures worker config at render time
- Wrapping Document component to call ensureWorker() before render
- Removing side-effect imports that may be optimized away by bundler

Closes LOBE-4108
@vercel
Copy link
Copy Markdown

vercel bot commented Jan 23, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Review Updated (UTC)
lobehub Ignored Ignored Preview Jan 23, 2026 1:39pm

Request Review

@sourcery-ai
Copy link
Copy Markdown
Contributor

sourcery-ai bot commented Jan 23, 2026

Reviewer's Guide

Introduces a unified pdfjs wrapper module that ensures the PDF worker is configured before any render, updates call sites to use it, and removes fragile side-effect-based worker setup while making a minor cleanup in a PDF viewer map callback.

Sequence diagram for ensuring pdfjs worker before Document render

sequenceDiagram
  actor User
  participant ReactComponent as PDFViewer_or_PdfPreview
  participant WrapperDocument as Document
  participant PdfJS as pdfjs
  participant GlobalWorkerOptions
  participant PdfDocument as ReactPdf_Document

  User->>ReactComponent: Navigate to PDF view
  ReactComponent->>WrapperDocument: Render Document(props)
  WrapperDocument->>WrapperDocument: ensureWorker()
  WrapperDocument->>PdfJS: Access pdfjs.GlobalWorkerOptions.workerSrc
  alt workerSrc not set
    WrapperDocument->>GlobalWorkerOptions: Set workerSrc = workerSrc_constant
  end
  WrapperDocument->>PdfDocument: Render PdfDocument(props)
  PdfDocument-->>ReactComponent: Rendered PDF pages
  ReactComponent-->>User: Display PDF without workerSrc error
Loading

Class diagram for unified pdfjs wrapper module

classDiagram
  class pdfjs {
    +string version
  }

  class GlobalWorkerOptions {
    +string workerSrc
  }

  class PdfDocument {
    <<external>>
  }

  class PdfPage {
    <<external>>
  }

  class PdfjsModule {
    +string workerSrc
    +ensureWorker() void
  }

  class Document {
    +props DocumentProps
    +render() void
  }

  class Page {
    <<re_export>>
  }

  class DocumentProps {
  }

  class PageProps {
  }

  PdfjsModule --> pdfjs : uses
  PdfjsModule --> GlobalWorkerOptions : configures
  Document --> PdfjsModule : calls ensureWorker
  Document --> PdfDocument : wraps
  Page --> PdfPage : re_exports
  DocumentProps --> PdfDocument : based_on
  PageProps --> PdfPage : based_on
Loading

File-Level Changes

Change Details Files
Ensure pdf.js worker is configured via an explicit wrapper component instead of side-effect imports.
  • Add a new client-side pdfjs module that wraps react-pdf's Document component and calls ensureWorker() before rendering to guarantee GlobalWorkerOptions.workerSrc is set.
  • Derive Document and Page prop types from react-pdf's components to preserve typing at call sites.
  • Export Page and pdfjs directly from the new module so consumers can import all PDF-related primitives from a single location.
src/libs/pdfjs/index.tsx
Update PDF rendering features to consume the new unified pdfjs module.
  • Change PDF renderer feature to import Document/Page/pdfjs from the new pdfjs wrapper module instead of previous paths or side-effect worker imports.
  • Change PDF preview in the share modal to import from the new pdfjs wrapper module, ensuring worker initialization in that flow as well.
  • Refine the Array.from callback in the PDF viewer to ignore the unused element parameter using an underscore placeholder.
src/features/FileViewer/Renderer/PDF/index.tsx
src/features/ShareModal/SharePdf/PdfPreview.tsx
Remove obsolete side-effect-based pdf.js worker configuration files.
  • Delete pdf.worker.ts that previously configured the pdf.js worker via side effects.
  • Delete worker.ts that relied on side-effect imports for worker setup, which was unreliable under TurboPack.
src/libs/pdfjs/pdf.worker.ts
src/libs/pdfjs/worker.ts

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Jan 23, 2026
@gru-agent
Copy link
Copy Markdown
Contributor

gru-agent bot commented Jan 23, 2026

TestGru Assignment

Summary

Link CommitId Status Reason
Detail 534cd17 🚫 Skipped No files need to be tested {"src/features/FileViewer/Renderer/PDF/index.tsx":"File path does not match include patterns.","src/features/ShareModal/SharePdf/PdfPreview.tsx":"File path does not match include patterns.","src/libs/pdfjs/index.tsx":"File path does not match include patterns.","src/libs/pdfjs/pdf.worker.ts":"File path does not match include patterns.","src/libs/pdfjs/worker.ts":"File path does not match include patterns."}

History Assignment

Tip

You can @gru-agent and leave your feedback. TestGru will make adjustments based on your input

@dosubot dosubot bot added the πŸ› Bug label Jan 23, 2026
Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've found 2 issues, and left some high level feedback:

  • Consider making workerSrc configurable (e.g., via an env or a small config helper) instead of hardcoding the npm mirror URL so that deployments can switch CDNs or self-host the worker without touching code.
  • The new ensureWorker helper only checks pdfjs.GlobalWorkerOptions.workerSrc; if other worker-related global options are required in the future (e.g., different worker for SSR vs client), it might be worth centralizing all worker configuration there to avoid scattered setups.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Consider making `workerSrc` configurable (e.g., via an env or a small config helper) instead of hardcoding the npm mirror URL so that deployments can switch CDNs or self-host the worker without touching code.
- The new `ensureWorker` helper only checks `pdfjs.GlobalWorkerOptions.workerSrc`; if other worker-related global options are required in the future (e.g., different worker for SSR vs client), it might be worth centralizing all worker configuration there to avoid scattered setups.

## Individual Comments

### Comment 1
<location> `src/libs/pdfjs/index.tsx:6` </location>
<code_context>
+import type { ComponentProps } from 'react';
+import { Document as PdfDocument, Page as PdfPage, pdfjs } from 'react-pdf';
+
+const workerSrc = `https://registry.npmmirror.com/pdfjs-dist/${pdfjs.version}/files/build/pdf.worker.min.mjs`;
+
+function ensureWorker() {
</code_context>

<issue_to_address>
**suggestion:** Consider making the worker URL configurable instead of hardcoding a specific CDN/mirror.

Using a hardcoded `registry.npmmirror.com` URL tightly couples the app to a single external mirror and can cause issues with regional access, outages, or CSP-restricted environments. Please source this URL from configuration (env, runtime config, or a shared constants module) with a reasonable default so deployments can select their own hosting (e.g., self-hosted asset or preferred CDN).

Suggested implementation:

```typescript
import type { ComponentProps } from 'react';
import { Document as PdfDocument, Page as PdfPage, pdfjs } from 'react-pdf';

const DEFAULT_PDF_WORKER_SRC = `https://registry.npmmirror.com/pdfjs-dist/${pdfjs.version}/files/build/pdf.worker.min.mjs`;

/**
 * Resolve the PDF worker source URL from configuration with a sensible default.
 *
 * Prefer an environment-driven configuration so deployments can select their own
 * hosting (self-hosted assets, preferred CDN, etc.).
 */
const pdfWorkerSrc =
  // Public runtime config (e.g. Next.js) – adjust name to match your conventions if needed
  process.env.NEXT_PUBLIC_PDFJS_WORKER_URL ??
  DEFAULT_PDF_WORKER_SRC;

function ensureWorker() {
  if (!pdfjs.GlobalWorkerOptions.workerSrc) {
    pdfjs.GlobalWorkerOptions.workerSrc = pdfWorkerSrc;
  }
}

```

1. Define the environment variable (e.g. `NEXT_PUBLIC_PDFJS_WORKER_URL`) in your runtime configuration (.env or equivalent) if you want to override the default worker URL in specific environments.
2. If your project uses a different pattern for exposing public runtime config (for example, a `config` module or `publicRuntimeConfig` via Next.js), you may want to replace the `process.env.NEXT_PUBLIC_PDFJS_WORKER_URL` access with that shared configuration source instead, while keeping the same fallback to `DEFAULT_PDF_WORKER_SRC`.
</issue_to_address>

### Comment 2
<location> `src/libs/pdfjs/index.tsx:17-25` </location>
<code_context>
+export type DocumentProps = ComponentProps<typeof PdfDocument>;
+export type PageProps = ComponentProps<typeof PdfPage>;
+
+export const Document = (props: DocumentProps) => {
+  ensureWorker();
+  return <PdfDocument {...props} />;
+};
+
+
+
+
+export {Page, pdfjs} from 'react-pdf';
\ No newline at end of file
</code_context>

<issue_to_address>
**issue (bug_risk):** Page is re-exported without ensureWorker, which can break future usages that don’t go through Document.

Because `Page` is re-exported directly from `react-pdf`, it assumes callers always render it under this wrapped `Document`. If someone later imports `{ Page }` from this module and uses it elsewhere, the worker may not be initialized and PDF rendering can fail. To avoid this, export a local `Page` wrapper that calls `ensureWorker()` before delegating to `PdfPage`.
</issue_to_address>

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click πŸ‘ or πŸ‘Ž on each comment and I'll use the feedback to improve your reviews.

import type { ComponentProps } from 'react';
import { Document as PdfDocument, Page as PdfPage, pdfjs } from 'react-pdf';

const workerSrc = `https://registry.npmmirror.com/pdfjs-dist/${pdfjs.version}/files/build/pdf.worker.min.mjs`;
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: Consider making the worker URL configurable instead of hardcoding a specific CDN/mirror.

Using a hardcoded registry.npmmirror.com URL tightly couples the app to a single external mirror and can cause issues with regional access, outages, or CSP-restricted environments. Please source this URL from configuration (env, runtime config, or a shared constants module) with a reasonable default so deployments can select their own hosting (e.g., self-hosted asset or preferred CDN).

Suggested implementation:

import type { ComponentProps } from 'react';
import { Document as PdfDocument, Page as PdfPage, pdfjs } from 'react-pdf';

const DEFAULT_PDF_WORKER_SRC = `https://registry.npmmirror.com/pdfjs-dist/${pdfjs.version}/files/build/pdf.worker.min.mjs`;

/**
 * Resolve the PDF worker source URL from configuration with a sensible default.
 *
 * Prefer an environment-driven configuration so deployments can select their own
 * hosting (self-hosted assets, preferred CDN, etc.).
 */
const pdfWorkerSrc =
  // Public runtime config (e.g. Next.js) – adjust name to match your conventions if needed
  process.env.NEXT_PUBLIC_PDFJS_WORKER_URL ??
  DEFAULT_PDF_WORKER_SRC;

function ensureWorker() {
  if (!pdfjs.GlobalWorkerOptions.workerSrc) {
    pdfjs.GlobalWorkerOptions.workerSrc = pdfWorkerSrc;
  }
}
  1. Define the environment variable (e.g. NEXT_PUBLIC_PDFJS_WORKER_URL) in your runtime configuration (.env or equivalent) if you want to override the default worker URL in specific environments.
  2. If your project uses a different pattern for exposing public runtime config (for example, a config module or publicRuntimeConfig via Next.js), you may want to replace the process.env.NEXT_PUBLIC_PDFJS_WORKER_URL access with that shared configuration source instead, while keeping the same fallback to DEFAULT_PDF_WORKER_SRC.

Comment on lines +17 to +25
export const Document = (props: DocumentProps) => {
ensureWorker();
return <PdfDocument {...props} />;
};




export {Page, pdfjs} from 'react-pdf'; No newline at end of file
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue (bug_risk): Page is re-exported without ensureWorker, which can break future usages that don’t go through Document.

Because Page is re-exported directly from react-pdf, it assumes callers always render it under this wrapped Document. If someone later imports { Page } from this module and uses it elsewhere, the worker may not be initialized and PDF rendering can fail. To avoid this, export a local Page wrapper that calls ensureWorker() before delegating to PdfPage.

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 23, 2026

Codecov Report

βœ… All modified and coverable lines are covered by tests.
βœ… Project coverage is 74.17%. Comparing base (892fa9f) to head (ffc59f9).
⚠️ Report is 13 commits behind head on next.

Additional details and impacted files
@@            Coverage Diff             @@
##             next   #11746      +/-   ##
==========================================
- Coverage   74.17%   74.17%   -0.01%     
==========================================
  Files        1193     1193              
  Lines       94958    94958              
  Branches    12966    10491    -2475     
==========================================
- Hits        70437    70434       -3     
- Misses      24431    24434       +3     
  Partials       90       90              
Flag Coverage Ξ”
app 67.20% <ΓΈ> (-0.01%) ⬇️
database 91.48% <ΓΈ> (ΓΈ)
packages/agent-runtime 90.20% <ΓΈ> (ΓΈ)
packages/context-engine 85.36% <ΓΈ> (ΓΈ)
packages/conversation-flow 92.28% <ΓΈ> (ΓΈ)
packages/file-loaders 87.04% <ΓΈ> (ΓΈ)
packages/memory-user-memory 69.68% <ΓΈ> (ΓΈ)
packages/model-bank 100.00% <ΓΈ> (ΓΈ)
packages/model-runtime 86.72% <ΓΈ> (ΓΈ)
packages/prompts 79.33% <ΓΈ> (ΓΈ)
packages/python-interpreter 92.90% <ΓΈ> (ΓΈ)
packages/ssrf-safe-fetch 0.00% <ΓΈ> (ΓΈ)
packages/utils 93.22% <ΓΈ> (ΓΈ)
packages/web-crawler 95.62% <ΓΈ> (ΓΈ)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Ξ”
Store 67.96% <ΓΈ> (ΓΈ)
Services 50.58% <ΓΈ> (ΓΈ)
Server 67.70% <ΓΈ> (-0.02%) ⬇️
Libs 40.36% <ΓΈ> (ΓΈ)
Utils 93.60% <ΓΈ> (ΓΈ)
πŸš€ New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • πŸ“¦ JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Innei Innei merged commit ad34072 into next Jan 23, 2026
36 checks passed
@Innei Innei deleted the fix/pdf-worker-config branch January 23, 2026 14:19
@lobehubbot
Copy link
Copy Markdown
Member

❀️ Great PR @Innei ❀️

The growth of project is inseparable from user feedback and contribution, thanks for your contribution! If you are interesting with the lobehub developer community, please join our discord and then dm @arvinxx or @canisminor1990. They will invite you to our private developer channel. We are talking about the lobe-chat development or sharing ai newsletter around the world.

lobehubbot pushed a commit that referenced this pull request Jan 23, 2026
## [Version&nbsp;2.0.0-next.354](v2.0.0-next.353...v2.0.0-next.354)
<sup>Released on **2026-01-23**</sup>

#### β™» Code Refactoring

- **misc**: Migrate AI Rules to Claude Code Skills.

#### πŸ› Bug Fixes

- **pdf**: Ensure worker config before Document render.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### Code refactoring

* **misc**: Migrate AI Rules to Claude Code Skills, closes [#11737](#11737) ([346fc46](346fc46))

#### What's fixed

* **pdf**: Ensure worker config before Document render, closes [#11746](#11746) ([ad34072](ad34072))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
@lobehubbot
Copy link
Copy Markdown
Member

πŸŽ‰ This PR is included in version 2.0.0-next.354 πŸŽ‰

The release is available on:

Your semantic-release bot πŸ“¦πŸš€

JamieStivala pushed a commit to jaworldwideorg/OneJA-Bot that referenced this pull request Jan 23, 2026
## [Version&nbsp;1.154.0](v1.153.1...v1.154.0)
<sup>Released on **2026-01-23**</sup>

#### β™» Code Refactoring

- **misc**: Migrate AI Rules to Claude Code Skills.

#### ✨ Features

- **database**: Extended async task with metadata and parent id, added index.
- **misc**: Remove NextAuth.

#### πŸ› Bug Fixes

- **copilot**: History popover not refreshing when agentId changes.
- **editor**: Prevent crash when toggling enableInputMarkdown setting.
- **home**: Use correct CreateGroupModal for session group creation.
- **model-runtime**: Handle null content in anthropic message builder.
- **ModelSelect**: Resolve tooltip hover causing popup to close.
- **pdf**: Ensure worker config before Document render.
- **store**: Delete message before regeneration.
- **misc**: Fix auto scroll, fix favorite refresh bug and group topic refresh issue, fixed the agent group builder tools excaution edge case crash, page content switch mismatch, when use market group, the group sys role was not used.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### Code refactoring

* **misc**: Migrate AI Rules to Claude Code Skills, closes [lobehub#11737](https://github.com/jaworldwideorg/OneJA-Bot/issues/11737) ([346fc46](346fc46))

#### What's improved

* **database**: Extended async task with metadata and parent id, added index, closes [lobehub#11712](https://github.com/jaworldwideorg/OneJA-Bot/issues/11712) ([31d2f26](31d2f26))
* **misc**: Remove NextAuth, closes [lobehub#11732](https://github.com/jaworldwideorg/OneJA-Bot/issues/11732) ([1eff864](1eff864))

#### What's fixed

* **copilot**: History popover not refreshing when agentId changes, closes [lobehub#11731](https://github.com/jaworldwideorg/OneJA-Bot/issues/11731) ([64f39e7](64f39e7))
* **editor**: Prevent crash when toggling enableInputMarkdown setting, closes [lobehub#11755](https://github.com/jaworldwideorg/OneJA-Bot/issues/11755) ([ea5eed8](ea5eed8))
* **home**: Use correct CreateGroupModal for session group creation, closes [lobehub#11752](https://github.com/jaworldwideorg/OneJA-Bot/issues/11752) ([36bcc50](36bcc50))
* **model-runtime**: Handle null content in anthropic message builder, closes [lobehub#11756](https://github.com/jaworldwideorg/OneJA-Bot/issues/11756) ([539753a](539753a))
* **ModelSelect**: Resolve tooltip hover causing popup to close, closes [lobehub#11742](https://github.com/jaworldwideorg/OneJA-Bot/issues/11742) ([1b73f14](1b73f14))
* **pdf**: Ensure worker config before Document render, closes [lobehub#11746](https://github.com/jaworldwideorg/OneJA-Bot/issues/11746) ([ad34072](ad34072))
* **store**: Delete message before regeneration, closes [lobehub#11760](https://github.com/jaworldwideorg/OneJA-Bot/issues/11760) ([a8a6300](a8a6300))
* **misc**: Fix auto scroll, closes [lobehub#11734](https://github.com/jaworldwideorg/OneJA-Bot/issues/11734) ([892fa9f](892fa9f))
* **misc**: Fix favorite refresh bug and group topic refresh issue, closes [lobehub#11745](https://github.com/jaworldwideorg/OneJA-Bot/issues/11745) ([5d115ef](5d115ef))
* **misc**: Fixed the agent group builder tools excaution edge case crash, closes [lobehub#11735](https://github.com/jaworldwideorg/OneJA-Bot/issues/11735) ([5de4742](5de4742))
* **misc**: Page content switch mismatch, closes [lobehub#11758](https://github.com/jaworldwideorg/OneJA-Bot/issues/11758) ([fdc8f95](fdc8f95))
* **misc**: When use market group, the group sys role was not used, closes [lobehub#11739](https://github.com/jaworldwideorg/OneJA-Bot/issues/11739) ([afc76f9](afc76f9))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

πŸ› Bug released on @next size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants