Skip to content

✨ feat(database): extended async task with metadata and parent id, added index#11712

Merged
nekomeowww merged 2 commits intonextfrom
neko/dev/async-task-improve
Jan 23, 2026
Merged

✨ feat(database): extended async task with metadata and parent id, added index#11712
nekomeowww merged 2 commits intonextfrom
neko/dev/async-task-improve

Conversation

@nekomeowww
Copy link
Copy Markdown
Member

@nekomeowww nekomeowww commented Jan 22, 2026

💻 Change Type

  • ✨ feat
  • 🐛 fix
  • ♻️ refactor
  • 💄 style
  • 👷 build
  • ⚡️ perf
  • ✅ test
  • 📝 docs
  • 🔨 chore

🔗 Related Issue

🔀 Description of Change

🧪 How to Test

  • Tested locally
  • Added/updated tests
  • No tests needed

📸 Screenshots / Videos

Before After
... ...

📝 Additional Information

Summary by Sourcery

Add support for storing parent relationships and arbitrary metadata on async tasks in the database schema.

New Features:

  • Extend async task records with an optional parent task identifier.
  • Add a JSONB metadata field to async tasks for storing structured auxiliary data.

@vercel
Copy link
Copy Markdown

vercel bot commented Jan 22, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
lobehub Error Error Jan 23, 2026 4:18pm

Request Review

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Jan 22, 2026
@sourcery-ai
Copy link
Copy Markdown
Contributor

sourcery-ai bot commented Jan 22, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Adds optional parent task linkage and JSON metadata to async tasks, including schema updates and a new migration with snapshot/journal metadata.

ER diagram for updated async_tasks table with parentId and metadata

erDiagram
  users {
    uuid id PK
  }

  async_tasks {
    uuid id PK
    uuid user_id FK
    integer duration
    uuid parent_id FK
    jsonb metadata
  }

  users ||--o{ async_tasks : user_async_tasks
  async_tasks ||--o{ async_tasks : parent_child_tasks
Loading

File-Level Changes

Change Details Files
Extend async task schema to support parent-child relationships and arbitrary metadata.
  • Add nullable UUID parentId column to asyncTasks schema to reference a parent task.
  • Add non-null jsonb metadata column with default '{}' to asyncTasks schema for storing arbitrary task metadata.
  • Include new columns in the SQL migration altering async_tasks with IF NOT EXISTS safeguards.
  • Update database schema docs and migration metadata (journal and snapshot) to reflect the new async_tasks columns.
packages/database/src/schemas/asyncTask.ts
packages/database/migrations/0071_add_async_task_metadata.sql
docs/development/database-schema.dbml
packages/database/migrations/meta/_journal.json
packages/database/migrations/meta/0071_snapshot.json

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@gru-agent
Copy link
Copy Markdown
Contributor

gru-agent bot commented Jan 22, 2026

TestGru Assignment

Summary

Link CommitId Status Reason
Detail 105751501a76800affe7e9a525d279dd5e6376af 🚫 Skipped No files need to be tested {"docs/development/database-schema.dbml":"File path does not match include patterns.","packages/database/migrations/0071_add_async_task_metadata.sql":"File path does not match include patterns.","packages/database/migrations/meta/0071_snapshot.json":"File path does not match include patterns.","packages/database/migrations/meta/_journal.json":"File path does not match include patterns.","packages/database/src/schemas/asyncTask.ts":"Can not find valuable test target.\nasyncTasks: Out of scope - The exported symbol is a table schema definition with no functions or classes. It primarily defines the structure of a database table and is used for integration with the database layer, making it more suitable for integration testing rather than unit testing.\nNewAsyncTask…"}

History Assignment

Tip

You can @gru-agent and leave your feedback. TestGru will make adjustments based on your input

Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • If parentId is meant to model a parent–child relationship between async tasks, consider adding an explicit foreign key constraint to async_tasks.id (with a defined ON DELETE behavior) so referential integrity is enforced at the database level.
  • If you expect to query tasks frequently by parent_id (e.g., fetching children for a given parent), consider adding an index on this column to avoid performance issues as the table grows.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- If `parentId` is meant to model a parent–child relationship between async tasks, consider adding an explicit foreign key constraint to `async_tasks.id` (with a defined `ON DELETE` behavior) so referential integrity is enforced at the database level.
- If you expect to query tasks frequently by `parent_id` (e.g., fetching children for a given parent), consider adding an index on this column to avoid performance issues as the table grows.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@codecov
Copy link
Copy Markdown

codecov bot commented Jan 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.17%. Comparing base (923cdca) to head (0d27a6e).
⚠️ Report is 12 commits behind head on next.

Additional details and impacted files
@@           Coverage Diff           @@
##             next   #11712   +/-   ##
=======================================
  Coverage   74.17%   74.17%           
=======================================
  Files        1193     1193           
  Lines       94958    94958           
  Branches    10492    10492           
=======================================
  Hits        70437    70437           
  Misses      24431    24431           
  Partials       90       90           
Flag Coverage Δ
app 67.21% <ø> (ø)
database 91.48% <ø> (ø)
packages/agent-runtime 90.20% <ø> (ø)
packages/context-engine 85.36% <ø> (ø)
packages/conversation-flow 92.28% <ø> (ø)
packages/file-loaders 87.04% <ø> (ø)
packages/memory-user-memory 69.68% <ø> (ø)
packages/model-bank 100.00% <ø> (ø)
packages/model-runtime 86.72% <ø> (ø)
packages/prompts 79.33% <ø> (ø)
packages/python-interpreter 92.90% <ø> (ø)
packages/ssrf-safe-fetch 0.00% <ø> (ø)
packages/utils 93.22% <ø> (ø)
packages/web-crawler 95.62% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Store 67.96% <ø> (ø)
Services 50.58% <ø> (ø)
Server 67.71% <ø> (ø)
Libs 40.36% <ø> (ø)
Utils 93.60% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nekomeowww nekomeowww force-pushed the neko/dev/async-task-improve branch from 1057515 to caa59e8 Compare January 22, 2026 14:51
@nekomeowww nekomeowww changed the title ✨ feat(database): added metadata & parent id to async task ✨ feat(database): extended async task with metadata and parent id, added index Jan 22, 2026
@nekomeowww nekomeowww force-pushed the neko/dev/async-task-improve branch from c1752f9 to 0d27a6e Compare January 23, 2026 13:33
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels Jan 23, 2026
@nekomeowww nekomeowww merged commit 31d2f26 into next Jan 23, 2026
48 of 50 checks passed
@nekomeowww nekomeowww deleted the neko/dev/async-task-improve branch January 23, 2026 13:49
@lobehubbot
Copy link
Copy Markdown
Member

❤️ Great PR @nekomeowww ❤️

The growth of project is inseparable from user feedback and contribution, thanks for your contribution! If you are interesting with the lobehub developer community, please join our discord and then dm @arvinxx or @canisminor1990. They will invite you to our private developer channel. We are talking about the lobe-chat development or sharing ai newsletter around the world.

lobehubbot pushed a commit that referenced this pull request Jan 23, 2026
## [Version&nbsp;2.0.0-next.353](v2.0.0-next.352...v2.0.0-next.353)
<sup>Released on **2026-01-23**</sup>

#### ✨ Features

- **database**: Extended async task with metadata and parent id, added index.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### What's improved

* **database**: Extended async task with metadata and parent id, added index, closes [#11712](#11712) ([31d2f26](31d2f26))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
@lobehubbot
Copy link
Copy Markdown
Member

🎉 This PR is included in version 2.0.0-next.353 🎉

The release is available on:

Your semantic-release bot 📦🚀

JamieStivala pushed a commit to jaworldwideorg/OneJA-Bot that referenced this pull request Jan 23, 2026
## [Version&nbsp;1.154.0](v1.153.1...v1.154.0)
<sup>Released on **2026-01-23**</sup>

#### ♻ Code Refactoring

- **misc**: Migrate AI Rules to Claude Code Skills.

#### ✨ Features

- **database**: Extended async task with metadata and parent id, added index.
- **misc**: Remove NextAuth.

#### 🐛 Bug Fixes

- **copilot**: History popover not refreshing when agentId changes.
- **editor**: Prevent crash when toggling enableInputMarkdown setting.
- **home**: Use correct CreateGroupModal for session group creation.
- **model-runtime**: Handle null content in anthropic message builder.
- **ModelSelect**: Resolve tooltip hover causing popup to close.
- **pdf**: Ensure worker config before Document render.
- **store**: Delete message before regeneration.
- **misc**: Fix auto scroll, fix favorite refresh bug and group topic refresh issue, fixed the agent group builder tools excaution edge case crash, page content switch mismatch, when use market group, the group sys role was not used.

<br/>

<details>
<summary><kbd>Improvements and Fixes</kbd></summary>

#### Code refactoring

* **misc**: Migrate AI Rules to Claude Code Skills, closes [lobehub#11737](https://github.com/jaworldwideorg/OneJA-Bot/issues/11737) ([346fc46](346fc46))

#### What's improved

* **database**: Extended async task with metadata and parent id, added index, closes [lobehub#11712](https://github.com/jaworldwideorg/OneJA-Bot/issues/11712) ([31d2f26](31d2f26))
* **misc**: Remove NextAuth, closes [lobehub#11732](https://github.com/jaworldwideorg/OneJA-Bot/issues/11732) ([1eff864](1eff864))

#### What's fixed

* **copilot**: History popover not refreshing when agentId changes, closes [lobehub#11731](https://github.com/jaworldwideorg/OneJA-Bot/issues/11731) ([64f39e7](64f39e7))
* **editor**: Prevent crash when toggling enableInputMarkdown setting, closes [lobehub#11755](https://github.com/jaworldwideorg/OneJA-Bot/issues/11755) ([ea5eed8](ea5eed8))
* **home**: Use correct CreateGroupModal for session group creation, closes [lobehub#11752](https://github.com/jaworldwideorg/OneJA-Bot/issues/11752) ([36bcc50](36bcc50))
* **model-runtime**: Handle null content in anthropic message builder, closes [lobehub#11756](https://github.com/jaworldwideorg/OneJA-Bot/issues/11756) ([539753a](539753a))
* **ModelSelect**: Resolve tooltip hover causing popup to close, closes [lobehub#11742](https://github.com/jaworldwideorg/OneJA-Bot/issues/11742) ([1b73f14](1b73f14))
* **pdf**: Ensure worker config before Document render, closes [lobehub#11746](https://github.com/jaworldwideorg/OneJA-Bot/issues/11746) ([ad34072](ad34072))
* **store**: Delete message before regeneration, closes [lobehub#11760](https://github.com/jaworldwideorg/OneJA-Bot/issues/11760) ([a8a6300](a8a6300))
* **misc**: Fix auto scroll, closes [lobehub#11734](https://github.com/jaworldwideorg/OneJA-Bot/issues/11734) ([892fa9f](892fa9f))
* **misc**: Fix favorite refresh bug and group topic refresh issue, closes [lobehub#11745](https://github.com/jaworldwideorg/OneJA-Bot/issues/11745) ([5d115ef](5d115ef))
* **misc**: Fixed the agent group builder tools excaution edge case crash, closes [lobehub#11735](https://github.com/jaworldwideorg/OneJA-Bot/issues/11735) ([5de4742](5de4742))
* **misc**: Page content switch mismatch, closes [lobehub#11758](https://github.com/jaworldwideorg/OneJA-Bot/issues/11758) ([fdc8f95](fdc8f95))
* **misc**: When use market group, the group sys role was not used, closes [lobehub#11739](https://github.com/jaworldwideorg/OneJA-Bot/issues/11739) ([afc76f9](afc76f9))

</details>

<div align="right">

[![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top)

</div>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

released on @next size:M This PR changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants