🐛 fix(copilot): history popover not refreshing when agentId changes by Innei · Pull Request #11731 · lobehub/lobehub

Innei · 2026-01-23T08:46:37Z

💻 Change Type

🐛 fix
💄 style

🔗 Related Issue

Fixes LOBE-3910

🔀 Description of Change

Bug Fix: History not refreshing when switching agent

The codebase has two separate stores that both maintain an activeAgentId:

useAgentStore.activeAgentId - updated when user switches agent
useChatStore.activeAgentId - used by topic selectors

When switching agents via AgentSelector, only agentStore.activeAgentId was being updated, while chatStore.activeAgentId remained stale.

Solution: Added handleAgentChange callback that syncs both stores when switching agents.

UX Improvement: Loading state for history button

Previously, the history button would immediately disappear when switching agents (because topics data was undefined during loading), causing a jarring UI experience.

Solution:

Show loading/disabled state while topics are being fetched (topics === undefined)
Only hide the button when confirmed there are no topics (topics.length === 0)

🧪 How to Test

Tested locally
Added/updated tests
No tests needed

Open the Copilot panel
Switch between different agents using the agent selector
Verify that:
- The history button shows loading state briefly during switch
- History popover correctly shows topics for the selected agent
- Button only hides when agent truly has no topics

vercel · 2026-01-23T08:46:43Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Review	Updated (UTC)
lobehub	Ready	Preview, Comment	Jan 23, 2026 5:14pm

sourcery-ai · 2026-01-23T08:46:46Z

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates CopilotToolbar to derive topics from an agent-specific selector instead of the global active agent, ensuring the history popover refreshes correctly when the toolbar’s agentId prop changes.

Sequence diagram for CopilotToolbar topics refresh on agentId change

sequenceDiagram
  actor User
  participant CopilotToolbar
  participant ChatStore
  participant TopicSelectors
  participant HistoryPopover

  User->>CopilotToolbar: Select new agentId
  CopilotToolbar->>ChatStore: useChatStore(selector with getTopicsByAgentId(agentId))
  ChatStore->>TopicSelectors: getTopicsByAgentId(agentId)
  TopicSelectors-->>ChatStore: selectorFunction(state)
  ChatStore->>TopicSelectors: selectorFunction(state)
  TopicSelectors-->>CopilotToolbar: topics for agentId
  CopilotToolbar->>HistoryPopover: render topics for agentId
  HistoryPopover-->>User: Display updated history popover for selected agent

Updated class diagram for CopilotToolbar topic selection

classDiagram
  class CopilotToolbar {
    +string agentId
    +boolean isHovered
  }

  class ChatStore {
    +string activeTopicId
    +function switchTopic(topicId)
  }

  class TopicSelectors {
    +function currentTopics(state)
    +function getTopicsByAgentId(agentId)
  }

  class HistoryPopover {
    +function showTopics(topics)
  }

  CopilotToolbar --> ChatStore : uses_useChatStore
  CopilotToolbar --> TopicSelectors : uses_getTopicsByAgentId
  CopilotToolbar --> HistoryPopover : renders
  TopicSelectors --> ChatStore : reads_state_for_topics

File-Level Changes

Change	Details	Files
Use an agent-scoped topic selector in CopilotToolbar so history reflects the currently selected agentId prop instead of the global activeAgentId.	Replaced useChatStore selector usage from currentTopics, which depends on global activeAgentId, to getTopicsByAgentId(agentId) to make topics reactive to the agentId prop. Kept the rest of the CopilotToolbar state selection (activeTopicId and switchTopic) unchanged to limit impact to topic retrieval only.	`src/features/PageEditor/Copilot/Toolbar.tsx`

Tips and commands

Interacting with Sourcery

Trigger a new review: Comment @sourcery-ai review on the pull request.
Continue discussions: Reply directly to Sourcery's review comments.
Generate a GitHub issue from a review comment: Ask Sourcery to create an
issue from a review comment by replying to it. You can also reply to a
review comment with @sourcery-ai issue to create an issue from it.
Generate a pull request title: Write @sourcery-ai anywhere in the pull
request title to generate a title at any time. You can also comment
@sourcery-ai title on the pull request to (re-)generate the title at any time.
Generate a pull request summary: Write @sourcery-ai summary anywhere in
the pull request body to generate a PR summary at any time exactly where you
want it. You can also comment @sourcery-ai summary on the pull request to
(re-)generate the summary at any time.
Generate reviewer's guide: Comment @sourcery-ai guide on the pull
request to (re-)generate the reviewer's guide at any time.
Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
pull request to resolve all Sourcery comments. Useful if you've already
addressed all the comments and don't want to see them anymore.
Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
request to dismiss all existing Sourcery reviews. Especially useful if you
want to start fresh with a new review - don't forget to comment
@sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

Enable or disable review features such as the Sourcery-generated pull request
summary, the reviewer's guide, and others.
Change the review language.
Add, remove or edit custom review instructions.
Adjust other review settings.

Getting Help

Contact our support team for questions or feedback.
Visit our documentation for detailed guides and information.
Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

gru-agent · 2026-01-23T08:46:50Z

TestGru Assignment

Summary

Link	CommitId	Status	Reason
Detail	4ff6ba82a8be3253b102926d894028cb29b0fa68	🚫 Skipped	No files need to be tested {"src/features/PageEditor/Copilot/Toolbar.tsx":"File path does not match include patterns."}

History Assignment

Tip

You can @gru-agent and leave your feedback. TestGru will make adjustments based on your input

sourcery-ai

Hey - I've reviewed your changes and they look great!

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

When user switches agent in Copilot toolbar, also update useChatStore's activeAgentId to keep both stores in sync. This ensures topic selectors and other chatStore-dependent features work correctly.

…g agent - Show loading/disabled state while topics are being fetched - Only hide the button when confirmed there are no topics - Improves UX by avoiding sudden button disappearance during agent switch

codecov · 2026-01-23T09:07:27Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.14%. Comparing base (c484d1a) to head (a7ac86e).
⚠️ Report is 36 commits behind head on next.

Additional details and impacted files

@@           Coverage Diff            @@
##             next   #11731    +/-   ##
========================================
  Coverage   74.14%   74.14%            
========================================
  Files        1191     1191            
  Lines       94844    94844            
  Branches    12933    12500   -433     
========================================
  Hits        70324    70324            
  Misses      24430    24430            
  Partials       90       90

Flag	Coverage Δ
app	`67.17% <ø> (ø)`
database	`91.44% <ø> (ø)`
packages/agent-runtime	`90.20% <ø> (ø)`
packages/context-engine	`85.36% <ø> (ø)`
packages/conversation-flow	`92.28% <ø> (ø)`
packages/file-loaders	`87.04% <ø> (ø)`
packages/memory-user-memory	`69.68% <ø> (ø)`
packages/model-bank	`100.00% <ø> (ø)`
packages/model-runtime	`86.72% <ø> (ø)`
packages/prompts	`79.33% <ø> (ø)`
packages/python-interpreter	`92.90% <ø> (ø)`
packages/ssrf-safe-fetch	`0.00% <ø> (ø)`
packages/utils	`93.22% <ø> (ø)`
packages/web-crawler	`95.62% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
Store	`67.96% <ø> (ø)`
Services	`50.58% <ø> (ø)`
Server	`67.71% <ø> (ø)`
Libs	`40.36% <ø> (ø)`
Utils	`93.60% <ø> (ø)`

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

lobehubbot · 2026-01-23T09:36:14Z

❤️ Great PR @Innei ❤️

The growth of project is inseparable from user feedback and contribution, thanks for your contribution! If you are interesting with the lobehub developer community, please join our discord and then dm @arvinxx or @canisminor1990. They will invite you to our private developer channel. We are talking about the lobe-chat development or sharing ai newsletter around the world.

## [Version 2.0.0-next.348](v2.0.0-next.347...v2.0.0-next.348) <sup>Released on **2026-01-23**</sup> #### 🐛 Bug Fixes - **copilot**: History popover not refreshing when agentId changes. - **misc**: Fixed the agent group builder tools excaution edge case crash, fixed the group topic copy not right. <br/> <details> <summary><kbd>Improvements and Fixes</kbd></summary> #### What's fixed * **copilot**: History popover not refreshing when agentId changes, closes [#11731](#11731) ([64f39e7](64f39e7)) * **misc**: Fixed the agent group builder tools excaution edge case crash, closes [#11735](#11735) ([5de4742](5de4742)) * **misc**: Fixed the group topic copy not right, closes [#11730](#11730) ([282c1fb](282c1fb)) </details> <div align="right"> [![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top) </div>

lobehubbot · 2026-01-23T09:56:56Z

🎉 This PR is included in version 2.0.0-next.348 🎉

The release is available on:

Your semantic-release bot 📦🚀

## [Version 1.154.0](v1.153.1...v1.154.0) <sup>Released on **2026-01-23**</sup> #### ♻ Code Refactoring - **misc**: Migrate AI Rules to Claude Code Skills. #### ✨ Features - **database**: Extended async task with metadata and parent id, added index. - **misc**: Remove NextAuth. #### 🐛 Bug Fixes - **copilot**: History popover not refreshing when agentId changes. - **editor**: Prevent crash when toggling enableInputMarkdown setting. - **home**: Use correct CreateGroupModal for session group creation. - **model-runtime**: Handle null content in anthropic message builder. - **ModelSelect**: Resolve tooltip hover causing popup to close. - **pdf**: Ensure worker config before Document render. - **store**: Delete message before regeneration. - **misc**: Fix auto scroll, fix favorite refresh bug and group topic refresh issue, fixed the agent group builder tools excaution edge case crash, page content switch mismatch, when use market group, the group sys role was not used. <br/> <details> <summary><kbd>Improvements and Fixes</kbd></summary> #### Code refactoring * **misc**: Migrate AI Rules to Claude Code Skills, closes [lobehub#11737](https://github.com/jaworldwideorg/OneJA-Bot/issues/11737) ([346fc46](346fc46)) #### What's improved * **database**: Extended async task with metadata and parent id, added index, closes [lobehub#11712](https://github.com/jaworldwideorg/OneJA-Bot/issues/11712) ([31d2f26](31d2f26)) * **misc**: Remove NextAuth, closes [lobehub#11732](https://github.com/jaworldwideorg/OneJA-Bot/issues/11732) ([1eff864](1eff864)) #### What's fixed * **copilot**: History popover not refreshing when agentId changes, closes [lobehub#11731](https://github.com/jaworldwideorg/OneJA-Bot/issues/11731) ([64f39e7](64f39e7)) * **editor**: Prevent crash when toggling enableInputMarkdown setting, closes [lobehub#11755](https://github.com/jaworldwideorg/OneJA-Bot/issues/11755) ([ea5eed8](ea5eed8)) * **home**: Use correct CreateGroupModal for session group creation, closes [lobehub#11752](https://github.com/jaworldwideorg/OneJA-Bot/issues/11752) ([36bcc50](36bcc50)) * **model-runtime**: Handle null content in anthropic message builder, closes [lobehub#11756](https://github.com/jaworldwideorg/OneJA-Bot/issues/11756) ([539753a](539753a)) * **ModelSelect**: Resolve tooltip hover causing popup to close, closes [lobehub#11742](https://github.com/jaworldwideorg/OneJA-Bot/issues/11742) ([1b73f14](1b73f14)) * **pdf**: Ensure worker config before Document render, closes [lobehub#11746](https://github.com/jaworldwideorg/OneJA-Bot/issues/11746) ([ad34072](ad34072)) * **store**: Delete message before regeneration, closes [lobehub#11760](https://github.com/jaworldwideorg/OneJA-Bot/issues/11760) ([a8a6300](a8a6300)) * **misc**: Fix auto scroll, closes [lobehub#11734](https://github.com/jaworldwideorg/OneJA-Bot/issues/11734) ([892fa9f](892fa9f)) * **misc**: Fix favorite refresh bug and group topic refresh issue, closes [lobehub#11745](https://github.com/jaworldwideorg/OneJA-Bot/issues/11745) ([5d115ef](5d115ef)) * **misc**: Fixed the agent group builder tools excaution edge case crash, closes [lobehub#11735](https://github.com/jaworldwideorg/OneJA-Bot/issues/11735) ([5de4742](5de4742)) * **misc**: Page content switch mismatch, closes [lobehub#11758](https://github.com/jaworldwideorg/OneJA-Bot/issues/11758) ([fdc8f95](fdc8f95)) * **misc**: When use market group, the group sys role was not used, closes [lobehub#11739](https://github.com/jaworldwideorg/OneJA-Bot/issues/11739) ([afc76f9](afc76f9)) </details> <div align="right"> [![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top) </div>

dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jan 23, 2026

dosubot bot added the 🐛 Bug label Jan 23, 2026

sourcery-ai bot reviewed Jan 23, 2026

View reviewed changes

dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:XS This PR changes 0-9 lines, ignoring generated files. labels Jan 23, 2026

🐛 fix(copilot): sync chatStore activeAgentId when switching agent

248a4bd

When user switches agent in Copilot toolbar, also update useChatStore's activeAgentId to keep both stores in sync. This ensures topic selectors and other chatStore-dependent features work correctly.

Innei force-pushed the fix/copilot-history-refresh-by-agent-id branch from ed0d32b to 248a4bd Compare January 23, 2026 08:54

💄 style(copilot): show loading state for history button when switchin…

a7ac86e

…g agent - Show loading/disabled state while topics are being fetched - Only hide the button when confirmed there are no topics - Improves UX by avoiding sudden button disappearance during agent switch

Innei merged commit 64f39e7 into next Jan 23, 2026
35 of 36 checks passed

Innei deleted the fix/copilot-history-refresh-by-agent-id branch January 23, 2026 09:36

lobehubbot added the released on @next label Jan 23, 2026

vercel bot had a problem deploying to Preview January 23, 2026 17:05 Failure

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

🐛 fix(copilot): history popover not refreshing when agentId changes#11731

🐛 fix(copilot): history popover not refreshing when agentId changes#11731
Innei merged 2 commits intonextfrom
fix/copilot-history-refresh-by-agent-id

Innei commented Jan 23, 2026 •

edited

Loading

Uh oh!

vercel bot commented Jan 23, 2026 •

edited

Loading

Uh oh!

sourcery-ai bot commented Jan 23, 2026 •

edited

Loading

Reviewer's Guide

Sequence diagram for CopilotToolbar topics refresh on agentId change

Updated class diagram for CopilotToolbar topic selection

File-Level Changes

Interacting with Sourcery

Customizing Your Experience

Getting Help

Uh oh!

gru-agent bot commented Jan 23, 2026 •

edited

Loading

Uh oh!

sourcery-ai bot left a comment

Uh oh!

codecov bot commented Jan 23, 2026 •

edited

Loading

Uh oh!

Uh oh!

lobehubbot commented Jan 23, 2026

Uh oh!

lobehubbot commented Jan 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

Innei commented Jan 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💻 Change Type

🔗 Related Issue

🔀 Description of Change

🧪 How to Test

Uh oh!

vercel bot commented Jan 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sourcery-ai bot commented Jan 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer's Guide

Sequence diagram for CopilotToolbar topics refresh on agentId change

Updated class diagram for CopilotToolbar topic selection

File-Level Changes

Interacting with Sourcery

Customizing Your Experience

Getting Help

Uh oh!

gru-agent bot commented Jan 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

TestGru Assignment

Summary

Uh oh!

sourcery-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Jan 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

lobehubbot commented Jan 23, 2026

Uh oh!

lobehubbot commented Jan 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Innei commented Jan 23, 2026 •

edited

Loading

vercel bot commented Jan 23, 2026 •

edited

Loading

sourcery-ai bot commented Jan 23, 2026 •

edited

Loading

gru-agent bot commented Jan 23, 2026 •

edited

Loading

codecov bot commented Jan 23, 2026 •

edited

Loading