🐛 fix: when use market group, the group sys role was not used by ONLY-yours · Pull Request #11739 · lobehub/lobehub

ONLY-yours · 2026-01-23T10:14:52Z

💻 Change Type

fix: LOBE-3449

🔗 Related Issue

🔀 Description of Change

🧪 How to Test

Tested locally
Added/updated tests
No tests needed

📸 Screenshots / Videos

Before	After
...	...

📝 Additional Information

Summary by Sourcery

Bug Fixes:

Fix system role selection when forking a group and chat to ensure the group’s own systemRole is applied when available.

vercel · 2026-01-23T10:14:57Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Review	Updated (UTC)
lobehub	Building	Preview, Comment	Jan 23, 2026 10:14am

sourcery-ai · 2026-01-23T10:14:58Z

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Adjusts how the group system role content is selected when forking a group and starting a chat, ensuring the group’s own systemRole takes precedence over the supervisor’s configuration for market groups.

Sequence diagram for forking a group and starting a chat with updated systemRole precedence

sequenceDiagram
  actor User
  participant UI as ForkGroupAndChat_component
  participant GroupService
  participant ChatService

  User->>UI: Click ForkGroupAndChat button
  UI->>GroupService: getGroupConfig(identifier)
  GroupService-->>UI: config(systemRole, meta)
  UI->>GroupService: getSupervisorConfig(identifier)
  GroupService-->>UI: supervisorConfig(systemRole)

  UI->>UI: Determine content
  note over UI: content = config.systemRole || supervisorConfig.systemRole

  UI->>ChatService: createChat({ type: forked_group_chat, forkedFromIdentifier: identifier, content: content, meta: meta })
  ChatService-->>UI: chatCreated
  UI-->>User: Open new forked group chat

Flow diagram for systemRole selection when forking a group

flowchart TD
  A[Start: Fork group and chat] --> B[Load config for group]
  B --> C[Load supervisorConfig for group]
  C --> D{Does config.systemRole exist?}
  D -->|Yes| E[content = config.systemRole]
  D -->|No| F{Does supervisorConfig.systemRole exist?}
  F -->|Yes| G[content = supervisorConfig.systemRole]
  F -->|No| H[content = undefined]
  E --> I[Create forked group chat]
  G --> I
  H --> I
  I --> J[End]

File-Level Changes

Change	Details	Files
Change precedence order when determining the system role content used for a forked group and chat.	Update the content field to prefer the group config systemRole and only fall back to the supervisor configuration systemRole if the group one is missing Maintain existing metadata spread and forkedFromIdentifier behavior without modification	`src/app/[variants]/(main)/community/(detail)/group_agent/features/Sidebar/ActionButton/ForkGroupAndChat.tsx`

Tips and commands

Interacting with Sourcery

Trigger a new review: Comment @sourcery-ai review on the pull request.
Continue discussions: Reply directly to Sourcery's review comments.
Generate a GitHub issue from a review comment: Ask Sourcery to create an
issue from a review comment by replying to it. You can also reply to a
review comment with @sourcery-ai issue to create an issue from it.
Generate a pull request title: Write @sourcery-ai anywhere in the pull
request title to generate a title at any time. You can also comment
@sourcery-ai title on the pull request to (re-)generate the title at any time.
Generate a pull request summary: Write @sourcery-ai summary anywhere in
the pull request body to generate a PR summary at any time exactly where you
want it. You can also comment @sourcery-ai summary on the pull request to
(re-)generate the summary at any time.
Generate reviewer's guide: Comment @sourcery-ai guide on the pull
request to (re-)generate the reviewer's guide at any time.
Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
pull request to resolve all Sourcery comments. Useful if you've already
addressed all the comments and don't want to see them anymore.
Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
request to dismiss all existing Sourcery reviews. Especially useful if you
want to start fresh with a new review - don't forget to comment
@sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

Enable or disable review features such as the Sourcery-generated pull request
summary, the reviewer's guide, and others.
Change the review language.
Add, remove or edit custom review instructions.
Adjust other review settings.

Getting Help

Contact our support team for questions or feedback.
Visit our documentation for detailed guides and information.
Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

gru-agent · 2026-01-23T10:15:10Z

⏳ Processing in progress

sourcery-ai

Hey - I've left some high level feedback:

The inline comment still says the group content is the supervisor's systemRole for backward compatibility, but the precedence is now the group's config.systemRole; consider updating the comment to reflect the new behavior.
If an empty string is a valid systemRole, you may want to use the nullish coalescing operator (config.systemRole ?? supervisorConfig?.systemRole) instead of || to avoid unintentionally falling back when the role is an empty string.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- The inline comment still says the group content is the supervisor's systemRole for backward compatibility, but the precedence is now the group's config.systemRole; consider updating the comment to reflect the new behavior.
- If an empty string is a valid `systemRole`, you may want to use the nullish coalescing operator (`config.systemRole ?? supervisorConfig?.systemRole`) instead of `||` to avoid unintentionally falling back when the role is an empty string.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

lobehubbot · 2026-01-23T10:22:36Z

❤️ Great PR @ONLY-yours ❤️

The growth of project is inseparable from user feedback and contribution, thanks for your contribution! If you are interested in the lobehub developer community, please join our discord and then dm @arvinxx or @canisminor1990. They will invite you to our private developer channel. We are talking about the lobe-chat development or sharing ai newsletter around the world.

This comment was translated by Claude.

Original Content

❤️ Great PR @ONLY-yours ❤️

The growth of project is inseparable from user feedback and contribution, thanks for your contribution! If you are interesting with the lobehub developer community, please join our discord and then dm @arvinxx or @canisminor1990. They will invite you to our private developer channel. We are talking about the lobe-chat development or sharing ai newsletter around the world.

## [Version 2.0.0-next.349](v2.0.0-next.348...v2.0.0-next.349) <sup>Released on **2026-01-23**</sup> #### 🐛 Bug Fixes - **misc**: When use market group, the group sys role was not used. <br/> <details> <summary><kbd>Improvements and Fixes</kbd></summary> #### What's fixed * **misc**: When use market group, the group sys role was not used, closes [#11739](#11739) ([afc76f9](afc76f9)) </details> <div align="right"> [![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top) </div>

lobehubbot · 2026-01-23T10:41:29Z

🎉 This PR is included in version 2.0.0-next.349 🎉

The release is available on:

Your semantic-release bot 📦🚀

## [Version 1.154.0](v1.153.1...v1.154.0) <sup>Released on **2026-01-23**</sup> #### ♻ Code Refactoring - **misc**: Migrate AI Rules to Claude Code Skills. #### ✨ Features - **database**: Extended async task with metadata and parent id, added index. - **misc**: Remove NextAuth. #### 🐛 Bug Fixes - **copilot**: History popover not refreshing when agentId changes. - **editor**: Prevent crash when toggling enableInputMarkdown setting. - **home**: Use correct CreateGroupModal for session group creation. - **model-runtime**: Handle null content in anthropic message builder. - **ModelSelect**: Resolve tooltip hover causing popup to close. - **pdf**: Ensure worker config before Document render. - **store**: Delete message before regeneration. - **misc**: Fix auto scroll, fix favorite refresh bug and group topic refresh issue, fixed the agent group builder tools excaution edge case crash, page content switch mismatch, when use market group, the group sys role was not used. <br/> <details> <summary><kbd>Improvements and Fixes</kbd></summary> #### Code refactoring * **misc**: Migrate AI Rules to Claude Code Skills, closes [lobehub#11737](https://github.com/jaworldwideorg/OneJA-Bot/issues/11737) ([346fc46](346fc46)) #### What's improved * **database**: Extended async task with metadata and parent id, added index, closes [lobehub#11712](https://github.com/jaworldwideorg/OneJA-Bot/issues/11712) ([31d2f26](31d2f26)) * **misc**: Remove NextAuth, closes [lobehub#11732](https://github.com/jaworldwideorg/OneJA-Bot/issues/11732) ([1eff864](1eff864)) #### What's fixed * **copilot**: History popover not refreshing when agentId changes, closes [lobehub#11731](https://github.com/jaworldwideorg/OneJA-Bot/issues/11731) ([64f39e7](64f39e7)) * **editor**: Prevent crash when toggling enableInputMarkdown setting, closes [lobehub#11755](https://github.com/jaworldwideorg/OneJA-Bot/issues/11755) ([ea5eed8](ea5eed8)) * **home**: Use correct CreateGroupModal for session group creation, closes [lobehub#11752](https://github.com/jaworldwideorg/OneJA-Bot/issues/11752) ([36bcc50](36bcc50)) * **model-runtime**: Handle null content in anthropic message builder, closes [lobehub#11756](https://github.com/jaworldwideorg/OneJA-Bot/issues/11756) ([539753a](539753a)) * **ModelSelect**: Resolve tooltip hover causing popup to close, closes [lobehub#11742](https://github.com/jaworldwideorg/OneJA-Bot/issues/11742) ([1b73f14](1b73f14)) * **pdf**: Ensure worker config before Document render, closes [lobehub#11746](https://github.com/jaworldwideorg/OneJA-Bot/issues/11746) ([ad34072](ad34072)) * **store**: Delete message before regeneration, closes [lobehub#11760](https://github.com/jaworldwideorg/OneJA-Bot/issues/11760) ([a8a6300](a8a6300)) * **misc**: Fix auto scroll, closes [lobehub#11734](https://github.com/jaworldwideorg/OneJA-Bot/issues/11734) ([892fa9f](892fa9f)) * **misc**: Fix favorite refresh bug and group topic refresh issue, closes [lobehub#11745](https://github.com/jaworldwideorg/OneJA-Bot/issues/11745) ([5d115ef](5d115ef)) * **misc**: Fixed the agent group builder tools excaution edge case crash, closes [lobehub#11735](https://github.com/jaworldwideorg/OneJA-Bot/issues/11735) ([5de4742](5de4742)) * **misc**: Page content switch mismatch, closes [lobehub#11758](https://github.com/jaworldwideorg/OneJA-Bot/issues/11758) ([fdc8f95](fdc8f95)) * **misc**: When use market group, the group sys role was not used, closes [lobehub#11739](https://github.com/jaworldwideorg/OneJA-Bot/issues/11739) ([afc76f9](afc76f9)) </details> <div align="right"> [![](https://img.shields.io/badge/-BACK_TO_TOP-151515?style=flat-square)](#readme-top) </div>

fix: when use market group, the group sys role was not used

bcc9569

dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jan 23, 2026

ONLY-yours merged commit afc76f9 into next Jan 23, 2026
13 of 15 checks passed

ONLY-yours deleted the feat/forkAndUseGroup branch January 23, 2026 10:15

dosubot bot added the 🐛 Bug label Jan 23, 2026

sourcery-ai bot reviewed Jan 23, 2026

View reviewed changes

lobehubbot added the released on @next label Jan 23, 2026

vercel bot deployed to Preview January 23, 2026 19:48 View deployment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

🐛 fix: when use market group, the group sys role was not used#11739

🐛 fix: when use market group, the group sys role was not used#11739
ONLY-yours merged 1 commit intonextfrom
feat/forkAndUseGroup

ONLY-yours commented Jan 23, 2026 •

edited by sourcery-ai bot

Loading

Uh oh!

vercel bot commented Jan 23, 2026

Uh oh!

sourcery-ai bot commented Jan 23, 2026 •

edited

Loading

Reviewer's Guide

Sequence diagram for forking a group and starting a chat with updated systemRole precedence

Flow diagram for systemRole selection when forking a group

File-Level Changes

Interacting with Sourcery

Customizing Your Experience

Getting Help

Uh oh!

Uh oh!

gru-agent bot commented Jan 23, 2026

Uh oh!

sourcery-ai bot left a comment

Uh oh!

lobehubbot commented Jan 23, 2026 •

edited

Loading

Uh oh!

lobehubbot commented Jan 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

ONLY-yours commented Jan 23, 2026 • edited by sourcery-ai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💻 Change Type

🔗 Related Issue

🔀 Description of Change

🧪 How to Test

📸 Screenshots / Videos

📝 Additional Information

Summary by Sourcery

Uh oh!

vercel bot commented Jan 23, 2026

Uh oh!

sourcery-ai bot commented Jan 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer's Guide

Sequence diagram for forking a group and starting a chat with updated systemRole precedence

Flow diagram for systemRole selection when forking a group

File-Level Changes

Interacting with Sourcery

Customizing Your Experience

Getting Help

Uh oh!

Uh oh!

gru-agent bot commented Jan 23, 2026

Uh oh!

sourcery-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

lobehubbot commented Jan 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lobehubbot commented Jan 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ONLY-yours commented Jan 23, 2026 •

edited by sourcery-ai bot

Loading

sourcery-ai bot commented Jan 23, 2026 •

edited

Loading

lobehubbot commented Jan 23, 2026 •

edited

Loading