π fix: fix favorite refresh bug and group topic refresh issue#11745
Merged
π fix: fix favorite refresh bug and group topic refresh issue#11745
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
There is too much information in the pull request to test. |
There was a problem hiding this comment.
π‘ Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ecb0fd7f21
βΉοΈ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with π.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Comment on lines
144
to
147
| return [ | ||
| // ============================================= | ||
| // Phase 1: History Management | ||
| // ============================================= | ||
|
|
||
| // 1. History truncation (MUST be first, before any message injection) | ||
| new HistoryTruncateProcessor({ | ||
| enableHistoryCount, | ||
| historyCount, | ||
| }), | ||
|
|
||
| // ============================================= | ||
| // Phase 2: System Role Injection | ||
| // ============================================= |
There was a problem hiding this comment.
Restore history truncation in the MessagesEngine pipeline
The history-limit settings (enableHistoryCount/historyCount) are still passed into MessagesEngine from the runtime, but after this change the pipeline now begins with SystemRoleInjector and never applies HistoryTruncateProcessor. This means the user-configured history limit is silently ignored and full chat history is always sent, which can bloat token usage and cause context overflows when users rely on a bounded history (e.g., large threads with enableHistoryCount=true). Reintroducing the truncation step (or applying equivalent slicing before building the pipeline) would preserve the documented behavior.
Useful? React with πΒ / π.
Codecov Reportβ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## next #11745 +/- ##
=========================================
Coverage 74.15% 74.16%
=========================================
Files 1191 1191
Lines 94887 94919 +32
Branches 10475 12950 +2475
=========================================
+ Hits 70366 70393 +27
- Misses 24431 24436 +5
Partials 90 90
Flags with carried forward coverage won't be shown. Click here to find out more.
π New features to boost your workflow:
|
Update test assertions to use expect.anything() instead of undefined
for the second parameter of getChatCompletion, as it now receives
{ agentId, topicId } context object.
π€ Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Member
|
β€οΈ Great PR @arvinxx β€οΈ The growth of project is inseparable from user feedback and contribution, thanks for your contribution! If you are interesting with the lobehub developer community, please join our discord and then dm @arvinxx or @canisminor1990. They will invite you to our private developer channel. We are talking about the lobe-chat development or sharing ai newsletter around the world. |
lobehubbot
pushed a commit
that referenced
this pull request
Jan 23, 2026
## [Version 2.0.0-next.355](v2.0.0-next.354...v2.0.0-next.355) <sup>Released on **2026-01-23**</sup> #### π Bug Fixes - **home**: Use correct CreateGroupModal for session group creation. - **misc**: Fix favorite refresh bug and group topic refresh issue. <br/> <details> <summary><kbd>Improvements and Fixes</kbd></summary> #### What's fixed * **home**: Use correct CreateGroupModal for session group creation, closes [#11752](#11752) ([36bcc50](36bcc50)) * **misc**: Fix favorite refresh bug and group topic refresh issue, closes [#11745](#11745) ([5d115ef](5d115ef)) </details> <div align="right"> [](#readme-top) </div>
Member
|
π This PR is included in version 2.0.0-next.355 π The release is available on: Your semantic-release bot π¦π |
JamieStivala
pushed a commit
to jaworldwideorg/OneJA-Bot
that referenced
this pull request
Jan 23, 2026
## [Version 1.154.0](v1.153.1...v1.154.0) <sup>Released on **2026-01-23**</sup> #### β» Code Refactoring - **misc**: Migrate AI Rules to Claude Code Skills. #### β¨ Features - **database**: Extended async task with metadata and parent id, added index. - **misc**: Remove NextAuth. #### π Bug Fixes - **copilot**: History popover not refreshing when agentId changes. - **editor**: Prevent crash when toggling enableInputMarkdown setting. - **home**: Use correct CreateGroupModal for session group creation. - **model-runtime**: Handle null content in anthropic message builder. - **ModelSelect**: Resolve tooltip hover causing popup to close. - **pdf**: Ensure worker config before Document render. - **store**: Delete message before regeneration. - **misc**: Fix auto scroll, fix favorite refresh bug and group topic refresh issue, fixed the agent group builder tools excaution edge case crash, page content switch mismatch, when use market group, the group sys role was not used. <br/> <details> <summary><kbd>Improvements and Fixes</kbd></summary> #### Code refactoring * **misc**: Migrate AI Rules to Claude Code Skills, closes [lobehub#11737](https://github.com/jaworldwideorg/OneJA-Bot/issues/11737) ([346fc46](346fc46)) #### What's improved * **database**: Extended async task with metadata and parent id, added index, closes [lobehub#11712](https://github.com/jaworldwideorg/OneJA-Bot/issues/11712) ([31d2f26](31d2f26)) * **misc**: Remove NextAuth, closes [lobehub#11732](https://github.com/jaworldwideorg/OneJA-Bot/issues/11732) ([1eff864](1eff864)) #### What's fixed * **copilot**: History popover not refreshing when agentId changes, closes [lobehub#11731](https://github.com/jaworldwideorg/OneJA-Bot/issues/11731) ([64f39e7](64f39e7)) * **editor**: Prevent crash when toggling enableInputMarkdown setting, closes [lobehub#11755](https://github.com/jaworldwideorg/OneJA-Bot/issues/11755) ([ea5eed8](ea5eed8)) * **home**: Use correct CreateGroupModal for session group creation, closes [lobehub#11752](https://github.com/jaworldwideorg/OneJA-Bot/issues/11752) ([36bcc50](36bcc50)) * **model-runtime**: Handle null content in anthropic message builder, closes [lobehub#11756](https://github.com/jaworldwideorg/OneJA-Bot/issues/11756) ([539753a](539753a)) * **ModelSelect**: Resolve tooltip hover causing popup to close, closes [lobehub#11742](https://github.com/jaworldwideorg/OneJA-Bot/issues/11742) ([1b73f14](1b73f14)) * **pdf**: Ensure worker config before Document render, closes [lobehub#11746](https://github.com/jaworldwideorg/OneJA-Bot/issues/11746) ([ad34072](ad34072)) * **store**: Delete message before regeneration, closes [lobehub#11760](https://github.com/jaworldwideorg/OneJA-Bot/issues/11760) ([a8a6300](a8a6300)) * **misc**: Fix auto scroll, closes [lobehub#11734](https://github.com/jaworldwideorg/OneJA-Bot/issues/11734) ([892fa9f](892fa9f)) * **misc**: Fix favorite refresh bug and group topic refresh issue, closes [lobehub#11745](https://github.com/jaworldwideorg/OneJA-Bot/issues/11745) ([5d115ef](5d115ef)) * **misc**: Fixed the agent group builder tools excaution edge case crash, closes [lobehub#11735](https://github.com/jaworldwideorg/OneJA-Bot/issues/11735) ([5de4742](5de4742)) * **misc**: Page content switch mismatch, closes [lobehub#11758](https://github.com/jaworldwideorg/OneJA-Bot/issues/11758) ([fdc8f95](fdc8f95)) * **misc**: When use market group, the group sys role was not used, closes [lobehub#11739](https://github.com/jaworldwideorg/OneJA-Bot/issues/11739) ([afc76f9](afc76f9)) </details> <div align="right"> [](#readme-top) </div>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
π» Change Type
π Related Issue
close LOBE-4181
fix LOBE-4167
π Description of Change
π§ͺ How to Test
πΈ Screenshots / Videos
π Additional Information