[Merged by Bors] - feat: port algebra.group.semiconj#717
Closed
[Merged by Bors] - feat: port algebra.group.semiconj#717
Conversation
Member
|
I see that the |
Ruben-VandeVelde
approved these changes
Nov 25, 2022
Contributor
|
maintainer merge |
Contributor
|
You seem to not be authorized |
Contributor
|
Oh, I may have misunderstood how that worked. Anyway, this one seems ready to go |
Contributor
|
@Ruben-VandeVelde, sorry, the maintainer merge bot was misconfigured. Hopefully it will work now. |
kim-em
reviewed
Nov 25, 2022
Contributor
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Nov 26, 2022
mathlib SHA e50b8c261b0a000b806ec0e1356b41945eda61f7 This completes an earlier partial port of the file. ~~I added a workaround for the issue explained by Floris at #707 (comment) Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
|
Pull request successfully merged into master. Build succeeded:
|
bors bot
pushed a commit
to leanprover-community/mathlib3
that referenced
this pull request
Nov 27, 2022
Regenerated from the [port status wiki page](https://github.com/leanprover-community/mathlib/wiki/mathlib4-port-status). Relates to the following PRs: * `algebra.group.semiconj`: leanprover-community/mathlib4#717 * `algebra.group_with_zero.basic`: leanprover-community/mathlib4#669 * `algebra.group_with_zero.inj_surj`: leanprover-community/mathlib4#722 * `algebra.ring.inj_surj`: leanprover-community/mathlib4#734 * `algebra.ring.units`: leanprover-community/mathlib4#746 * `data.finite.defs`: leanprover-community/mathlib4#698 * `order.lattice`: leanprover-community/mathlib4#642
rosborn
added a commit
that referenced
this pull request
Nov 27, 2022
* master: feat: port Data.Countable.Defs (#736) chore: bump to nightly-2022-11-26 (#747) feat(Algebra/Ring/Units): port file (#746) style(Algebra/Order/Monoid/Lemmas): Update to current naming convention (#743) feat: stubs in ad-hoc ported files for linarith algebra requirements (#733) feat: port algebra.group.semiconj (#717) chore: make argument to mul_inv_cancel implicit (#737) feat(Algebra/Ring/InjSurj): port file (#734) chore: bump to nightly-2022-11-25 (#731) feat: port order.minmax (#728) chore: make the 'p' argument to Nat.find implicit (#730) feat: port Control.Basic (#588) feat: port data.finite.defs (#698) feat: port: Data.DList.Basic (#616) chore: reduce imports in Algebra.Group.Defs (#727) chore(Algebra/Order/Hom/Basic): remove outParam (#692)
bors bot
pushed a commit
to leanprover-community/mathlib3
that referenced
this pull request
Nov 27, 2022
Regenerated from the [port status wiki page](https://github.com/leanprover-community/mathlib/wiki/mathlib4-port-status). Relates to the following PRs: * `algebra.group.semiconj`: leanprover-community/mathlib4#717 * `algebra.group_with_zero.basic`: leanprover-community/mathlib4#669 * `algebra.group_with_zero.inj_surj`: leanprover-community/mathlib4#722 * `algebra.ring.inj_surj`: leanprover-community/mathlib4#734 * `algebra.ring.units`: leanprover-community/mathlib4#746 * `data.finite.defs`: leanprover-community/mathlib4#698 * `order.lattice`: leanprover-community/mathlib4#642
bors bot
pushed a commit
to leanprover-community/mathlib3
that referenced
this pull request
Nov 28, 2022
Regenerated from the [port status wiki page](https://github.com/leanprover-community/mathlib/wiki/mathlib4-port-status). Relates to the following PRs: * `algebra.group.semiconj`: leanprover-community/mathlib4#717 * `algebra.group_with_zero.basic`: leanprover-community/mathlib4#669 * `algebra.group_with_zero.inj_surj`: leanprover-community/mathlib4#722 * `algebra.ring.inj_surj`: leanprover-community/mathlib4#734 * `algebra.ring.units`: leanprover-community/mathlib4#746 * `data.finite.defs`: leanprover-community/mathlib4#698 * `order.lattice`: leanprover-community/mathlib4#642
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mathlib SHA e50b8c261b0a000b806ec0e1356b41945eda61f7
This completes an earlier partial port of the file.
I added a workaround for the issue explained by Floris at #707 (comment).