[Merged by Bors] - chore(Algebra/Order/Hom/Basic): remove outParam#692
Closed
riccardobrasca wants to merge 4 commits intomasterfrom
Closed
[Merged by Bors] - chore(Algebra/Order/Hom/Basic): remove outParam#692riccardobrasca wants to merge 4 commits intomasterfrom
riccardobrasca wants to merge 4 commits intomasterfrom
Conversation
Member
Author
|
I have no idea why I cannot remove more /-- `NonArchimedeanHomClass F α β` states that `F` is a type of non-archimedean morphisms. -/
class NonArchimedeanHomClass (F : Type _) (α β : outParam (Type _)) [outParam (Add α)]
[outParam (LinearOrder β)] extends FunLike F α fun _ => β where
/-- the image of a sum is less or equal than the maximum of the images. -/
map_add_le_max (f : F) : ∀ a b, f (a + b) ≤ max (f a) (f b)I get an error ("function expected at f term has type F") in @[to_additive]
theorem le_map_mul_map_div [Group α] [CommSemigroup β] [LE β] [SubMultiplicativeHomClass F α β]
(f : F) (a b : α) : f a ≤ f b * f (a / b) := by
simpa only [mul_comm, div_mul_cancel'] using map_mul_le_mul f (a / b) beven if this theorem seems unrelated to |
Contributor
|
@riccardobrasca, let's merge what can be merged for now. Can you post on zulip with the error? If you feel like trying to minimize it that would be helpful. Quite possibly this is a Lean 4 bug. |
Contributor
|
Okay, I have minimised this to: I'll pursue it on zulip. |
Contributor
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Nov 25, 2022
Remove unedeed `outParam`. Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
|
Pull request successfully merged into master. Build succeeded: |
rosborn
added a commit
that referenced
this pull request
Nov 27, 2022
* master: feat: port Data.Countable.Defs (#736) chore: bump to nightly-2022-11-26 (#747) feat(Algebra/Ring/Units): port file (#746) style(Algebra/Order/Monoid/Lemmas): Update to current naming convention (#743) feat: stubs in ad-hoc ported files for linarith algebra requirements (#733) feat: port algebra.group.semiconj (#717) chore: make argument to mul_inv_cancel implicit (#737) feat(Algebra/Ring/InjSurj): port file (#734) chore: bump to nightly-2022-11-25 (#731) feat: port order.minmax (#728) chore: make the 'p' argument to Nat.find implicit (#730) feat: port Control.Basic (#588) feat: port data.finite.defs (#698) feat: port: Data.DList.Basic (#616) chore: reduce imports in Algebra.Group.Defs (#727) chore(Algebra/Order/Hom/Basic): remove outParam (#692)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove unedeed
outParam.