Skip to content

[Merged by Bors] - feat: port Control.Basic#588

Closed
ADedecker wants to merge 30 commits intomasterfrom
AD_PORT_control_basic
Closed

[Merged by Bors] - feat: port Control.Basic#588
ADedecker wants to merge 30 commits intomasterfrom
AD_PORT_control_basic

Conversation

@ADedecker
Copy link
Copy Markdown
Member

@ADedecker ADedecker commented Nov 13, 2022

mathlib3 SHA: 08aeb33b5b693fb1392a7568ae2c0b253516535e

porting notes:

  1. The notation $< has been removed entirely. It is the same operation as |> in Lean 4 except with lower priority and a quick grep revealed it occurred literally nowhere in mathlib3.
  2. The dubious translation errors were due to order of implicit arguments and have been #alignₓed (except Sum.bind I'm not sure what the issue was, see Zulip)
  3. The fish definition is no longer needed because >=> has the correct (i.e., same as mathlib3's fish) binding precedence (55) in core Lean 4.
  4. It should be noted that >=> was left-associative in Lean 3, but it is now right-associative in Lean 4. There is a comment to this effect near fish_assoc.

@ADedecker ADedecker added WIP Work in progress awaiting-review labels Nov 13, 2022
@digama0 digama0 added the mathlib-port This is a port of a theory file from mathlib. label Nov 13, 2022
@kim-em
Copy link
Copy Markdown
Contributor

kim-em commented Nov 16, 2022

Can you please lint?

@kim-em kim-em added awaiting-author A reviewer has asked the author a question or requested changes. and removed awaiting-review labels Nov 16, 2022
@j-loreaux
Copy link
Copy Markdown
Contributor

I've added docstrings to the defs, but they should be checked for accuracy and readability.

@j-loreaux j-loreaux removed the WIP Work in progress label Nov 17, 2022
@j-loreaux j-loreaux added awaiting-review and removed awaiting-author A reviewer has asked the author a question or requested changes. labels Nov 23, 2022
@kim-em kim-em added awaiting-author A reviewer has asked the author a question or requested changes. and removed awaiting-review labels Nov 23, 2022
@j-loreaux j-loreaux added awaiting-review and removed awaiting-author A reviewer has asked the author a question or requested changes. labels Nov 24, 2022
@kim-em
Copy link
Copy Markdown
Contributor

kim-em commented Nov 25, 2022

bors merge

@github-actions github-actions bot added ready-to-merge This PR has been sent to bors. and removed awaiting-review labels Nov 25, 2022
bors bot pushed a commit that referenced this pull request Nov 25, 2022
mathlib3 SHA: 08aeb33b5b693fb1392a7568ae2c0b253516535e

porting notes:
1. The notation `$<` has been removed entirely. It is the same operation as `|>` in Lean 4 except with lower priority and a quick grep revealed it occurred literally nowhere in mathlib3.
2. The dubious translation errors were due to order of implicit arguments and have been `#alignₓ`ed (except `Sum.bind` I'm not sure what the issue was, see [Zulip](https://leanprover.zulipchat.com/#narrow/stream/287929-mathlib4/topic/why.20dubious.3F))
3. The `fish` definition is no longer needed because `>=>` has the correct (i.e., same as mathlib3's `fish`) binding precedence (`55`) in core Lean 4.
4. It should be noted that `>=>` was left-associative in Lean 3, but it is now right-associative in Lean 4. There is a comment to this effect near `fish_assoc`.

Co-authored-by: Jireh Loreaux <loreaujy@gmail.com>
Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
@bors
Copy link
Copy Markdown

bors bot commented Nov 25, 2022

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat: port Control.Basic [Merged by Bors] - feat: port Control.Basic Nov 25, 2022
@bors bors bot closed this Nov 25, 2022
@bors bors bot deleted the AD_PORT_control_basic branch November 25, 2022 20:31
rosborn added a commit that referenced this pull request Nov 27, 2022
* master:
  feat: port Data.Countable.Defs (#736)
  chore: bump to nightly-2022-11-26 (#747)
  feat(Algebra/Ring/Units): port file (#746)
  style(Algebra/Order/Monoid/Lemmas): Update to current naming convention (#743)
  feat: stubs in ad-hoc ported files for linarith algebra requirements (#733)
  feat: port algebra.group.semiconj (#717)
  chore: make argument to mul_inv_cancel implicit (#737)
  feat(Algebra/Ring/InjSurj): port file (#734)
  chore: bump to nightly-2022-11-25 (#731)
  feat: port order.minmax (#728)
  chore: make the 'p' argument to Nat.find implicit (#730)
  feat: port Control.Basic (#588)
  feat: port data.finite.defs (#698)
  feat: port:  Data.DList.Basic (#616)
  chore: reduce imports in Algebra.Group.Defs (#727)
  chore(Algebra/Order/Hom/Basic): remove outParam (#692)
bors bot pushed a commit that referenced this pull request Nov 28, 2022
mathlib3 SHA: 71ca477041bcd6d7c745fe555dc49735c12944b7

- [x] depends on: #588

Notes: 
1. There is a discrepancy between the Lean 3 and Lean 4 types of `has_seq.seq` and `Seq.seq`. I added an `ₓ` for alignment.
2. There were one or two places where the existing `simp` or `rw` calls didn't succeed, but I'm not entirely sure why.
3. In `Functor.Comp.functor_comp_id` and `Functor.Comp.functor_id_comp` I had to use `Id` instead of `id`, because only the former has the `Monad` instance.
4. I had to change the imports, but I think what is there now is minimal.

Co-authored-by: ADedecker <anatolededecker@gmail.com>
bors bot pushed a commit that referenced this pull request Nov 28, 2022
mathlib3 SHA: 71ca477041bcd6d7c745fe555dc49735c12944b7

- [x] depends on: #588

Notes: 
1. There is a discrepancy between the Lean 3 and Lean 4 types of `has_seq.seq` and `Seq.seq`. I added an `ₓ` for alignment.
2. There were one or two places where the existing `simp` or `rw` calls didn't succeed, but I'm not entirely sure why.
3. In `Functor.Comp.functor_comp_id` and `Functor.Comp.functor_id_comp` I had to use `Id` instead of `id`, because only the former has the `Monad` instance.
4. I had to change the imports, but I think what is there now is minimal.

Co-authored-by: ADedecker <anatolededecker@gmail.com>
bors bot pushed a commit that referenced this pull request Nov 28, 2022
mathlib3 SHA: 71ca477041bcd6d7c745fe555dc49735c12944b7

- [x] depends on: #588

Notes: 
1. There is a discrepancy between the Lean 3 and Lean 4 types of `has_seq.seq` and `Seq.seq`. I added an `ₓ` for alignment.
2. There were one or two places where the existing `simp` or `rw` calls didn't succeed, but I'm not entirely sure why.
3. In `Functor.Comp.functor_comp_id` and `Functor.Comp.functor_id_comp` I had to use `Id` instead of `id`, because only the former has the `Monad` instance.
4. I had to change the imports, but I think what is there now is minimal.

Co-authored-by: ADedecker <anatolededecker@gmail.com>
bors bot pushed a commit that referenced this pull request Nov 28, 2022
mathlib3 SHA: 71ca477041bcd6d7c745fe555dc49735c12944b7

- [x] depends on: #588

Notes: 
1. There is a discrepancy between the Lean 3 and Lean 4 types of `has_seq.seq` and `Seq.seq`. I added an `ₓ` for alignment.
2. There were one or two places where the existing `simp` or `rw` calls didn't succeed, but I'm not entirely sure why.
3. In `Functor.Comp.functor_comp_id` and `Functor.Comp.functor_id_comp` I had to use `Id` instead of `id`, because only the former has the `Monad` instance.
4. I had to change the imports, but I think what is there now is minimal.

Co-authored-by: ADedecker <anatolededecker@gmail.com>
bors bot pushed a commit that referenced this pull request Nov 28, 2022
mathlib3 SHA: 71ca477041bcd6d7c745fe555dc49735c12944b7

- [x] depends on: #588

Notes: 
1. There is a discrepancy between the Lean 3 and Lean 4 types of `has_seq.seq` and `Seq.seq`. I added an `ₓ` for alignment.
2. There were one or two places where the existing `simp` or `rw` calls didn't succeed, but I'm not entirely sure why.
3. In `Functor.Comp.functor_comp_id` and `Functor.Comp.functor_id_comp` I had to use `Id` instead of `id`, because only the former has the `Monad` instance.
4. I had to change the imports, but I think what is there now is minimal.

Co-authored-by: ADedecker <anatolededecker@gmail.com>
bors bot pushed a commit that referenced this pull request Nov 28, 2022
mathlib3 SHA: 71ca477041bcd6d7c745fe555dc49735c12944b7

- [x] depends on: #588

Notes: 
1. There is a discrepancy between the Lean 3 and Lean 4 types of `has_seq.seq` and `Seq.seq`. I added an `ₓ` for alignment.
2. There were one or two places where the existing `simp` or `rw` calls didn't succeed, but I'm not entirely sure why.
3. In `Functor.Comp.functor_comp_id` and `Functor.Comp.functor_id_comp` I had to use `Id` instead of `id`, because only the former has the `Monad` instance.
4. I had to change the imports, but I think what is there now is minimal.

Co-authored-by: ADedecker <anatolededecker@gmail.com>
@j-loreaux j-loreaux mentioned this pull request Nov 28, 2022
1 task
bors bot pushed a commit that referenced this pull request Nov 28, 2022
mathlib3 SHA: 71ca477041bcd6d7c745fe555dc49735c12944b7

- [x] depends on: #588

Notes: 
1. There is a discrepancy between the Lean 3 and Lean 4 types of `has_seq.seq` and `Seq.seq`. I added an `ₓ` for alignment.
2. There were one or two places where the existing `simp` or `rw` calls didn't succeed, but I'm not entirely sure why.
3. In `Functor.Comp.functor_comp_id` and `Functor.Comp.functor_id_comp` I had to use `Id` instead of `id`, because only the former has the `Monad` instance.
4. I had to change the imports, but I think what is there now is minimal.

Co-authored-by: ADedecker <anatolededecker@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mathlib-port This is a port of a theory file from mathlib. ready-to-merge This PR has been sent to bors.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants