[Merged by Bors] - chore: make the 'p' argument to Nat.find implicit#730
Closed
Ruben-VandeVelde wants to merge 1 commit intomasterfrom
Closed
[Merged by Bors] - chore: make the 'p' argument to Nat.find implicit#730Ruben-VandeVelde wants to merge 1 commit intomasterfrom
Ruben-VandeVelde wants to merge 1 commit intomasterfrom
Conversation
This matches mathlib3.
2 tasks
Contributor
|
bors merge |
|
Pull request successfully merged into master. Build succeeded: |
Member
|
This was a deliberate change. Proof arguments in definitions should not make other arguments implicit. (It should be backported if the difference is causing problems.) |
rosborn
added a commit
that referenced
this pull request
Nov 27, 2022
* master: feat: port Data.Countable.Defs (#736) chore: bump to nightly-2022-11-26 (#747) feat(Algebra/Ring/Units): port file (#746) style(Algebra/Order/Monoid/Lemmas): Update to current naming convention (#743) feat: stubs in ad-hoc ported files for linarith algebra requirements (#733) feat: port algebra.group.semiconj (#717) chore: make argument to mul_inv_cancel implicit (#737) feat(Algebra/Ring/InjSurj): port file (#734) chore: bump to nightly-2022-11-25 (#731) feat: port order.minmax (#728) chore: make the 'p' argument to Nat.find implicit (#730) feat: port Control.Basic (#588) feat: port data.finite.defs (#698) feat: port: Data.DList.Basic (#616) chore: reduce imports in Algebra.Group.Defs (#727) chore(Algebra/Order/Hom/Basic): remove outParam (#692)
bors bot
pushed a commit
that referenced
this pull request
Nov 30, 2022
This is based on a *future* version of mathlib3, once leanprover-community/mathlib3#17763 and leanprover-community/mathlib3#17759 have landed. - [x] depends on #727 - [x] depends on #730 Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This matches lean3.