This repository was archived by the owner on Jul 24, 2024. It is now read-only.
[Merged by Bors] - chore(data/nat/basic): split out even_odd_rec#17759
Closed
[Merged by Bors] - chore(data/nat/basic): split out even_odd_rec#17759
Conversation
eric-wieser
reviewed
Nov 29, 2022
|
✌️ semorrison can now approve this pull request. To approve and merge a pull request, simply reply with |
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Collaborator
Author
|
bors p=10 bors merge |
bors bot
pushed a commit
that referenced
this pull request
Nov 29, 2022
`even_odd_rec` is annoying to port, because it is thoroughly tangled with `bit0` and `bit1`. It isn't used in mathlib, so I'm dumping it into its own file so we can get on with porting the critical `data.nat.basic` without delaying for this. Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
2 tasks
|
Pull request successfully merged into master. Build succeeded: |
bors bot
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Nov 30, 2022
This is based on a *future* version of mathlib3, once leanprover-community/mathlib3#17763 and leanprover-community/mathlib3#17759 have landed. - [x] depends on #727 - [x] depends on #730 Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
even_odd_recis annoying to port, because it is thoroughly tangled withbit0andbit1. It isn't used in mathlib, so I'm dumping it into its own file so we can get on with porting the criticaldata.nat.basicwithout delaying for this.