[Merged by Bors] - feat(Algebra/GroupWithZero/InjSurj): port file#722
Closed
[Merged by Bors] - feat(Algebra/GroupWithZero/InjSurj): port file#722
Conversation
Member
|
LGTM but I don't consider myself to be a mathlib4 expert. Let me see if this works in this repo: |
Contributor
|
You seem to not be authorized |
Member
|
But you came here, so you can review the PR... |
Contributor
|
Haha, that wasn't actually me, @urkud. When I set up the maintainer merge bot I guess I used my personal credentials. I will go fix that. :-) |
Contributor
|
bors merge |
|
Merge conflict. |
Contributor
|
bors merge |
|
👎 Rejected by label |
Contributor
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Nov 25, 2022
mathlib3 SHA: 6b3325cdf0b4b23496391a451324c95a1dc36d9e porting notes: * overall, very straightforward * I made `GroupWithZero` extend `Nontrivial` to match mathlib3, and we didn't have this instance previously because it didn't extend that class. Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
|
Pull request successfully merged into master. Build succeeded: |
bors bot
pushed a commit
to leanprover-community/mathlib3
that referenced
this pull request
Nov 27, 2022
Regenerated from the [port status wiki page](https://github.com/leanprover-community/mathlib/wiki/mathlib4-port-status). Relates to the following PRs: * `algebra.group.semiconj`: leanprover-community/mathlib4#717 * `algebra.group_with_zero.basic`: leanprover-community/mathlib4#669 * `algebra.group_with_zero.inj_surj`: leanprover-community/mathlib4#722 * `algebra.ring.inj_surj`: leanprover-community/mathlib4#734 * `algebra.ring.units`: leanprover-community/mathlib4#746 * `data.finite.defs`: leanprover-community/mathlib4#698 * `order.lattice`: leanprover-community/mathlib4#642
bors bot
pushed a commit
to leanprover-community/mathlib3
that referenced
this pull request
Nov 27, 2022
Regenerated from the [port status wiki page](https://github.com/leanprover-community/mathlib/wiki/mathlib4-port-status). Relates to the following PRs: * `algebra.group.semiconj`: leanprover-community/mathlib4#717 * `algebra.group_with_zero.basic`: leanprover-community/mathlib4#669 * `algebra.group_with_zero.inj_surj`: leanprover-community/mathlib4#722 * `algebra.ring.inj_surj`: leanprover-community/mathlib4#734 * `algebra.ring.units`: leanprover-community/mathlib4#746 * `data.finite.defs`: leanprover-community/mathlib4#698 * `order.lattice`: leanprover-community/mathlib4#642
bors bot
pushed a commit
to leanprover-community/mathlib3
that referenced
this pull request
Nov 28, 2022
Regenerated from the [port status wiki page](https://github.com/leanprover-community/mathlib/wiki/mathlib4-port-status). Relates to the following PRs: * `algebra.group.semiconj`: leanprover-community/mathlib4#717 * `algebra.group_with_zero.basic`: leanprover-community/mathlib4#669 * `algebra.group_with_zero.inj_surj`: leanprover-community/mathlib4#722 * `algebra.ring.inj_surj`: leanprover-community/mathlib4#734 * `algebra.ring.units`: leanprover-community/mathlib4#746 * `data.finite.defs`: leanprover-community/mathlib4#698 * `order.lattice`: leanprover-community/mathlib4#642
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mathlib3 SHA: 6b3325cdf0b4b23496391a451324c95a1dc36d9e
porting notes:
GroupWithZeroextendNontrivialto match mathlib3, and we didn't have this instance previously because it didn't extend that class.