[Merged by Bors] - feat: port Algebra.GroupWithZero.Basic#669
Closed
Ruben-VandeVelde wants to merge 8 commits intomasterfrom
Closed
[Merged by Bors] - feat: port Algebra.GroupWithZero.Basic#669Ruben-VandeVelde wants to merge 8 commits intomasterfrom
Ruben-VandeVelde wants to merge 8 commits intomasterfrom
Conversation
Contributor
Author
|
I somehow made the |
Member
|
Can you please please claim your ports over at https://github.com/leanprover-community/mathlib/wiki/mathlib4-port-status |
Contributor
I've added it |
Contributor
|
The Lean 4 fix should arrive in |
kim-em
reviewed
Nov 25, 2022
Contributor
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Nov 25, 2022
Tracking mathlib commit: [39af7d3bf61a98e928812dbc3e16f4ea8b795ca3](leanprover-community/mathlib3@39af7d3) Co-authored-by: Yakov Pechersky <ffxen158@gmail.com> Co-authored-by: Scott Morrison <scott@tqft.net>
|
Pull request successfully merged into master. Build succeeded: |
bors bot
pushed a commit
to leanprover-community/mathlib3
that referenced
this pull request
Nov 27, 2022
Regenerated from the [port status wiki page](https://github.com/leanprover-community/mathlib/wiki/mathlib4-port-status). Relates to the following PRs: * `algebra.group.semiconj`: leanprover-community/mathlib4#717 * `algebra.group_with_zero.basic`: leanprover-community/mathlib4#669 * `algebra.group_with_zero.inj_surj`: leanprover-community/mathlib4#722 * `algebra.ring.inj_surj`: leanprover-community/mathlib4#734 * `algebra.ring.units`: leanprover-community/mathlib4#746 * `data.finite.defs`: leanprover-community/mathlib4#698 * `order.lattice`: leanprover-community/mathlib4#642
bors bot
pushed a commit
to leanprover-community/mathlib3
that referenced
this pull request
Nov 27, 2022
Regenerated from the [port status wiki page](https://github.com/leanprover-community/mathlib/wiki/mathlib4-port-status). Relates to the following PRs: * `algebra.group.semiconj`: leanprover-community/mathlib4#717 * `algebra.group_with_zero.basic`: leanprover-community/mathlib4#669 * `algebra.group_with_zero.inj_surj`: leanprover-community/mathlib4#722 * `algebra.ring.inj_surj`: leanprover-community/mathlib4#734 * `algebra.ring.units`: leanprover-community/mathlib4#746 * `data.finite.defs`: leanprover-community/mathlib4#698 * `order.lattice`: leanprover-community/mathlib4#642
bors bot
pushed a commit
to leanprover-community/mathlib3
that referenced
this pull request
Nov 28, 2022
Regenerated from the [port status wiki page](https://github.com/leanprover-community/mathlib/wiki/mathlib4-port-status). Relates to the following PRs: * `algebra.group.semiconj`: leanprover-community/mathlib4#717 * `algebra.group_with_zero.basic`: leanprover-community/mathlib4#669 * `algebra.group_with_zero.inj_surj`: leanprover-community/mathlib4#722 * `algebra.ring.inj_surj`: leanprover-community/mathlib4#734 * `algebra.ring.units`: leanprover-community/mathlib4#746 * `data.finite.defs`: leanprover-community/mathlib4#698 * `order.lattice`: leanprover-community/mathlib4#642
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracking mathlib commit: 39af7d3bf61a98e928812dbc3e16f4ea8b795ca3