[Merged by Bors] - refactor: introduce Ideal.IsTwoSided class for quotients of noncommutative rings#17930
Closed
alreadydone wants to merge 94 commits intomasterfrom
Closed
[Merged by Bors] - refactor: introduce Ideal.IsTwoSided class for quotients of noncommutative rings#17930alreadydone wants to merge 94 commits intomasterfrom
Ideal.IsTwoSided class for quotients of noncommutative rings#17930alreadydone wants to merge 94 commits intomasterfrom
Conversation
…to noncommutative setting
PR summary 103d3f45eeImport changes for modified filesNo significant changes to the import graph Import changes for all files
|
| Current number | Change | Type |
|---|---|---|
| 119 | -2 | adaptation notes |
| 109 | -4 | disabled simpNF lints |
Current commit 103d3f45ee
Reference commit 229276c711
You can run this locally as
./scripts/technical-debt-metrics.sh pr_summary
- The
relativevalue is the weighted sum of the differences with weight given by the inverse of the current value of the statistic. - The
absolutevalue is therelativevalue divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
3 tasks
Ideal.IsTwoSided class for generalization to noncommutative settingIdeal.IsTwoSided class for quotients of noncommutative rings
2 files, Instructions +10.0⬝10⁹
2 files, Instructions +8.0⬝10⁹
3 files, Instructions +7.0⬝10⁹
3 files, Instructions +4.0⬝10⁹
4 files, Instructions +3.0⬝10⁹
6 files, Instructions +2.0⬝10⁹
18 files, Instructions +1.0⬝10⁹
2 files, Instructions -2.0⬝10⁹
|
Contributor
Author
|
Gained merge conflicts again from #20518. Should I fix them now? |
Contributor
Author
|
!bench |
Collaborator
|
Here are the benchmark results for commit 8789864. Benchmark Metric Change
=====================================================================
- ~Mathlib.FieldTheory.LinearDisjoint instructions 10.3%
- ~Mathlib.LinearAlgebra.Semisimple instructions 25.3%
- ~Mathlib.RingTheory.AdjoinRoot instructions 16.0%
- ~Mathlib.RingTheory.Ideal.Quotient.Operations instructions 26.9%
- ~Mathlib.RingTheory.Jacobson.Ring instructions 17.5%
- ~Mathlib.RingTheory.Polynomial.Quotient instructions 20.7% |
2 files, Instructions +8.0⬝10⁹
2 files, Instructions +6.0⬝10⁹
4 files, Instructions +4.0⬝10⁹
5 files, Instructions +3.0⬝10⁹
6 files, Instructions +2.0⬝10⁹
19 files, Instructions +1.0⬝10⁹
|
Contributor
Author
|
!bench |
Collaborator
|
Here are the benchmark results for commit 6615fa2. Benchmark Metric Change
=====================================================================
- ~Mathlib.FieldTheory.LinearDisjoint instructions 9.9%
- ~Mathlib.LinearAlgebra.Semisimple instructions 24.4%
- ~Mathlib.RingTheory.AdjoinRoot instructions 13.8%
- ~Mathlib.RingTheory.Ideal.Quotient.Operations instructions 25.7% |
2 files, Instructions +17.0⬝10⁹
2 files, Instructions +9.0⬝10⁹
3 files, Instructions +4.0⬝10⁹
7 files, Instructions +3.0⬝10⁹
4 files, Instructions +2.0⬝10⁹
16 files, Instructions +1.0⬝10⁹
5 files, Instructions -2.0⬝10⁹
|
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
Contributor
Author
|
!bench |
Collaborator
|
Here are the benchmark results for commit 103d3f4. Benchmark Metric Change
=====================================================================
- ~Mathlib.FieldTheory.LinearDisjoint instructions 9.8%
- ~Mathlib.LinearAlgebra.Semisimple instructions 11.1%
- ~Mathlib.RingTheory.AdjoinRoot instructions 11.7%
- ~Mathlib.RingTheory.Ideal.Quotient.Operations instructions 24.9% |
4 files, Instructions +4.0⬝10⁹
5 files, Instructions +3.0⬝10⁹
4 files, Instructions +2.0⬝10⁹
17 files, Instructions +1.0⬝10⁹
6 files, Instructions -2.0⬝10⁹
|
Member
|
Thanks 🎉 bors merge |
Contributor
|
Pull request successfully merged into master. Build succeeded: |
Ideal.IsTwoSided class for quotients of noncommutative ringsIdeal.IsTwoSided class for quotients of noncommutative rings
Julian
added a commit
that referenced
this pull request
Feb 5, 2025
* origin/master: (103 commits) chore(PresheafedSpace): remove `mk_coe` and some comments from porting (#21382) refactor(CategoryTheory): `ConcreteCategory` instance for `FintypeCat` (#21466) refactor(Algebra/Category): clean up remaining uses of `HasForget` (#21460) chore(Algebra/Field/Basic): make some arguments implicit (#21453) chore(LinearAlgebra/TensorProduct): upgrade `TensorProduct.prodRight` (#21432) docs(Logic/Function/Defs): missing backticks (#21459) style(Logic/Embedding/Set): unindent (#21457) doc: document design choice of (AE)StronglyMeasurable.enorm and `edist` (#21423) perf(RingTheory/Artinian): reorder arguments in `IsArtinianRing.isMaximal_of_isPrime` (#21449) feat(Probability): first two derivatives of `cgf` (#21223) feat(RingTheory): `Ring.KrullDimLE` type class (#21452) chore(Probability/ProbabilityMassFunction/Binomial): typo "bernoulli" (#21455) chore: remove unused argument (#21393) feat(MeasureTheory/Integral/RieszMarkovKakutani) prove that the Riesz content is regular and define the Riesz measure (#20040) chore(Topology/Algebra/ContinuousMonoidHom): do not depend on `ContinuousLinearMap` (#21443) doc(CategoryTheory/Monoidal/Category): fix expression in docs (#21445) refactor(Order/CompleteBooleanAlgebra): a complete lattice which is a Heyting algebra is automatically a frame (#21391) chore: cleanup porting notes in TuringMachine (#20821) chore: remove @[simp] when the discr_key is a lambda (#21395) feat/doc: split files, add documentation (#21421) feat(Data/Set/Lattice): iUnion + insertion (#21322) feat(Factorial): k! divides the product of any k successive integers (#21332) feat(CI): bench-after-CI (#21414) feat: primitive group actions (#12052) feat(Algebra/GroupWithZero/Int): add lemmas about Zm0 (#21370) feat(CategoryTheory): small classes of morphisms (#21411) feat(CategoryTheory): (co)limits of constant functors (#21412) chore: rename isUnit_ofPowEqOne (#21407) chore: split mapDomain out of MonoidAlgebra.Defs (#21398) chore: generalise lemmas to `ENorm` spaces, part 1 (#21380) chore: add `simp` to `Setoid.refl` (#21107) chore: tidy various files (#21406) chore(Geometry/Manifold/IsManifold): split out material on extended charts (#21219) refactor: introduce `Ideal.IsTwoSided` class for quotients of noncommutative rings (#17930) chore(Algebra/Category/ModuleCat): delete `ModuleCat.hasForgetModuleCat` (#21425) feat(RingTheory): unramified iff `κ(q)/κ(p)` is separable and `pS_q = qS_q` (#20690) doc(Order/Heyting/Basic): Coheyting difference is not right adjoint but left adjoint (#21418) chore: move ProofWidgets to v0.0.51 (#21416) chore: rename mem_nonZeroDivisor_of_injective and comap_nonZeroDivisor_le_of_injective (#21408) feat: drop ordering assumption in `RootPairing.coxeterWeight_mem_set_of_isCrystallographic` (#21122) feat(AlgebraicGeometry): the diagonal of an unramified morphism is an open immersion (#21386) feat(Data/LinearIndependent): iff versions of smul action on independent sets (#21383) chore(Combinatorics/SimpleGraph): Fix `hadj` naming (#21389) chore: rename AnalyticAt.order_neq_top_iff (#21388) fix: bug in daily.yml (#21401) chore: remove `@[simp]` from `CategoryTheory.Discrete.functor_map` (#21392) chore(Algebra/PUnitInstances): generalise universes (#21381) feat(RingTheory/PowerSeries): describe when power series map is zero (#21379) feat(Tactic/Linter): options to in/exclude definitions and private decls (#21374) feat: the prime spectrum is quasi-separated (#21362) ...
pfaffelh
pushed a commit
that referenced
this pull request
Feb 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.