Skip to content

[Merged by Bors] - feat: primitive group actions#12052

Closed
AntoineChambert-Loir wants to merge 182 commits intomasterfrom
ACL/IwPrimitive
Closed

[Merged by Bors] - feat: primitive group actions#12052
AntoineChambert-Loir wants to merge 182 commits intomasterfrom
ACL/IwPrimitive

Conversation

AntoineChambert-Loir and others added 30 commits April 6, 2024 01:04
Second branch towards the iwasawa criterion
We import blocks.
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@YaelDillies YaelDillies added the awaiting-author A reviewer has asked the author a question or requested changes. label Jan 31, 2025
AntoineChambert-Loir and others added 2 commits January 31, 2025 22:13
Co-authored-by: Yaël Dillies <yael.dillies@gmail.com>
@AntoineChambert-Loir AntoineChambert-Loir removed the awaiting-author A reviewer has asked the author a question or requested changes. label Jan 31, 2025
@YaelDillies YaelDillies added the awaiting-author A reviewer has asked the author a question or requested changes. label Jan 31, 2025
@AntoineChambert-Loir
Copy link
Copy Markdown
Collaborator Author

I wonder whether the hypothesis IsPreprimitive G X couldn't/shouldn't most of the time be passed as a typeclass hyp.

Copy link
Copy Markdown
Contributor

@YaelDillies YaelDillies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's a good point. You even already made it a class. Do you want to switch over?

@riccardobrasca
Copy link
Copy Markdown
Member

Does this include all the changes from #12048?

@AntoineChambert-Loir
Copy link
Copy Markdown
Collaborator Author

it should. i can't check until tonight

@riccardobrasca
Copy link
Copy Markdown
Member

it should. i can't check until tonight

OK, this LGTM. If all the comments in the other PR have been taken into account let's merge it.

bors d+

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Feb 4, 2025

✌️ AntoineChambert-Loir can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

Copy link
Copy Markdown
Contributor

@YaelDillies YaelDillies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final comments. Thank you for bearing with me!

@AntoineChambert-Loir
Copy link
Copy Markdown
Collaborator Author

bors r+

@AntoineChambert-Loir
Copy link
Copy Markdown
Collaborator Author

Thank you for your diligence. It's often more work but in the end, it's worth the effort.

@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors bot commented Feb 4, 2025

Pull request successfully merged into master.

Build succeeded:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

delegated This pull request has been delegated to the PR author (or occasionally another non-maintainer). t-algebra Algebra (groups, rings, fields, etc)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants