[Merged by Bors] - perf(RingTheory/Artinian): reorder arguments in IsArtinianRing.isMaximal_of_isPrime#21449
Closed
[Merged by Bors] - perf(RingTheory/Artinian): reorder arguments in IsArtinianRing.isMaximal_of_isPrime#21449
IsArtinianRing.isMaximal_of_isPrime#21449Conversation
PR summary 9d01b1b922Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for No changes to technical debt.You can run this locally as
|
Contributor
Author
|
!bench |
Collaborator
|
Here are the benchmark results for commit 9d01b1b. |
|
Contributor
Author
|
Apparently no other improvement that in the one simpNF lint |
1 task
grunweg
reviewed
Feb 5, 2025
Contributor
grunweg
left a comment
There was a problem hiding this comment.
Thanks a lot for finding this fix! I wonder if there is a deeper problem to be diagnosed (which would receive a more systematic fix); I would be interested in maintainers' opinions and have asked on zulip.
In the meantime, this PR is unblocking work on the Carleson project (#21422 and its to-be-PRed dependents), so I propose merging it now (and possibly reverting it in favour of a deeper fix).
maintainer merge?
|
🚀 Pull request has been placed on the maintainer queue by grunweg. |
Member
|
bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Feb 5, 2025
…imal_of_isPrime` (#21449) Reordering the arguments flips the type class synthesis order, so that it fails more quickly when there is no instance. https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/Strange.20simpNF.20error.20.22at.20a.20distance.22/near/497687170
Contributor
|
Pull request successfully merged into master. Build succeeded: |
IsArtinianRing.isMaximal_of_isPrimeIsArtinianRing.isMaximal_of_isPrime
Julian
added a commit
that referenced
this pull request
Feb 5, 2025
* origin/master: (103 commits) chore(PresheafedSpace): remove `mk_coe` and some comments from porting (#21382) refactor(CategoryTheory): `ConcreteCategory` instance for `FintypeCat` (#21466) refactor(Algebra/Category): clean up remaining uses of `HasForget` (#21460) chore(Algebra/Field/Basic): make some arguments implicit (#21453) chore(LinearAlgebra/TensorProduct): upgrade `TensorProduct.prodRight` (#21432) docs(Logic/Function/Defs): missing backticks (#21459) style(Logic/Embedding/Set): unindent (#21457) doc: document design choice of (AE)StronglyMeasurable.enorm and `edist` (#21423) perf(RingTheory/Artinian): reorder arguments in `IsArtinianRing.isMaximal_of_isPrime` (#21449) feat(Probability): first two derivatives of `cgf` (#21223) feat(RingTheory): `Ring.KrullDimLE` type class (#21452) chore(Probability/ProbabilityMassFunction/Binomial): typo "bernoulli" (#21455) chore: remove unused argument (#21393) feat(MeasureTheory/Integral/RieszMarkovKakutani) prove that the Riesz content is regular and define the Riesz measure (#20040) chore(Topology/Algebra/ContinuousMonoidHom): do not depend on `ContinuousLinearMap` (#21443) doc(CategoryTheory/Monoidal/Category): fix expression in docs (#21445) refactor(Order/CompleteBooleanAlgebra): a complete lattice which is a Heyting algebra is automatically a frame (#21391) chore: cleanup porting notes in TuringMachine (#20821) chore: remove @[simp] when the discr_key is a lambda (#21395) feat/doc: split files, add documentation (#21421) feat(Data/Set/Lattice): iUnion + insertion (#21322) feat(Factorial): k! divides the product of any k successive integers (#21332) feat(CI): bench-after-CI (#21414) feat: primitive group actions (#12052) feat(Algebra/GroupWithZero/Int): add lemmas about Zm0 (#21370) feat(CategoryTheory): small classes of morphisms (#21411) feat(CategoryTheory): (co)limits of constant functors (#21412) chore: rename isUnit_ofPowEqOne (#21407) chore: split mapDomain out of MonoidAlgebra.Defs (#21398) chore: generalise lemmas to `ENorm` spaces, part 1 (#21380) chore: add `simp` to `Setoid.refl` (#21107) chore: tidy various files (#21406) chore(Geometry/Manifold/IsManifold): split out material on extended charts (#21219) refactor: introduce `Ideal.IsTwoSided` class for quotients of noncommutative rings (#17930) chore(Algebra/Category/ModuleCat): delete `ModuleCat.hasForgetModuleCat` (#21425) feat(RingTheory): unramified iff `κ(q)/κ(p)` is separable and `pS_q = qS_q` (#20690) doc(Order/Heyting/Basic): Coheyting difference is not right adjoint but left adjoint (#21418) chore: move ProofWidgets to v0.0.51 (#21416) chore: rename mem_nonZeroDivisor_of_injective and comap_nonZeroDivisor_le_of_injective (#21408) feat: drop ordering assumption in `RootPairing.coxeterWeight_mem_set_of_isCrystallographic` (#21122) feat(AlgebraicGeometry): the diagonal of an unramified morphism is an open immersion (#21386) feat(Data/LinearIndependent): iff versions of smul action on independent sets (#21383) chore(Combinatorics/SimpleGraph): Fix `hadj` naming (#21389) chore: rename AnalyticAt.order_neq_top_iff (#21388) fix: bug in daily.yml (#21401) chore: remove `@[simp]` from `CategoryTheory.Discrete.functor_map` (#21392) chore(Algebra/PUnitInstances): generalise universes (#21381) feat(RingTheory/PowerSeries): describe when power series map is zero (#21379) feat(Tactic/Linter): options to in/exclude definitions and private decls (#21374) feat: the prime spectrum is quasi-separated (#21362) ...
mathlib-bors bot
pushed a commit
that referenced
this pull request
Feb 6, 2025
As requested on [Zulip](https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/Re-order.20typeclass.20hypotheses.20for.20performance/near/498010542), I added a test to go along with the fix in #21449.
pfaffelh
pushed a commit
that referenced
this pull request
Feb 7, 2025
…imal_of_isPrime` (#21449) Reordering the arguments flips the type class synthesis order, so that it fails more quickly when there is no instance. https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/Strange.20simpNF.20error.20.22at.20a.20distance.22/near/497687170
pfaffelh
pushed a commit
that referenced
this pull request
Feb 7, 2025
As requested on [Zulip](https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/Re-order.20typeclass.20hypotheses.20for.20performance/near/498010542), I added a test to go along with the fix in #21449.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reordering the arguments flips the type class synthesis order, so that it fails more quickly when there is no instance.
https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/Strange.20simpNF.20error.20.22at.20a.20distance.22/near/497687170