[Merged by Bors] - feat(CI): bench-after-CI#21414
Closed
Conversation
PR summary 8dd1468fd7Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for No changes to technical debt.You can run this locally as
|
|
!bench |
Collaborator
|
Here are the benchmark results for commit 86620ea. |
|
No benchmark entry differed by at least +1.0⬝10⁹ instructions. |
bryangingechen
approved these changes
Feb 4, 2025
Contributor
bryangingechen
left a comment
There was a problem hiding this comment.
LGTM, thanks!
bors d+
Contributor
|
✌️ adomani can now approve this pull request. To approve and merge a pull request, simply reply with |
|
!bench |
Collaborator
|
Here are the benchmark results for commit 8dd1468. Benchmark Metric Change
=========================================
+ build .olean serialization -5.6% |
|
No benchmark entry differed by at least +1.0⬝10⁹ instructions. |
Contributor
Author
|
This second test did not remove the label, since the bench-summary is running the action on master! 🤦 |
Contributor
|
As usual, PRs will need to merge Thanks! |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Feb 4, 2025
Adds a CI step that checks if the `bench-after-CI` label is present. If so, it adds a comment `!bench` once CI passes, triggering a benchmarking run. The management is as follow: * the label `bench-after-CI` is applied manually while CI is running; * once CI passes the lint phase, if the label is present, a bot comments `!bench`, starting the bench process; * when the bench process terminates, it posts the report; * this triggers the bench-summary bot to post the summary *and* to remove the label. Meanwhile, the label `bench-after-CI` is in the list of labels that `bors` rejects. [Zulip](https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/.60bench-after-CI.60.3F) I added the label to this PR, ~~but I am not sure whether the workflow will act on it, since the code is not in `master`~~ and the automation worked.
Contributor
Author
Since the code in the main build workflow already worked in this PR, I suspect that only the label-removing part will depend on current master: that should not be a great problem. |
Contributor
|
I might be confused again, but I think workflows triggered by |
Contributor
|
Pull request successfully merged into master. Build succeeded: |
Julian
added a commit
that referenced
this pull request
Feb 5, 2025
* origin/master: (103 commits) chore(PresheafedSpace): remove `mk_coe` and some comments from porting (#21382) refactor(CategoryTheory): `ConcreteCategory` instance for `FintypeCat` (#21466) refactor(Algebra/Category): clean up remaining uses of `HasForget` (#21460) chore(Algebra/Field/Basic): make some arguments implicit (#21453) chore(LinearAlgebra/TensorProduct): upgrade `TensorProduct.prodRight` (#21432) docs(Logic/Function/Defs): missing backticks (#21459) style(Logic/Embedding/Set): unindent (#21457) doc: document design choice of (AE)StronglyMeasurable.enorm and `edist` (#21423) perf(RingTheory/Artinian): reorder arguments in `IsArtinianRing.isMaximal_of_isPrime` (#21449) feat(Probability): first two derivatives of `cgf` (#21223) feat(RingTheory): `Ring.KrullDimLE` type class (#21452) chore(Probability/ProbabilityMassFunction/Binomial): typo "bernoulli" (#21455) chore: remove unused argument (#21393) feat(MeasureTheory/Integral/RieszMarkovKakutani) prove that the Riesz content is regular and define the Riesz measure (#20040) chore(Topology/Algebra/ContinuousMonoidHom): do not depend on `ContinuousLinearMap` (#21443) doc(CategoryTheory/Monoidal/Category): fix expression in docs (#21445) refactor(Order/CompleteBooleanAlgebra): a complete lattice which is a Heyting algebra is automatically a frame (#21391) chore: cleanup porting notes in TuringMachine (#20821) chore: remove @[simp] when the discr_key is a lambda (#21395) feat/doc: split files, add documentation (#21421) feat(Data/Set/Lattice): iUnion + insertion (#21322) feat(Factorial): k! divides the product of any k successive integers (#21332) feat(CI): bench-after-CI (#21414) feat: primitive group actions (#12052) feat(Algebra/GroupWithZero/Int): add lemmas about Zm0 (#21370) feat(CategoryTheory): small classes of morphisms (#21411) feat(CategoryTheory): (co)limits of constant functors (#21412) chore: rename isUnit_ofPowEqOne (#21407) chore: split mapDomain out of MonoidAlgebra.Defs (#21398) chore: generalise lemmas to `ENorm` spaces, part 1 (#21380) chore: add `simp` to `Setoid.refl` (#21107) chore: tidy various files (#21406) chore(Geometry/Manifold/IsManifold): split out material on extended charts (#21219) refactor: introduce `Ideal.IsTwoSided` class for quotients of noncommutative rings (#17930) chore(Algebra/Category/ModuleCat): delete `ModuleCat.hasForgetModuleCat` (#21425) feat(RingTheory): unramified iff `κ(q)/κ(p)` is separable and `pS_q = qS_q` (#20690) doc(Order/Heyting/Basic): Coheyting difference is not right adjoint but left adjoint (#21418) chore: move ProofWidgets to v0.0.51 (#21416) chore: rename mem_nonZeroDivisor_of_injective and comap_nonZeroDivisor_le_of_injective (#21408) feat: drop ordering assumption in `RootPairing.coxeterWeight_mem_set_of_isCrystallographic` (#21122) feat(AlgebraicGeometry): the diagonal of an unramified morphism is an open immersion (#21386) feat(Data/LinearIndependent): iff versions of smul action on independent sets (#21383) chore(Combinatorics/SimpleGraph): Fix `hadj` naming (#21389) chore: rename AnalyticAt.order_neq_top_iff (#21388) fix: bug in daily.yml (#21401) chore: remove `@[simp]` from `CategoryTheory.Discrete.functor_map` (#21392) chore(Algebra/PUnitInstances): generalise universes (#21381) feat(RingTheory/PowerSeries): describe when power series map is zero (#21379) feat(Tactic/Linter): options to in/exclude definitions and private decls (#21374) feat: the prime spectrum is quasi-separated (#21362) ...
pfaffelh
pushed a commit
that referenced
this pull request
Feb 7, 2025
Adds a CI step that checks if the `bench-after-CI` label is present. If so, it adds a comment `!bench` once CI passes, triggering a benchmarking run. The management is as follow: * the label `bench-after-CI` is applied manually while CI is running; * once CI passes the lint phase, if the label is present, a bot comments `!bench`, starting the bench process; * when the bench process terminates, it posts the report; * this triggers the bench-summary bot to post the summary *and* to remove the label. Meanwhile, the label `bench-after-CI` is in the list of labels that `bors` rejects. [Zulip](https://leanprover.zulipchat.com/#narrow/channel/287929-mathlib4/topic/.60bench-after-CI.60.3F) I added the label to this PR, ~~but I am not sure whether the workflow will act on it, since the code is not in `master`~~ and the automation worked.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a CI step that checks if the
bench-after-CIlabel is present. If so, it adds a comment!benchonce CI passes, triggering a benchmarking run.The management is as follow:
bench-after-CIis applied manually while CI is running;!bench, starting the bench process;Meanwhile, the label
bench-after-CIis in the list of labels thatborsrejects.Zulip
I added the label to this PR,
but I am not sure whether the workflow will act on it, since the code is not inand the automation worked.master