[Merged by Bors] - feat(RingTheory): Ring.KrullDimLE type class#21452
Closed
[Merged by Bors] - feat(RingTheory): Ring.KrullDimLE type class#21452
Ring.KrullDimLE type class#21452Conversation
PR summary cb5af2b064
|
| File | Base Count | Head Count | Change |
|---|---|---|---|
| Mathlib.RingTheory.Ideal.Height | 1175 | 1146 | -29 (-2.47%) |
| Mathlib.RingTheory.Spectrum.Prime.Basic | 1137 | 1140 | +3 (+0.26%) |
| Mathlib.RingTheory.KrullDimension.Basic | 1170 | 1173 | +3 (+0.26%) |
Import changes for all files
| Files | Import difference |
|---|---|
Mathlib.RingTheory.Ideal.MinimalPrime |
-1125 |
Mathlib.RingTheory.Ideal.Height |
-29 |
175 filesMathlib.Algebra.Module.DedekindDomain Mathlib.Algebra.Module.PID Mathlib.AlgebraicGeometry.AffineScheme Mathlib.AlgebraicGeometry.AffineSpace Mathlib.AlgebraicGeometry.Cover.MorphismProperty Mathlib.AlgebraicGeometry.Cover.Open Mathlib.AlgebraicGeometry.Cover.Over Mathlib.AlgebraicGeometry.EllipticCurve.DivisionPolynomial.Basic Mathlib.AlgebraicGeometry.EllipticCurve.DivisionPolynomial.Degree Mathlib.AlgebraicGeometry.EllipticCurve.Group Mathlib.AlgebraicGeometry.Fiber Mathlib.AlgebraicGeometry.FunctionField Mathlib.AlgebraicGeometry.GammaSpecAdjunction Mathlib.AlgebraicGeometry.GluingOneHypercover Mathlib.AlgebraicGeometry.Gluing Mathlib.AlgebraicGeometry.IdealSheaf Mathlib.AlgebraicGeometry.Limits Mathlib.AlgebraicGeometry.Modules.Presheaf Mathlib.AlgebraicGeometry.Modules.Sheaf Mathlib.AlgebraicGeometry.Modules.Tilde Mathlib.AlgebraicGeometry.Morphisms.AffineAnd Mathlib.AlgebraicGeometry.Morphisms.Affine Mathlib.AlgebraicGeometry.Morphisms.Basic Mathlib.AlgebraicGeometry.Morphisms.ClosedImmersion Mathlib.AlgebraicGeometry.Morphisms.Constructors Mathlib.AlgebraicGeometry.Morphisms.Etale Mathlib.AlgebraicGeometry.Morphisms.FinitePresentation Mathlib.AlgebraicGeometry.Morphisms.FiniteType Mathlib.AlgebraicGeometry.Morphisms.Finite Mathlib.AlgebraicGeometry.Morphisms.Flat Mathlib.AlgebraicGeometry.Morphisms.FormallyUnramified Mathlib.AlgebraicGeometry.Morphisms.Immersion Mathlib.AlgebraicGeometry.Morphisms.Integral Mathlib.AlgebraicGeometry.Morphisms.IsIso Mathlib.AlgebraicGeometry.Morphisms.OpenImmersion Mathlib.AlgebraicGeometry.Morphisms.Preimmersion Mathlib.AlgebraicGeometry.Morphisms.Proper Mathlib.AlgebraicGeometry.Morphisms.QuasiCompact Mathlib.AlgebraicGeometry.Morphisms.QuasiSeparated Mathlib.AlgebraicGeometry.Morphisms.RingHomProperties Mathlib.AlgebraicGeometry.Morphisms.Separated Mathlib.AlgebraicGeometry.Morphisms.Smooth Mathlib.AlgebraicGeometry.Morphisms.SurjectiveOnStalks Mathlib.AlgebraicGeometry.Morphisms.UnderlyingMap Mathlib.AlgebraicGeometry.Morphisms.UniversallyClosed Mathlib.AlgebraicGeometry.Morphisms.UniversallyInjective Mathlib.AlgebraicGeometry.Noetherian Mathlib.AlgebraicGeometry.OpenImmersion Mathlib.AlgebraicGeometry.Over Mathlib.AlgebraicGeometry.PointsPi Mathlib.AlgebraicGeometry.ProjectiveSpectrum.Basic Mathlib.AlgebraicGeometry.ProjectiveSpectrum.Proper Mathlib.AlgebraicGeometry.ProjectiveSpectrum.Scheme Mathlib.AlgebraicGeometry.Properties Mathlib.AlgebraicGeometry.PullbackCarrier Mathlib.AlgebraicGeometry.Pullbacks Mathlib.AlgebraicGeometry.RationalMap Mathlib.AlgebraicGeometry.ResidueField Mathlib.AlgebraicGeometry.Restrict Mathlib.AlgebraicGeometry.Scheme Mathlib.AlgebraicGeometry.Sites.BigZariski Mathlib.AlgebraicGeometry.Sites.Etale Mathlib.AlgebraicGeometry.Sites.MorphismProperty Mathlib.AlgebraicGeometry.Sites.SmallAffineZariski Mathlib.AlgebraicGeometry.Sites.Small Mathlib.AlgebraicGeometry.Spec Mathlib.AlgebraicGeometry.SpreadingOut Mathlib.AlgebraicGeometry.Stalk Mathlib.AlgebraicGeometry.StructureSheaf Mathlib.AlgebraicGeometry.ValuativeCriterion Mathlib.Analysis.Fourier.FiniteAbelian.PontryaginDuality Mathlib.Analysis.Fourier.ZMod Mathlib.Analysis.SpecialFunctions.Complex.CircleAddChar Mathlib.FieldTheory.AxGrothendieck Mathlib.FieldTheory.Laurent Mathlib.FieldTheory.RatFunc.AsPolynomial Mathlib.FieldTheory.RatFunc.Degree Mathlib.GroupTheory.FiniteAbelian.Basic Mathlib.GroupTheory.FiniteAbelian.Duality Mathlib.ModelTheory.Algebra.Ring.Definability Mathlib.NumberTheory.ClassNumber.Finite Mathlib.NumberTheory.ClassNumber.FunctionField Mathlib.NumberTheory.Cyclotomic.Basic Mathlib.NumberTheory.Cyclotomic.Discriminant Mathlib.NumberTheory.Cyclotomic.Embeddings Mathlib.NumberTheory.Cyclotomic.Gal Mathlib.NumberTheory.Cyclotomic.PID Mathlib.NumberTheory.Cyclotomic.PrimitiveRoots Mathlib.NumberTheory.Cyclotomic.Rat Mathlib.NumberTheory.Cyclotomic.Three Mathlib.NumberTheory.DirichletCharacter.GaussSum Mathlib.NumberTheory.DirichletCharacter.Orthogonality Mathlib.NumberTheory.FLT.Three Mathlib.NumberTheory.Fermat Mathlib.NumberTheory.FunctionField Mathlib.NumberTheory.GaussSum Mathlib.NumberTheory.JacobiSum.Basic Mathlib.NumberTheory.KummerDedekind Mathlib.NumberTheory.LSeries.DirichletContinuation Mathlib.NumberTheory.LSeries.Nonvanishing Mathlib.NumberTheory.LSeries.PrimesInAP Mathlib.NumberTheory.LSeries.ZMod Mathlib.NumberTheory.LegendreSymbol.AddCharacter Mathlib.NumberTheory.LegendreSymbol.JacobiSymbol Mathlib.NumberTheory.LegendreSymbol.QuadraticChar.GaussSum Mathlib.NumberTheory.LegendreSymbol.QuadraticReciprocity Mathlib.NumberTheory.MulChar.Duality Mathlib.NumberTheory.NumberField.AdeleRing Mathlib.NumberTheory.NumberField.CanonicalEmbedding.Basic Mathlib.NumberTheory.NumberField.CanonicalEmbedding.ConvexBody Mathlib.NumberTheory.NumberField.CanonicalEmbedding.FundamentalCone Mathlib.NumberTheory.NumberField.ClassNumber Mathlib.NumberTheory.NumberField.Discriminant.Basic Mathlib.NumberTheory.NumberField.EquivReindex Mathlib.NumberTheory.NumberField.FinitePlaces Mathlib.NumberTheory.NumberField.FractionalIdeal Mathlib.NumberTheory.NumberField.House Mathlib.NumberTheory.NumberField.ProductFormula Mathlib.NumberTheory.NumberField.Units.DirichletTheorem Mathlib.NumberTheory.NumberField.Units.Regulator Mathlib.NumberTheory.PrimesCongruentOne Mathlib.NumberTheory.RamificationInertia.Basic Mathlib.RingTheory.Artinian.Algebra Mathlib.RingTheory.Artinian.Ring Mathlib.RingTheory.ClassGroup Mathlib.RingTheory.DedekindDomain.AdicValuation Mathlib.RingTheory.DedekindDomain.Different Mathlib.RingTheory.DedekindDomain.Factorization Mathlib.RingTheory.DedekindDomain.FiniteAdeleRing Mathlib.RingTheory.DedekindDomain.Ideal Mathlib.RingTheory.DedekindDomain.PID Mathlib.RingTheory.DedekindDomain.SInteger Mathlib.RingTheory.DedekindDomain.SelmerGroup Mathlib.RingTheory.Etale.Field Mathlib.RingTheory.FractionalIdeal.Norm Mathlib.RingTheory.Ideal.Norm.AbsNorm Mathlib.RingTheory.Ideal.Norm.RelNorm Mathlib.RingTheory.Jacobson.Ring Mathlib.RingTheory.LaurentSeries Mathlib.RingTheory.LittleWedderburn Mathlib.RingTheory.Nullstellensatz Mathlib.RingTheory.Polynomial.Cyclotomic.Basic Mathlib.RingTheory.Polynomial.Cyclotomic.Eval Mathlib.RingTheory.Polynomial.Cyclotomic.Expand Mathlib.RingTheory.Polynomial.Cyclotomic.Roots Mathlib.RingTheory.Polynomial.Eisenstein.IsIntegral Mathlib.RingTheory.Regular.RegularSequence Mathlib.RingTheory.RingHom.Unramified Mathlib.RingTheory.RootsOfUnity.AlgebraicallyClosed Mathlib.RingTheory.Smooth.Locus Mathlib.RingTheory.Spectrum.Maximal.Localization Mathlib.RingTheory.Spectrum.Maximal.Topology Mathlib.RingTheory.Spectrum.Prime.ConstructibleSet Mathlib.RingTheory.Spectrum.Prime.FreeLocus Mathlib.RingTheory.Spectrum.Prime.IsOpenComapC Mathlib.RingTheory.Spectrum.Prime.Jacobson Mathlib.RingTheory.Spectrum.Prime.Module Mathlib.RingTheory.Spectrum.Prime.Noetherian Mathlib.RingTheory.Spectrum.Prime.Polynomial Mathlib.RingTheory.Spectrum.Prime.TensorProduct Mathlib.RingTheory.Spectrum.Prime.Topology Mathlib.RingTheory.Support Mathlib.RingTheory.Unramified.Field Mathlib.RingTheory.Unramified.LocalRing Mathlib.RingTheory.Unramified.Locus Mathlib.RingTheory.Valuation.AlgebraInstances Mathlib.RingTheory.Valuation.LocalSubring Mathlib.RingTheory.Valuation.RamificationGroup Mathlib.RingTheory.Valuation.ValuationSubring Mathlib.Tactic.NormNum.LegendreSymbol Mathlib.Tactic Mathlib.Topology.Algebra.Valued.LocallyCompact Mathlib.Topology.Algebra.Valued.NormedValued Mathlib.Topology.Algebra.Valued.ValuationTopology Mathlib.Topology.Algebra.Valued.ValuedField |
1 |
58 filesMathlib.Algebra.Jordan.Basic Mathlib.Algebra.Lie.Abelian Mathlib.Algebra.Lie.BaseChange Mathlib.Algebra.Lie.CartanExists Mathlib.Algebra.Lie.CartanMatrix Mathlib.Algebra.Lie.CartanSubalgebra Mathlib.Algebra.Lie.Character Mathlib.Algebra.Lie.Classical Mathlib.Algebra.Lie.Derivation.AdjointAction Mathlib.Algebra.Lie.Derivation.Basic Mathlib.Algebra.Lie.Derivation.Killing Mathlib.Algebra.Lie.DirectSum Mathlib.Algebra.Lie.EngelSubalgebra Mathlib.Algebra.Lie.Engel Mathlib.Algebra.Lie.Extension Mathlib.Algebra.Lie.Free Mathlib.Algebra.Lie.IdealOperations Mathlib.Algebra.Lie.InvariantForm Mathlib.Algebra.Lie.Killing Mathlib.Algebra.Lie.LieTheorem Mathlib.Algebra.Lie.Matrix Mathlib.Algebra.Lie.Nilpotent Mathlib.Algebra.Lie.Normalizer Mathlib.Algebra.Lie.OfAssociative Mathlib.Algebra.Lie.Quotient Mathlib.Algebra.Lie.Rank Mathlib.Algebra.Lie.Semisimple.Basic Mathlib.Algebra.Lie.Semisimple.Defs Mathlib.Algebra.Lie.SkewAdjoint Mathlib.Algebra.Lie.Sl2 Mathlib.Algebra.Lie.Solvable Mathlib.Algebra.Lie.Subalgebra Mathlib.Algebra.Lie.Submodule Mathlib.Algebra.Lie.TensorProduct Mathlib.Algebra.Lie.TraceForm Mathlib.Algebra.Lie.UniversalEnveloping Mathlib.Algebra.Lie.Weights.Basic Mathlib.Algebra.Lie.Weights.Cartan Mathlib.Algebra.Lie.Weights.Chain Mathlib.Algebra.Lie.Weights.Killing Mathlib.Algebra.Lie.Weights.Linear Mathlib.Algebra.Lie.Weights.RootSystem Mathlib.Algebra.Symmetrized Mathlib.Analysis.InnerProductSpace.JointEigenspace Mathlib.Analysis.InnerProductSpace.Semisimple Mathlib.FieldTheory.JacobsonNoether Mathlib.Geometry.Manifold.Algebra.LeftInvariantDerivation Mathlib.LinearAlgebra.Eigenspace.Semisimple Mathlib.LinearAlgebra.Eigenspace.Zero Mathlib.LinearAlgebra.JordanChevalley Mathlib.LinearAlgebra.Semisimple Mathlib.RingTheory.Artinian.Instances Mathlib.RingTheory.Artinian.Module Mathlib.RingTheory.Derivation.Lie Mathlib.RingTheory.FiniteLength Mathlib.RingTheory.KrullDimension.Basic Mathlib.RingTheory.KrullDimension.Field Mathlib.RingTheory.Spectrum.Prime.Basic |
3 |
Mathlib.RingTheory.Ideal.MinimalPrime.Basic (new file) |
1035 |
Mathlib.RingTheory.Ideal.MinimalPrime.Localization |
1126 |
Declarations diff
+ KrullDimLE
+ KrullDimLE.mono
+ Ring.KrullDimLE
+ Ring.KrullDimLE.mk₀
+ Ring.KrullDimLE.mk₁
+ Ring.KrullDimLE.mk₁'
+ Ring.krullDimLE_one_iff
+ Ring.krullDimLE_one_iff_of_isDomain
+ Ring.krullDimLE_one_iff_of_isPrime_bot
+ Ring.krullDimLE_zero_iff
+ instance (priority := 100) Ideal.isMaximal_of_isPrime [Ring.KrullDimLE 0 R]
You can run this locally as follows
## summary with just the declaration names:
./scripts/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/declarations_diff.sh long <optional_commit>The doc-module for script/declarations_diff.sh contains some details about this script.
No changes to technical debt.
You can run this locally as
./scripts/technical-debt-metrics.sh pr_summary
- The
relativevalue is the weighted sum of the differences with weight given by the inverse of the current value of the statistic. - The
absolutevalue is therelativevalue divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).
Member
|
Thanks 🎉 bors merge |
mathlib-bors bot
pushed a commit
that referenced
this pull request
Feb 5, 2025
Also split `RingTheory/Ideal/MinimalPrimes.lean` into `RingTheory/Ideal/MinimalPrimes/Basic.lean` and `RingTheory/Ideal/MinimalPrimes/Localization.lean`. Co-authored-by: Andrew Yang <36414270+erdOne@users.noreply.github.com>
Contributor
|
Pull request successfully merged into master. Build succeeded: |
Ring.KrullDimLE type classRing.KrullDimLE type class
Julian
added a commit
that referenced
this pull request
Feb 5, 2025
* origin/master: (103 commits) chore(PresheafedSpace): remove `mk_coe` and some comments from porting (#21382) refactor(CategoryTheory): `ConcreteCategory` instance for `FintypeCat` (#21466) refactor(Algebra/Category): clean up remaining uses of `HasForget` (#21460) chore(Algebra/Field/Basic): make some arguments implicit (#21453) chore(LinearAlgebra/TensorProduct): upgrade `TensorProduct.prodRight` (#21432) docs(Logic/Function/Defs): missing backticks (#21459) style(Logic/Embedding/Set): unindent (#21457) doc: document design choice of (AE)StronglyMeasurable.enorm and `edist` (#21423) perf(RingTheory/Artinian): reorder arguments in `IsArtinianRing.isMaximal_of_isPrime` (#21449) feat(Probability): first two derivatives of `cgf` (#21223) feat(RingTheory): `Ring.KrullDimLE` type class (#21452) chore(Probability/ProbabilityMassFunction/Binomial): typo "bernoulli" (#21455) chore: remove unused argument (#21393) feat(MeasureTheory/Integral/RieszMarkovKakutani) prove that the Riesz content is regular and define the Riesz measure (#20040) chore(Topology/Algebra/ContinuousMonoidHom): do not depend on `ContinuousLinearMap` (#21443) doc(CategoryTheory/Monoidal/Category): fix expression in docs (#21445) refactor(Order/CompleteBooleanAlgebra): a complete lattice which is a Heyting algebra is automatically a frame (#21391) chore: cleanup porting notes in TuringMachine (#20821) chore: remove @[simp] when the discr_key is a lambda (#21395) feat/doc: split files, add documentation (#21421) feat(Data/Set/Lattice): iUnion + insertion (#21322) feat(Factorial): k! divides the product of any k successive integers (#21332) feat(CI): bench-after-CI (#21414) feat: primitive group actions (#12052) feat(Algebra/GroupWithZero/Int): add lemmas about Zm0 (#21370) feat(CategoryTheory): small classes of morphisms (#21411) feat(CategoryTheory): (co)limits of constant functors (#21412) chore: rename isUnit_ofPowEqOne (#21407) chore: split mapDomain out of MonoidAlgebra.Defs (#21398) chore: generalise lemmas to `ENorm` spaces, part 1 (#21380) chore: add `simp` to `Setoid.refl` (#21107) chore: tidy various files (#21406) chore(Geometry/Manifold/IsManifold): split out material on extended charts (#21219) refactor: introduce `Ideal.IsTwoSided` class for quotients of noncommutative rings (#17930) chore(Algebra/Category/ModuleCat): delete `ModuleCat.hasForgetModuleCat` (#21425) feat(RingTheory): unramified iff `κ(q)/κ(p)` is separable and `pS_q = qS_q` (#20690) doc(Order/Heyting/Basic): Coheyting difference is not right adjoint but left adjoint (#21418) chore: move ProofWidgets to v0.0.51 (#21416) chore: rename mem_nonZeroDivisor_of_injective and comap_nonZeroDivisor_le_of_injective (#21408) feat: drop ordering assumption in `RootPairing.coxeterWeight_mem_set_of_isCrystallographic` (#21122) feat(AlgebraicGeometry): the diagonal of an unramified morphism is an open immersion (#21386) feat(Data/LinearIndependent): iff versions of smul action on independent sets (#21383) chore(Combinatorics/SimpleGraph): Fix `hadj` naming (#21389) chore: rename AnalyticAt.order_neq_top_iff (#21388) fix: bug in daily.yml (#21401) chore: remove `@[simp]` from `CategoryTheory.Discrete.functor_map` (#21392) chore(Algebra/PUnitInstances): generalise universes (#21381) feat(RingTheory/PowerSeries): describe when power series map is zero (#21379) feat(Tactic/Linter): options to in/exclude definitions and private decls (#21374) feat: the prime spectrum is quasi-separated (#21362) ...
pfaffelh
pushed a commit
that referenced
this pull request
Feb 7, 2025
Also split `RingTheory/Ideal/MinimalPrimes.lean` into `RingTheory/Ideal/MinimalPrimes/Basic.lean` and `RingTheory/Ideal/MinimalPrimes/Localization.lean`. Co-authored-by: Andrew Yang <36414270+erdOne@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also split
RingTheory/Ideal/MinimalPrimes.leanintoRingTheory/Ideal/MinimalPrimes/Basic.leanandRingTheory/Ideal/MinimalPrimes/Localization.lean.