Revert "Minimizing JArrayHelper by using Joomla\Utilities\ArrayHelper internally"#8455
Revert "Minimizing JArrayHelper by using Joomla\Utilities\ArrayHelper internally"#8455
Conversation
|
At least keep the changes in |
|
@wilsonge Let us merge this one and then re-think what we can change |
|
Why? there a 4 function changes. 2 of them are b/c 2 aren't. so just revert the stuff that is not b/c. |
|
@wilsonge @rdeutz Should I PR again to revert just those methods with B/C issues? I mean to revert only If we can update |
|
We're not going to change the framework. We'll just need to override those methods at the CMS levels. But yes - we'll need to keep the |
|
@wilsonge I didn't mean to change the framework. |
|
I would prefer to revert this one and have a new PR for the changes that are not a B/C break, could you do a PR @izharaazmi ? |
|
@rdeutz Sure! But its over for today's work now. I'll do that tomorrow positively. |
|
@rdeutz I am ready to send the PR let me know if you are merging this reverse or I should just include this all in my new PR. |
…using Joomla\Utilities\ArrayHelper internally. Leaving (reverting from joomla#7782) other four methods as is for b/c reasons as mentioned in joomla#8455.
Revert "Minimizing JArrayHelper by using Joomla\Utilities\ArrayHelper internally"
…using Joomla\Utilities\ArrayHelper internally. Leaving (reverting from joomla#7782) other four methods as is for b/c reasons as mentioned in joomla#8455.
* re-arrayhelper-min: (2467 commits) Minimize JArrayHelper methods `toInteger`, `pivot`, `arrayUnique` by using Joomla\Utilities\ArrayHelper internally. Leaving (reverting from joomla#7782) other four methods as is for b/c reasons as mentioned in joomla#8455. remove platform include (joomla#11615) [GitHub Templates] Make headings bigger (joomla#11607) [com_contact] Make ACL core.edit.own work (PR for 11466) (joomla#11503) Small review on docs & code structure in JModelLegacy library classes (joomla#11057) Obviously, this should be an array. (joomla#11610) Don't manually import JPlatform anymore (joomla#10841) Parse preprocess rules from component routers (joomla#8986) Add the correct exception after 11593 merge (was waiting for that merrge) (joomla#11606) Add missing clean line after joomla#9277 (joomla#11605) Deprecate the _PROFILER global var (joomla#10845) Spelling errors (joomla#11604) Moved travis javascript bash file to build/travis like joomla#11600 (joomla#11603) Regression: Fix edit check in backend articles manager, always denying edit after soft deny (joomla#11511) [com_plugins] User not allowed to core.manage? Use 403 php custom exception (instead of a 404 JError) (joomla#11593) [com_newsfeeds] Make ACL core.edit.own work (PR for 11466) (joomla#11502) $result-variable-undefined-given-default-value (joomla#9277) com_banners use exceptions. and not allowed is a 403 (joomla#11418) Frontend & plugins using the autoloader (joomla#10882) New version of PR 6788 (JText::_() Optimizations) (joomla#11235) ...
) * Minimize JArrayHelper methods `toInteger`, `pivot`, `arrayUnique` by using Joomla\Utilities\ArrayHelper internally. Leaving (reverting from #7782) other four methods as is for b/c reasons as mentioned in #8455. * Minimize JArrayHelper methods `toInteger`, `pivot`, `arrayUnique` by using Joomla\Utilities\ArrayHelper internally. Leaving (reverting from #7782) other four methods as is for b/c reasons as mentioned in #8455.
…omla#8479) * Minimize JArrayHelper methods `toInteger`, `pivot`, `arrayUnique` by using Joomla\Utilities\ArrayHelper internally. Leaving (reverting from joomla#7782) other four methods as is for b/c reasons as mentioned in joomla#8455. * Minimize JArrayHelper methods `toInteger`, `pivot`, `arrayUnique` by using Joomla\Utilities\ArrayHelper internally. Leaving (reverting from joomla#7782) other four methods as is for b/c reasons as mentioned in joomla#8455.
…omla#8479) * Minimize JArrayHelper methods `toInteger`, `pivot`, `arrayUnique` by using Joomla\Utilities\ArrayHelper internally. Leaving (reverting from joomla#7782) other four methods as is for b/c reasons as mentioned in joomla#8455. * Minimize JArrayHelper methods `toInteger`, `pivot`, `arrayUnique` by using Joomla\Utilities\ArrayHelper internally. Leaving (reverting from joomla#7782) other four methods as is for b/c reasons as mentioned in joomla#8455.
Reverts #7782
We have to revert the change because a protected function _fromObject and _sortObject are removed by the change.
Here is why. Someone could have extend the class and use one of the removed functions. It is a bad idea but someone could and this change isn't B/C.