[com_banners] User not allowed to core.manage? Use 403 php exception (instead of a 404 JError)#11418
Conversation
|
I'd prefer a more specific Exception class but +1 on the idea. |
|
yes i would prefer to, but can you hint on how to add a specific exception like |
|
Well, if there isn't something in the standard SPL exceptions, just add a custom class like we have in the database API. |
|
hum, doesn't seem to be any http://php.net/manual/en/spl.exceptions.php |
|
I have tested this item ✅ successfully on 0cded66 This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11418. |
2 similar comments
|
I have tested this item ✅ successfully on 0cded66 This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11418. |
|
I have tested this item ✅ successfully on 0cded66 This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11418. |
|
RTC please This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11418. |
|
I would like to see a nicer error message, this one looks very technical. I also think to have some custom exceptions would be great. Merging it anyway because this is the way to go |
|
what about:
or
|
|
people that is a language change nothing to do with this PR which porpose is to change the error to an exception. |
* re-arrayhelper-min: (2467 commits) Minimize JArrayHelper methods `toInteger`, `pivot`, `arrayUnique` by using Joomla\Utilities\ArrayHelper internally. Leaving (reverting from joomla#7782) other four methods as is for b/c reasons as mentioned in joomla#8455. remove platform include (joomla#11615) [GitHub Templates] Make headings bigger (joomla#11607) [com_contact] Make ACL core.edit.own work (PR for 11466) (joomla#11503) Small review on docs & code structure in JModelLegacy library classes (joomla#11057) Obviously, this should be an array. (joomla#11610) Don't manually import JPlatform anymore (joomla#10841) Parse preprocess rules from component routers (joomla#8986) Add the correct exception after 11593 merge (was waiting for that merrge) (joomla#11606) Add missing clean line after joomla#9277 (joomla#11605) Deprecate the _PROFILER global var (joomla#10845) Spelling errors (joomla#11604) Moved travis javascript bash file to build/travis like joomla#11600 (joomla#11603) Regression: Fix edit check in backend articles manager, always denying edit after soft deny (joomla#11511) [com_plugins] User not allowed to core.manage? Use 403 php custom exception (instead of a 404 JError) (joomla#11593) [com_newsfeeds] Make ACL core.edit.own work (PR for 11466) (joomla#11502) $result-variable-undefined-given-default-value (joomla#9277) com_banners use exceptions. and not allowed is a 403 (joomla#11418) Frontend & plugins using the autoloader (joomla#10882) New version of PR 6788 (JText::_() Optimizations) (joomla#11235) ...
I would like to see a nicer error message, this one looks very technical. I also think to have some custom exceptions would be great. Merging it anyway because this is the way to go
I would like to see a nicer error message, this one looks very technical. I also think to have some custom exceptions would be great. Merging it anyway because this is the way to go
Pull Request for Improvement.
Summary of Changes
Replace com_banners exisiting 404 JError for a 403 php exception when the user does not have access to "Access Administration Interface" (core.manage).
Before
After
Testing Instructions
If this change is ok i can do it for the other components that uses JError here.