[com_contact] Make ACL core.edit.own work (PR for 11466) by andrepereiradasilva · Pull Request #11503 · joomla/joomla-cms

andrepereiradasilva · 2016-08-07T00:57:48Z

Pull Request for Issue #11466 (com_contact part).

Summary of Changes

The ACL core.edit.own is not working in com_contact.
This PR makes it work.

Testing Instructions

Use latest staging
Besides the Super User, create a user "test" added to "Administrator" group
Go to com_contact Options, Permissions tab and diable "Edit" for "Administrator" group
Now create a new contact with the "test" user (use another browser or a private window)
Try to edit that item. You can't edit our own. Bug
Now do the same test but with a contact category Permission. You can't edit our own. Bug
Apply patch, repeat step 5. and 6. and now you can edit our own items.
Code review

Also use the two users to do a general test with the com_contact edit permissions to confirm all is fine.

Documentation Changes Required

None.

Notes

This problem was discovered in GsoC 2016 Multilingual project.

This is very similiar with #11502.

infograf768 · 2016-08-07T05:50:51Z

I have tested this item ✅ successfully on 3282bfd

:1:

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11503.}

infograf768 · 2016-08-07T05:58:26Z

Note: The PR works great.
One issue, not related to this PR:
If the user is denied access to com_users Access Administration Interface (Typical for the default Manager group) then he can't assign a user to the Contact.
Needs some thought imho.

alikon · 2016-08-07T06:42:02Z

I have tested this item ✅ successfully on 3282bfd

works as described

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11503.}

infograf768 · 2016-08-07T07:11:47Z

I have tested this item 🔴 unsuccessfully on 3282bfd

Changed my testing as we have a NOtice

[07-Aug-2016 07:10:36 UTC] PHP Notice: Undefined variable: record in ROOT/administrator/components/com_contact/controllers/contact.php on line 82

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11503.}

andrepereiradasilva · 2016-08-07T07:25:39Z

sorry guys. corrected that. please test.

alikon · 2016-08-07T07:28:44Z

no more notice after last update

alikon · 2016-08-07T07:29:08Z

I have tested this item ✅ successfully on a1fb945

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11503.}

infograf768 · 2016-08-07T07:31:56Z

I have tested this item ✅ successfully on a1fb945

RTC. Thanks

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11503.}

infograf768 · 2016-08-07T07:32:23Z

RTC

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11503.}

brianteeman · 2016-08-07T09:51:20Z

@wilsonge is this ok to merge or does it bring back a certain issue

rdeutz · 2016-08-14T16:23:04Z

this looks good to me @wilsonge, have set the milestone, your turn to press the merge button

wilsonge · 2016-08-15T10:26:31Z

I'm just going to hold on this until i can test some stuff ;)

andrepereiradasilva · 2016-08-15T11:45:43Z

ok @wilsonge, go ahead, more tests are alwys good.

Just informing that are (at least) 4 PR similiar to this one:

[com_newsfeeds] Make ACL core.edit.own work (PR for 11466) #11502 (merged)
Regression: Fix edit check in backend articles manager, always denying edit after soft deny #11511 (merged)
Refactor allowEdit of backend category controller #11547 (open)
[com_weblinks] Make ACL core.edit.own work (PR for 11466) joomla-extensions/weblinks#255 (merged)

So if you find something all need to be changed.

wilsonge · 2016-08-15T12:42:39Z

Oh didn't realise we'd merged the other two. Merging this then. We can go back

* re-arrayhelper-min: (2467 commits) Minimize JArrayHelper methods `toInteger`, `pivot`, `arrayUnique` by using Joomla\Utilities\ArrayHelper internally. Leaving (reverting from joomla#7782) other four methods as is for b/c reasons as mentioned in joomla#8455. remove platform include (joomla#11615) [GitHub Templates] Make headings bigger (joomla#11607) [com_contact] Make ACL core.edit.own work (PR for 11466) (joomla#11503) Small review on docs & code structure in JModelLegacy library classes (joomla#11057) Obviously, this should be an array. (joomla#11610) Don't manually import JPlatform anymore (joomla#10841) Parse preprocess rules from component routers (joomla#8986) Add the correct exception after 11593 merge (was waiting for that merrge) (joomla#11606) Add missing clean line after joomla#9277 (joomla#11605) Deprecate the _PROFILER global var (joomla#10845) Spelling errors (joomla#11604) Moved travis javascript bash file to build/travis like joomla#11600 (joomla#11603) Regression: Fix edit check in backend articles manager, always denying edit after soft deny (joomla#11511) [com_plugins] User not allowed to core.manage? Use 403 php custom exception (instead of a 404 JError) (joomla#11593) [com_newsfeeds] Make ACL core.edit.own work (PR for 11466) (joomla#11502) $result-variable-undefined-given-default-value (joomla#9277) com_banners use exceptions. and not allowed is a 403 (joomla#11418) Frontend & plugins using the autoloader (joomla#10882) New version of PR 6788 (JText::_() Optimizations) (joomla#11235) ...

* fix core.edit.own * correct variable

fix core.edit.own

3282bfd

joomla-cms-bot added the PR-staging label Aug 7, 2016

This was referenced Aug 7, 2016

[com_newsfeeds] Make ACL core.edit.own work (PR for 11466) #11502

Merged

ACL edit.own does not work for Contacts and Newsfeeds #11466

Closed

[com_weblinks] Make ACL core.edit.own work (PR for 11466) joomla-extensions/weblinks#255

Merged

correct variable

a1fb945

joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Aug 7, 2016

ggppdk mentioned this pull request Aug 10, 2016

Refactor allowEdit of backend category controller #11547

Merged

andrepereiradasilva mentioned this pull request Aug 12, 2016

PR waiting core merge joomla-projects/gsoc16_improved-multi-lingual#87

Closed

rdeutz added this to the Joomla 3.6.3 milestone Aug 14, 2016

wilsonge merged commit 3f2f1eb into joomla:staging Aug 15, 2016

joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Aug 15, 2016

andrepereiradasilva deleted the acl-contact branch August 15, 2016 12:48

ggppdk pushed a commit to ggppdk/joomla-cms that referenced this pull request Aug 19, 2016

[com_contact] Make ACL core.edit.own work (PR for 11466) (joomla#11503)

81ed36c

* fix core.edit.own * correct variable

roland-d pushed a commit to roland-d/joomla-cms that referenced this pull request Sep 11, 2016

[com_contact] Make ACL core.edit.own work (PR for 11466) (joomla#11503)

f553a2b

* fix core.edit.own * correct variable

Uh oh!

Conversation

andrepereiradasilva commented Aug 7, 2016 • edited by joomla-cms-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary of Changes

Testing Instructions

Documentation Changes Required

Notes

Uh oh!

infograf768 commented Aug 7, 2016

Uh oh!

infograf768 commented Aug 7, 2016

Uh oh!

alikon commented Aug 7, 2016

Uh oh!

infograf768 commented Aug 7, 2016

Uh oh!

andrepereiradasilva commented Aug 7, 2016

Uh oh!

alikon commented Aug 7, 2016

Uh oh!

alikon commented Aug 7, 2016

Uh oh!

infograf768 commented Aug 7, 2016

Uh oh!

infograf768 commented Aug 7, 2016

Uh oh!

brianteeman commented Aug 7, 2016

Uh oh!

rdeutz commented Aug 14, 2016

Uh oh!

wilsonge commented Aug 15, 2016

Uh oh!

andrepereiradasilva commented Aug 15, 2016

Uh oh!

wilsonge commented Aug 15, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

andrepereiradasilva commented Aug 7, 2016 •

edited by joomla-cms-bot

Loading