Skip to content

remove platform include#11615

Merged
mbabker merged 1 commit intojoomla:stagingfrom
rdeutz:fix_jplatform_tests
Aug 15, 2016
Merged

remove platform include#11615
mbabker merged 1 commit intojoomla:stagingfrom
rdeutz:fix_jplatform_tests

Conversation

@rdeutz
Copy link
Copy Markdown
Contributor

@rdeutz rdeutz commented Aug 15, 2016

Executive summary

This is a fixes a problem that came up after merging PR #10841. In 10841 the file platform was moved into the subdirectory joomla but the tests are still loading the file from the libraries folder. We don’t need to load the file at all so I removed the explicit loading of the file.

Testing instruction

  • Apply patch
  • Check if travis/jenkins are happy

Can merged on Review @mbabker

@rdeutz rdeutz added this to the Joomla 3.6.3 milestone Aug 15, 2016
@rdeutz rdeutz deleted the fix_jplatform_tests branch August 15, 2016 15:29
izharaazmi added a commit to izharaazmi/joomla-cms that referenced this pull request Aug 15, 2016
* re-arrayhelper-min: (2467 commits)
  Minimize JArrayHelper methods `toInteger`, `pivot`, `arrayUnique` by using Joomla\Utilities\ArrayHelper internally. Leaving (reverting from joomla#7782) other four methods as is for b/c reasons as mentioned in joomla#8455.
  remove platform include (joomla#11615)
  [GitHub Templates] Make headings bigger (joomla#11607)
  [com_contact] Make ACL core.edit.own work (PR for 11466) (joomla#11503)
  Small review on docs & code structure in JModelLegacy library classes (joomla#11057)
  Obviously, this should be an array. (joomla#11610)
  Don't manually import JPlatform anymore (joomla#10841)
  Parse preprocess rules from component routers (joomla#8986)
  Add the correct exception after 11593 merge (was waiting for that merrge) (joomla#11606)
  Add missing clean line after joomla#9277 (joomla#11605)
  Deprecate the _PROFILER global var (joomla#10845)
  Spelling errors (joomla#11604)
  Moved travis javascript bash file to build/travis like joomla#11600 (joomla#11603)
  Regression: Fix edit check in backend articles manager, always denying edit after soft deny (joomla#11511)
  [com_plugins] User not allowed to core.manage? Use 403 php custom exception (instead of a 404 JError) (joomla#11593)
  [com_newsfeeds] Make ACL core.edit.own work (PR for 11466) (joomla#11502)
  $result-variable-undefined-given-default-value (joomla#9277)
  com_banners use exceptions. and not allowed is a 403 (joomla#11418)
  Frontend & plugins using the autoloader (joomla#10882)
  New version of PR 6788 (JText::_() Optimizations) (joomla#11235)
  ...
ggppdk pushed a commit to ggppdk/joomla-cms that referenced this pull request Aug 19, 2016
roland-d pushed a commit to roland-d/joomla-cms that referenced this pull request Sep 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants