[com_newsfeeds] Make ACL core.edit.own work (PR for 11466)#11502
Merged
rdeutz merged 4 commits intojoomla:stagingfrom Aug 14, 2016
Merged
[com_newsfeeds] Make ACL core.edit.own work (PR for 11466)#11502rdeutz merged 4 commits intojoomla:stagingfrom
rdeutz merged 4 commits intojoomla:stagingfrom
Conversation
This was referenced Aug 7, 2016
Contributor
|
I have not tested this, but it looks good on code review |
Member
|
I have tested this item ✅ successfully on e31bdd9 This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11502. |
Member
|
I have tested this item 🔴 unsuccessfully on e31bdd9 [07-Aug-2016 07:12:14 UTC] PHP Notice: Undefined variable: record in ROOT/administrator/components/com_newsfeeds/controllers/newsfeed.php on line 83 This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11502. |
Contributor
|
Yes variable name is $item not $record |
Contributor
Author
|
sorry guys. corrected that. please test. |
Contributor
|
no more notice after the last update |
Contributor
|
I have tested this item ✅ successfully on 02ba804 This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11502. |
1 similar comment
Member
|
I have tested this item ✅ successfully on 02ba804 This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11502. |
Member
|
RTC. Thanks This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/11502. |
izharaazmi
added a commit
to izharaazmi/joomla-cms
that referenced
this pull request
Aug 15, 2016
* re-arrayhelper-min: (2467 commits) Minimize JArrayHelper methods `toInteger`, `pivot`, `arrayUnique` by using Joomla\Utilities\ArrayHelper internally. Leaving (reverting from joomla#7782) other four methods as is for b/c reasons as mentioned in joomla#8455. remove platform include (joomla#11615) [GitHub Templates] Make headings bigger (joomla#11607) [com_contact] Make ACL core.edit.own work (PR for 11466) (joomla#11503) Small review on docs & code structure in JModelLegacy library classes (joomla#11057) Obviously, this should be an array. (joomla#11610) Don't manually import JPlatform anymore (joomla#10841) Parse preprocess rules from component routers (joomla#8986) Add the correct exception after 11593 merge (was waiting for that merrge) (joomla#11606) Add missing clean line after joomla#9277 (joomla#11605) Deprecate the _PROFILER global var (joomla#10845) Spelling errors (joomla#11604) Moved travis javascript bash file to build/travis like joomla#11600 (joomla#11603) Regression: Fix edit check in backend articles manager, always denying edit after soft deny (joomla#11511) [com_plugins] User not allowed to core.manage? Use 403 php custom exception (instead of a 404 JError) (joomla#11593) [com_newsfeeds] Make ACL core.edit.own work (PR for 11466) (joomla#11502) $result-variable-undefined-given-default-value (joomla#9277) com_banners use exceptions. and not allowed is a 403 (joomla#11418) Frontend & plugins using the autoloader (joomla#10882) New version of PR 6788 (JText::_() Optimizations) (joomla#11235) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #11466 (com_newsfeeds part).
Summary of Changes
The ACL core.edit.own is not working in newsfeeds.
This PR makes it work.
Testing Instructions
Also use the two users to do a general test with the com_newsfeeds edit permissions to confirm all is fine.
Documentation Changes Required
None.
Notes
This problem was discovered in GsoC 2016 Multilingual project.
This is very similiar with #11503.