[com_weblinks] Make ACL core.edit.own work (PR for 11466)#255
[com_weblinks] Make ACL core.edit.own work (PR for 11466)#255rdeutz merged 6 commits intojoomla-extensions:masterfrom
Conversation
|
i guess the test errors have nothing to do with this PR ... |
| $canEditOwn = $user->authorise('core.edit.own', $this->option . '.category.' . (int) $item->catid) && $item->created_by == $user->id; | ||
|
|
||
| // Check the category core.edit permissions. | ||
| return $canEditOwn || $user->authorise('core.edit', $this->option . '.category.' . (int) $item->catid); |
There was a problem hiding this comment.
Can you save that in a variable before? That looks really not nice ;-)
There was a problem hiding this comment.
what variable? you want a $canEdit ? is it really needed .... ?
There was a problem hiding this comment.
Just my opinion :) That return statement is not good readable imo.
Btw. Thank you for your great work!
There was a problem hiding this comment.
the idea is to only check authorize to core.edit if user cannot edit own.
There was a problem hiding this comment.
That's fine, but you could also save that to a variable ;-)
$canEdit = $canEditOwn || $user->..
return $canEdit; But as i said that's just my opinion :-)
There was a problem hiding this comment.
Personally I'd say don't change it. Unless it's going to improve readability or going to be reused I try to not create variables needlessly. This is a case where it's doing neither IMO. Of course, coding styles and opinions have a lot of things in common 😉
There was a problem hiding this comment.
i'm like @mbabker on this. if we don't use a variable i don't like to create it.
but yes is more a matter of coding style.
|
@andrepereiradasilva i get an SQL syntax error when i apply your patch. System tests also fail because of that
|
|
A comma is missing after a.created_by |
| $this->getState( | ||
| 'list.select', | ||
| 'a.id, a.title, a.alias, a.checked_out, a.checked_out_time, a.catid,' . | ||
| 'a.id, a.title, a.alias, a.checked_out, a.checked_out_time, a.catid, a.created_by ' . |
There was a problem hiding this comment.
ups sorry will correct
|
i've tested successfully |
|
OK here |
|
@alikon @infograf768 Thanks for testing, please use the issue tracker next time like on core :-) |
|
I have tested this item ✅ successfully on cfd842f This comment was created with the J!Tracker Application at issues.joomla.org/weblinks/255. |
|
Didn't even know we have a specific issue tracker for such project. |
|
will this be merged? And BTW when there will be a new weblinks release? |
|
// cc @chrisdavenport @rdeutz |
Pull Request for Issue joomla/joomla-cms#11466 (com_weblinks part).
Summary of Changes
The ACL core.edit.own is not working in com_weblinks.
This PR makes it work.
Testing Instructions
Also use the two users to do a general test with the com_weblinks edit permissions to confirm all is fine.
Documentation Changes Required
None.
Notes
This problem was discovered in GsoC 2016 Multilingual project.
This is very similiar with joomla/joomla-cms#11502 (com_newsfeeds) and joomla/joomla-cms#11503 (com_contact).