Minimize JArrayHelper methods toInteger, pivot, arrayUnique#8479
Minimize JArrayHelper methods toInteger, pivot, arrayUnique#8479rdeutz merged 3 commits intojoomla:stagingfrom
toInteger, pivot, arrayUnique#8479Conversation
…using Joomla\Utilities\ArrayHelper internally. Leaving (reverting from joomla#7782) other four methods as is for b/c reasons as mentioned in joomla#8455.
|
@izharaazmi sure it makes sense #8455 is a revert of #7782, we revert the full PR but there where some good changes in it (#7782) and we should merge them. |
|
@rdeutz But In the changes (diff) I see it is not comparing to latest staging branch content, i.e. after the revert I though diff should show up new differences. Am I missing something? |
|
Oh I just updated my knowledge and I understand how it works. I was just thinking the wrong way :) |
|
@izharaazmi you're welcome! |
|
I have tested this item ✅ successfully on 3a8878e This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8479. |
|
I have tested this item ✅ successfully on 3a8878e This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8479. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8479. |
|
@izharaazmi Can you rebase this please? |
…using Joomla\Utilities\ArrayHelper internally. Leaving (reverting from joomla#7782) other four methods as is for b/c reasons as mentioned in joomla#8455.
376f090 to
802ce7c
Compare
|
@wilsonge Done. Please verify. |
| * @return array | ||
| * | ||
| * @see https://secure.php.net/manual/en/function.array-unique.php | ||
| * @see http://php.net/manual/en/function.array-unique.php |
There was a problem hiding this comment.
This should stay to be https or do we have any reason to set it to http?
There was a problem hiding this comment.
|
Setting back to RTC as it was just a rebase @wilsonge This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8479. |
Back to https after #8479
…omla#8479) * Minimize JArrayHelper methods `toInteger`, `pivot`, `arrayUnique` by using Joomla\Utilities\ArrayHelper internally. Leaving (reverting from joomla#7782) other four methods as is for b/c reasons as mentioned in joomla#8455. * Minimize JArrayHelper methods `toInteger`, `pivot`, `arrayUnique` by using Joomla\Utilities\ArrayHelper internally. Leaving (reverting from joomla#7782) other four methods as is for b/c reasons as mentioned in joomla#8455.
…omla#8479) * Minimize JArrayHelper methods `toInteger`, `pivot`, `arrayUnique` by using Joomla\Utilities\ArrayHelper internally. Leaving (reverting from joomla#7782) other four methods as is for b/c reasons as mentioned in joomla#8455. * Minimize JArrayHelper methods `toInteger`, `pivot`, `arrayUnique` by using Joomla\Utilities\ArrayHelper internally. Leaving (reverting from joomla#7782) other four methods as is for b/c reasons as mentioned in joomla#8455.
Minimize JArrayHelper methods
toInteger,pivot,arrayUniqueby usingJoomla\Utilities\ArrayHelperinternally.Leaving (reverting from #7782) other four methods as it was originally for b/c reasons as mentioned in #8455.
Thanks @rdeutz