Skip to content

Move modals to Bootstrap#4562

Closed
dgrammatiko wants to merge 56 commits intojoomla:stagingfrom
dgrammatiko:admin_menu_module_modals
Closed

Move modals to Bootstrap#4562
dgrammatiko wants to merge 56 commits intojoomla:stagingfrom
dgrammatiko:admin_menu_module_modals

Conversation

@dgrammatiko
Copy link
Copy Markdown
Contributor

@dgrammatiko dgrammatiko commented Oct 12, 2014

Move modals from mootools to Bootstrap

This is the last (I hope) PR to get all back end using bootstrap modals. The rest are: #4513 #4514 #4561.

Testing:

Apply patch and follow the images below to see where you should focus:

administrator/index.php?option=com_menus&view=menus
screenshot 2014-10-12 06 35 39

screenshot 2014-10-12 06 35 53

administrator/index.php?option=com_menus&view=item&layout=edit&id=101
screenshot 2014-10-12 06 36 12
screenshot 2014-10-12 06 36 24

screenshot 2014-10-12 06 36 36
screenshot 2014-10-12 06 36 46
———————

@dgrammatiko
Move modals to Bootstrap
b1359bd 
Menus, modules, field moduleposition
This was referenced Oct 12, 2014
Closed
Closed
Closed
@Fedik
Copy link
Copy Markdown
Member

Fedik commented Oct 12, 2014

@DGT41 you mixed here a two pull request, for remove mootools from editing page, and replace the old modal to bootstrap.modal ...

problem that you copy #4517 partially ... I think, maybe you need or do a whole copy (and I will close old), or do separately

@dgrammatiko
Copy link
Copy Markdown
Contributor Author

dgrammatiko commented Oct 12, 2014

I will revert the js part on my PR, so leave this PR open. Mootools code is back

@dgrammatiko
Copy link
Copy Markdown
Contributor Author

dgrammatiko commented Oct 12, 2014

Reuse a language string for Menu Item Type:
screenshot 2014-10-12 20 10 22

@dgrammatiko dgrammatiko mentioned this pull request Oct 12, 2014
Closed
dgrammatiko and others added 19 commits October 13, 2014 04:08
@dgrammatiko
Revert Jquery changes
6df04d3
@dgrammatiko
better title
c0d974a
@dgrammatiko
[Code Style] administrator/components/com_admin
a883bc1
@phproberto @dgrammatiko
[code style] com_modules backend
0ecf330
@roland-d @dgrammatiko
[Code Style]Clean up libraries/joomla/access
a509796
@roland-d @dgrammatiko
[Code Style]Clean up libraries/joomla/application
1f791b6
@roland-d @dgrammatiko
[Code Style]Clean up libraries/joomla/http
b6fde87
@roland-d @dgrammatiko
[Code Style]Clean up libraries/joomla/language
18660b0
@roland-d @dgrammatiko
[Code Style]Clean up libraries/joomla/object
b03d4d5
@roland-d @dgrammatiko
[Code Style]Clean up libraries/joomla/openstreetmap
ef89798
@dgrammatiko
[Code Style] mod_mod_random_image : various codestyle fixes. Closes #…
bbe097e 
…4574
@roland-d @dgrammatiko
[Code Style]Clean up libraries/joomla/session
cbb8345
@dgrammatiko
[Code Style] administrator/components/com_joomlaupdate
b322612
@dgrammatiko
[Code Style] mod_finder : Various changes
29a4de9
@dgrammatiko
[Code Style] administrator/components/com_login
70180ee
@dgrammatiko
[Code Style] mod_search : Various changes
ba4487e
@wilsonge @dgrammatiko
Fix com_contact frontend codestyle
0f8aa50
@wilsonge @dgrammatiko
Fix code style issue
b13cfa0
@dgrammatiko
[Code Style] mod_quickicon : Various changes
46809a2
roland-d and others added 24 commits October 13, 2014 04:29
@roland-d @dgrammatiko
[Code Style]Clean up libraries/joomla. Fixes #4587. Fixes #4586. Fixes …
60ab6a8 
…#4585. Fixes #4583. Fixes #4581. Fixes #4572. Fixes #4568

[Code Style]Clean up libraries/joomla/updater

[Code Style]Clean up libraries/joomla/twitter

[Code Style]Clean up libraries/joomla/table

[Code Style]Clean up libraries/joomla/string

[Code Style]Clean up libraries/joomla/filter

[Code Style]Clean up libraries/joomla/image
@roland-d @dgrammatiko
[Code Style]Clean up libraries/cms. Fixes #4593. Fixes #4596. Fixes #…
9067e1a 
…4598. Fixes #4599. Fixes #4602. Fixes #4604
@roland-d @dgrammatiko
[Code Style]Clean up libraries/legacy. Fixes #4635
30c1e73
@roland-d @dgrammatiko
[Code Style]Clean up com_redirect backend. Fixes #4609
5b1d99e
@roland-d @dgrammatiko
[Code Style]Clean up libraries/joomla, com_banners & com_config. Fixes …
9834e9f 
…#4588. Fixes #4616. Fixes #4615

[Code Style]Clean up com_banners frontend.

[Code Style]Clean up com_config frontend.
@dgrammatiko
[Code Style] com_newsfeeds : Various changes
4e9bb9c
@dgrammatiko
[Code Style] bin : Various changes
e63674d
@dgrammatiko
Relax requirement for a package tag in class doc blocks
7798c2d
@dgrammatiko
[Code Style] installation
857f50c
@dgrammatiko
[Code Style] administrator/components/com_contact. Fixes #4539
dc51080 
[Code Style] Changes "articles" to "contacts" in several places.
@dgrammatiko
[Code Style] administrator/components/com_finder. Fxies #4564
00269b0
@dgrammatiko
[Code Style] administrator/components/com_installer. Fixes #4576
faec5d7
@dgrammatiko
[Code Style] administrator/components/com_languages. Fixes #4605
c949769
@dgrammatiko
[Code Style] administrator/components/com_plugins. Fixes #4611
fc1ddc8
@dgrammatiko
[Code Style] administrator/components/com_cache. Fixes #4620
20fa608
@dgrammatiko
Move modals to Bootstrap
84eb402 
Menus, modules, field moduleposition
@b2z @dgrammatiko
Fix tag's view meta description
ad2fa5f
@b2z @dgrammatiko
Fix also tags' view meta description
fc1f603
@b2z @dgrammatiko
Fix all tags menu item metadata
a6c3883
@810 @dgrammatiko
[imp] Template isis: Fix small subhead issue
ec5d833
@phproberto @dgrammatiko
[fix] search tools open by default. Fixes #4510
1ab500e
@infograf768 @dgrammatiko
Updatinh sk-SK installation language file
fcbbfdc
@infograf768 @dgrammatiko
cs error on merge
f659d1c
@dgrammatiko
Revert "Move modals to Bootstrap"
791aa74 
This reverts commit 84eb402.
@dgrammatiko dgrammatiko mentioned this pull request Oct 13, 2014
Closed
@Bakual
Copy link
Copy Markdown
Contributor

Bakual commented Oct 13, 2014

You apparently rebased the wrong way around. You added the commits from staging after your own commits instead of replaying them on top of them.
I did that several times until I figured out how to do it correctly 😄

@dgrammatiko
Copy link
Copy Markdown
Contributor Author

dgrammatiko commented Oct 13, 2014

Now I know 😃 I use Git Tower which is the best for dumb people but I guess still is not bullet proof 😉

@dgrammatiko dgrammatiko mentioned this pull request Jan 20, 2015
Closed
@zero-24 zero-24 mentioned this pull request Aug 3, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.