[Code Style]Clean up com_redirect backend.#4609
Closed
roland-d wants to merge 1 commit intojoomla:stagingfrom
Closed
[Code Style]Clean up com_redirect backend.#4609roland-d wants to merge 1 commit intojoomla:stagingfrom
roland-d wants to merge 1 commit intojoomla:stagingfrom
Conversation
Contributor
There was a problem hiding this comment.
I think we have to do the same I did in phproberto@69668fa for my #4569 PR
I would:
- Create a new method called
statusorstate - As
$iis supposed to be the row number maybe we should use0but I can also change my PR to use null. We just need to be consistent. - On the new function
$canChangedefault value should befalsewithout doubts. I think allowing by defaul is not a good way. - Replace any
JHtml::_('redirect.published'...call to point to the new functionJHtml::_('redirect.status'...changing the parameters order. I think$ishould be the first parameter because not adding it would break all the list behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Code Style]Clean up com_redirect backend.