Move content history to bs modal by dgrammatiko · Pull Request #4561 · joomla/joomla-cms

dgrammatiko · 2014-10-12T00:16:28Z

Same as #4513 and #4514 but for content history

Content history is currently using mootools modal.
Without affecting in anyway the logic of the field we can use jQuery and bootstrap.

B/C
Should be 100% compatible

Testing:

Go to administrator -> Banners -> create a new banner
change the alternative text and save it again
repeat the last part for few more times

press the versions button
Everything should be ok

Before:

After:

Same as #4513 and 4514 but for content history Content history is currently using mootools modal. Without affecting in anyway the logic of the field we can use jQuery and bootstrap. B/C Should be 100% compatible Test: Apply the patch Go to administrator -> Banners -> create a new banner change the alternative text and save it again repeat the last part for few more times press the versions button Everything should be ok

dgrammatiko · 2014-10-12T17:08:50Z

Proposed title:

infograf768 · 2014-10-13T09:03:06Z

Why:

-       JHtml::_('behavior.modal', 'a.modal_jform_contenthistory');
-
+       JHtml::_('bootstrap.modal');
+
+       $lang = JFactory::getLanguage();
+       $extension = 'com_contenthistory';
+       $base_dir = JFactory::getApplication()->isAdmin() ? JPATH_ADMINISTRATOR : JPATH_SITE;
+       $language_tag = $lang->getName();
+       $reload = true;
+       $lang->load($extension, $base_dir, $language_tag, $reload);

which is anyway wrong as you should use $lang->getTag(); instead of $lang->getName();

infograf768 · 2014-10-13T10:14:06Z

Hmm, found out that we indeed have to reload language to get the modal title translated.
Not sure we need to check the $app and else as anyway the language file is only in admin
so we only need:

$lang = JFactory::getLanguage();
$lang->load('com_contenthistory', JPATH_ADMINISTRATOR, $lang->getTag(), true);

Fedik · 2014-10-13T10:18:53Z

layouts/joomla/toolbar/versions.php

I think you will get problem with approval, with such things ... problem:

use the inline css, that repeats in different files

use !important

This make problems for support this code in future.
I think better make some 'unified' styling for the modal in the template style

I agree strongly with @Fedik. Don't use inline styles and especially no !Important. I will personally redirect all complaints from template designers to you and share your home address with them 😄

@Bakual Hmmm thats a nice way to make new customers 😃. @Fedik Actually this code is a quick hack which once we do some changes in less files won’t be needed. i pushed the changes here and at the media field and user field. Will do it for all.

One more think to get 100% B/C is needed here:
I removed the moo tools modal close code SqueezeBox.close(); and replaced it with jQuery("#userModal").modal("hide”); Best practice I think is to proxy the old function to the new if SqueezeBox is not defined. Some JS guru for this? @Fedik ?

@infograf768

thanks @infograf768

Fedik · 2014-10-13T15:02:28Z

@DGT41 I am not guru, and for me jQuery("#userModal").modal("hide”); is good 😄

another notice:
you use JHtmlBootstrap::renderModal
but better do it in Joomla! way JHtml::_('bootstrap.renderModal', $selector, $params , $footer)
example your:

JHtmlBootstrap::renderModal('versionsModal', array( 'url' => $link, 'title' => $label ,'height' => '600px', 'width' => '800px'), '');

will become:

JHtml::_('bootstrap.renderModal',  'versionsModal', array( 'url' => $link, 'title' => $label ,'height' => '600px', 'width' => '800px'));

trangredweb · 2014-10-17T04:46:46Z

@test

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4561.

mrunalpittalia · 2014-10-17T11:31:57Z

@tested Succesfully

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4561.

mrunalpittalia · 2014-10-17T11:32:38Z

moving to RTC as we have more that 2 successful tests

mrunalpittalia · 2014-10-17T11:33:31Z

moving to RTC as we have more than 2 successful tests

dgrammatiko · 2014-10-17T14:19:30Z

The PRs regarding Media Field, User Field and Content History are also used in the front end. That might break the rendered design IF THE TEMPLATE is not BOOTSTRAP compatible. (the old modal uses it’s own css file). I wrote it!

dgrammatiko · 2014-10-17T17:24:46Z

For B/C I reverted the option to use the mootools modal in front end. Lets NOT break every site out there.
Please test again

dgrammatiko · 2014-10-19T16:05:16Z

Will try again when #3231 is committed

jissues-bot added the PR-staging label Oct 12, 2014

This was referenced Oct 12, 2014

Align Version button with Save / Cancel on front-end edit. #4369

Closed

Move modals to Bootstrap #4562

Closed

Messages modal converted to Bootstrap #4563

Closed

Multilanguage module uses mootools modal #4575

Closed

Move media field to bs modal #4513

Closed

dgrammatiko added 2 commits October 12, 2014 20:01

Title change and code fixes

e55364f

Cleanup

ef9edbd

dgrammatiko mentioned this pull request Oct 12, 2014

Templates modal converted to bootstrap #4645

Closed

dgrammatiko added 2 commits October 13, 2014 01:24

Front end editing modals

969d1d6

content, weblinks history modal + modal for article url

7b5d84a

Fedik reviewed Oct 13, 2014
View reviewed changes

dgrammatiko added 2 commits October 13, 2014 16:43

Remove injected CSS + lang code improve

cd347a8

thanks @infograf768

missed one

b4e084b

dgrammatiko mentioned this pull request Oct 13, 2014

Move com_menus modals to Bootstrap #4661

Closed

Bad precision setting in php

f6d6a1e

dgrammatiko mentioned this pull request Oct 14, 2014

Move plugins modals to Bootstrap #4664

Closed

Remove the crap that was pushed in the css

3350991

nicksavov added the PBF14 label Oct 16, 2014

Use mootools modal in front end

6b16e43

dgrammatiko closed this Oct 19, 2014

dgrammatiko mentioned this pull request Jan 9, 2015

Versions using layouts and bootstrap #5654

Merged

dgrammatiko deleted the content_history branch January 20, 2015 01:00

dgrammatiko mentioned this pull request Jan 20, 2015

RFC Possible regression on modals!!! #5832

Closed

zero-24 mentioned this pull request Aug 3, 2015

Backport Messages modal converted to bootstrap #7624

Closed

Uh oh!

Conversation

dgrammatiko commented Oct 12, 2014

Uh oh!

dgrammatiko commented Oct 12, 2014

Uh oh!

infograf768 commented Oct 13, 2014

Uh oh!

infograf768 commented Oct 13, 2014

Uh oh!

Fedik Oct 13, 2014

Choose a reason for hiding this comment

Uh oh!

Bakual Oct 13, 2014

Choose a reason for hiding this comment

Uh oh!

dgrammatiko Oct 13, 2014

Choose a reason for hiding this comment

Uh oh!

dgrammatiko Oct 13, 2014

Choose a reason for hiding this comment

Uh oh!

Fedik commented Oct 13, 2014

Uh oh!

trangredweb commented Oct 17, 2014

Uh oh!

mrunalpittalia commented Oct 17, 2014

Uh oh!

mrunalpittalia commented Oct 17, 2014

Uh oh!

mrunalpittalia commented Oct 17, 2014

Uh oh!

dgrammatiko commented Oct 17, 2014

Uh oh!

dgrammatiko commented Oct 17, 2014

Uh oh!

dgrammatiko commented Oct 19, 2014

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants