Move media field to bs modal#4513
Move media field to bs modal#4513dgrammatiko wants to merge 22 commits intojoomla:stagingfrom dgrammatiko:media_field_bs_modal
Conversation
|
The styling on this is off, there is a size issue with white space at the bottom AND there is now the word Select at the top beforeafter
|
|
Before: Now it should act exactly as the old modal + now it is responsive |
|
Why have you added the title Select or upload an image?
|
|
Bootstrap modal needs a title: http://getbootstrap.com/2.3.2/javascript.html#modals |
|
@Infograf thought s on adding another string etc
|
|
@brianteeman |
|
@Bakual how can I solve this:
|
|
That's very likely due to our friends from the codestyle sprint 😄 What you need to do is update your branch https://github.com/dgt41/joomla-cms/tree/media_field_bs_modal to current staging and resolve any conflicts that may have occured. There are two possible ways of getting the branch updated:
|
|
@test, it works fine. |
|
Moving to RTC as issue patch more than 2 successfull tests |
|
@Bakual and the rest of the PLT: The PRs regarding Media Field, User Field and Content History are also used in the front end. That might break the rendered design IF THE TEMPLATE is not BOOTSTRAP compatible. (the old modal uses it’s own css file). I wrote it! |
|
For B/C I reverted the option to use the mootools modal in front end. Lets NOT break every site out there. |
I'm sorry to say, but if it's going to break templates that worked fine before, then this will obviously not pass. We will need a different approach then. |
|
I closed all 4 requests that infect also the front end. I will do them again as soon as #3231 is committed! Better safe than sorry… |
Select image field (field type media) is using mootools modal.
Without affecting in anyway the logic of the field we can use jQuery and bootstrap.
This needs some visual fixes as the rendered modal needs some css to get to a more appropriate size.
Feel free to submit some ideas or code!
B/C
Should be 100% compatible
Test:
Apply the patch
Go to administrator -> global configuration
and check the functionality of Offline image.
Everything should be ok
(except the size of the modal)