Move user field to bs modal#4514
Move user field to bs modal#4514dgrammatiko wants to merge 11 commits intojoomla:stagingfrom dgrammatiko:user_field_bs_modal
Conversation
Same as #4513 but for User User select field (field type user) is using mootools modal. Without affecting in anyway the logic of the field we can use jQuery and bootstrap. B/C Should be 100% compatible Test: Apply the patch Go to administrator -> Banners -> create a new banner and check the functionality of created by in publishing tab Everything should be ok
|
As far as I can see this doesnt work correctly as I dont get the User Group filter beforeafter
|
|
Also this PR changes the styling of the button ##before #after
|
|
@brianteeman I corrected the button appearance, but for the group list I need some more time |
|
Before: After: |
|
Why have you added the title Select User?
|
|
@test It work for me |
|
@test |
|
Multiple good tests - setting to RTC |
|
@brianteeman and the rest of the PLT: The PRs regarding Media Field, User Field and Content History are also used in the front end. That might break the rendered design IF THE TEMPLATE is not BOOTSTRAP compatible. (the old modal uses it’s own css file). I wrote it! |
|
For B/C I reverted the option to use the bootstrap modal in front end. Lets NOT break every site out there. |
|
@wilsonge @phproberto Can we move this user field (as well as the media and contenthistory) to layout? It will be a lot easier and cleaner to do an override... |
|
Of course we can! The plan is to do it for all form fields as soon as possible. |
|
@wilsonge is there anything I can use as guide to try and do those myself? |
|
Get the JLayouts looking in a similar way to the code here #3231 - me and @phproberto are still finalising the layout the renderer itself because we want to have a shared renderer between new MVC and these form fields. But just moving it into a Layout will get us 99% of the way there |
|
Closing this one. Will try again when #3231 is committed |
Same as #4513 but for User
User select field (field type user) is using mootools modal.
Without affecting in anyway the logic of the field we can use jQuery and bootstrap.
B/C
Should be 100% compatible
Test:
Apply the patch
Go to administrator -> Banners -> create a new banner
and check the functionality of created by in publishing tab
Everything should be ok