This PR contains unrelated stuff concerning banners

@infograf768 That was a mistake, now PR should be safe

It seems that you added the CSS to the template.css files directly. You should work on the template.less files and then generate the css files.

You can do it from the build folder running:

cd build
php generatecss.php

And same for RTL changes

@phproberto
As far as I could see, the PR used generatecss.
The changes in the css files comes from the changes in the
/media/jui/less/modals.joomla.less
and
media/jui/less/modals.less

@test now It's been modal bootstrap but I got width of modal too large

@suscess


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4563.

@suredweb The width has been setup globally for all modals. We could override the width for this modal. But the question is: does it worth it?

All good. Are we able to place the buttons in the bottom like Bootstrap prescribe?

@losedk Nice idea, I also try to do that as it only requires to put this part that renders the buttons https://github.com/joomla/joomla-cms/pull/4563/files#diff-1caf6f6c420934f653cb344972c49abbR29 in the footer. The only problem is that in the current short-code for bootstrap modals in the toolbar this is not yet implemented: in current implementation the footer part doesn’t exist https://github.com/joomla/joomla-cms/blob/staging/libraries/cms/toolbar/button/popup.php#L46. I’ll make a PR for that, if it get’s accepted we can move them easily in the footer area! Thanks for bringing this up, I totally forgot it 😉

@DGT41 Great. Just ping me, when you have something! :)

Hathor view:

Is this PR outdated - its hard to tell

Can this considered RTC? @roland-d ?

@test works fine, but can you change the buttons like @losedk suggested a few messages above?

@DGT41 Sure. Give me a minute

@DGT41 Issues:

Responsive:

Hidden tooltip on the first label (possibly not the only place then):

Large button:

The success button is inheriting the large width from the toolbar. Perhaps we should change this globally so the button isn't so big in the modals?

Hathor:

Missing an icon

@losedk Thanks, I just fixed the mobile weird behavior. About Hathor there is <span class="icon-32-cog"></span> which should load the icon but obviously the icon doesn’t exist and I am not the best bet to design an icon

@DGT41 What about?

@losedk where can i find that button (i mean which view)?

@losedk I manage to do it! please retest?

Could you add it to the stylesheet instead?

Done!

@DGT41 All good now!

Moved here

@DGT41 we need the CSS / hathor stuff still in the core 😄

Can you just remove the messages part and let the css / hathor stuff there?

@zero-24 ok

Thanks @DGT41 I'm going to move this now to RTC 👍

As it is planned to remove messages with 3.5 (http://developer.joomla.org/news/616-meeting-notes-from-jab-plt-summit-2015.html) We need this here and also https://github.com/joomla-extensions/messages/issues/7 to fix the issue 😄

Thank you @DGT41! Merged in the 3.5-dev branch (fa39ddc).