Redo of #4563#8173
Merged
rdeutz merged 5 commits intojoomla:stagingfrom Oct 27, 2015
dgrammatiko:____redoMessagesModal
Merged
Conversation
Contributor
|
Thanks @DGT41 see: https://github.com/dgt41/joomla-cms/pull/24 for Travis. ;) |
Contributor
|
I have tested this item ✅ successfully on 431b8ea This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8173. |
|
@test Tested successfully with staging 2015-10-25 ✅ |
Contributor
|
Thanks @bertmert if @DGT41 gets the time to fix Travis (merging my PR or do it with a similiar commit we can RTC it for 3.4.6 This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8173. |
Codestyle & Doc Block
|
This PR has received new commits. This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8173. |
Contributor
|
RTC 😃 Thanks. This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8173. |
Contributor
Author
|
@zero-24 thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR #4563 was broken into two parts
in order to get it merged in the messages repo. But that didn’t happen so I just did that missing part here.
In short this PR drops the mootools modal for the config modal of the component messages.
To test simply check that the modal still operates and the configuration gets saved in com_messages