Skip to content

[Code Style] mod_mod_random_image : varioous codestyle fixes#4574

Closed
marcodings wants to merge 36 commits intojoomla:stagingfrom
marcodings:mod_random_image
Closed

[Code Style] mod_mod_random_image : varioous codestyle fixes#4574
marcodings wants to merge 36 commits intojoomla:stagingfrom
marcodings:mod_random_image

Conversation

@marcodings
Copy link
Copy Markdown
Contributor

[Code Style] mod_mod_random_image : varioous codestyle fixes

marco and others added 30 commits October 11, 2014 20:34
Replace php trim method with JFilterInput TRIM filter to deal with non-breaking and multibyte spaces
Suppose you have a web server using Joomla where this web server is both reachable via http://www.example.org/ and http:/example.org/. With the current implementation of the redirection plugin you need to define two redirections within the redirect manager component for every page you want to automatically redirect from its old location to its new location:

old page: http://www.example.org/path/to/old/page.html
=> new page: http://www.example.org/path/to/new/page.html

old page: http://example.org/path/to/old/page.html
=> new page: http://example.org/path/to/new/page.html

With my proposed file change it would be sufficient to define only one redirection in this case:

old server-relative page: /path/to/old/page.html
=> new server-relative page: /path/to/new/page.html

line 75: tabs removed

check redirect found whether published
…en its value is 0). Fixes #4488. Closes #3725 (reverted from commit 4c7cd15)
#4221 was incorrectly using str_replace() to remove the default language
code when needed. As str_replace acts globally on the subject, the
language code was removed also out of context (e.g. when part of an
alias).

With this PR I use instead preg_replace with the limit of one
substitution. due to the fact that the /language-code string to be
replaced appears just after the host name and cannot be part of it (due
to the/), this should guarantee the correct replacements of the language
code only.

I took the occasion to make a bit of clean-up by aggregating some
redundantly duplicated code
Codestyle fixes for plugins

Cleanup PR
@Bakual Bakual closed this in a5d3fd3 Oct 12, 2014
@marcodings marcodings deleted the mod_random_image branch October 12, 2014 09:53
rdeutz pushed a commit to rdeutz/joomla-cms that referenced this pull request Oct 24, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.