[#25616] Delete URL-Parameter limitstart (also when its value is 0)#3725
Closed
AlexanderMeier wants to merge 1 commit intojoomla:stagingfrom
Closed
[#25616] Delete URL-Parameter limitstart (also when its value is 0)#3725AlexanderMeier wants to merge 1 commit intojoomla:stagingfrom
AlexanderMeier wants to merge 1 commit intojoomla:stagingfrom
Conversation
osmetic change for consistence and avoidance of duplicate URLs. See also this Bug report: http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=25616&start=0 Before change $limitstart was deleted if present, except if it was 0 (zero), because 0 evaluates to false.
hikashop-jerome
added a commit
to hikashop-jerome/joomla-cms
that referenced
this pull request
Sep 29, 2014
Instead of removing the "limitstart" parameter in the router file (see joomla#3725 ), we do not generate URLs with "limitstart=0". Kind of weird to add it there to be then removed in the router, isn't it? So components will be able to use the parameter "limitstart=0" if they want to... and we still avoid the duplicate url issue we used to have. Sounds like a win / win! :)
Bakual
pushed a commit
to Bakual/joomla-cms
that referenced
this pull request
Oct 8, 2014
… value is 0). Closes joomla#3725 (reverted from commit 4c7cd15)
rdeutz
pushed a commit
to rdeutz/joomla-cms
that referenced
this pull request
Oct 24, 2014
…en its value is 0). Fixes joomla#4488. Closes joomla#3725 (reverted from commit 4c7cd15)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cosmetic change for consistence and avoidance of duplicate URLs.
See also this Bug report: http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=25616&start=0
Before change $limitstart was deleted if present, except if it was 0 (zero), because 0 evaluates to false.