Skip to content

Remove Mootools usage in com_menu#4517

Merged
infograf768 merged 5 commits intojoomla:stagingfrom
Fedik:mootools-from-menus-edit
Oct 22, 2014
Merged

Remove Mootools usage in com_menu#4517
infograf768 merged 5 commits intojoomla:stagingfrom
Fedik:mootools-from-menus-edit

Conversation

@Fedik
Copy link
Copy Markdown
Member

@Fedik Fedik commented Oct 11, 2014

Remove Mootools usage in com_menu
additionally to #4475

Test
apply path and make sure that menu (and menu items) editing in the com_menu still works 😄

@brianteeman
Copy link
Copy Markdown
Contributor

Setting to RTC - thanks for testing

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4517.

@infograf768
Copy link
Copy Markdown
Member

Mootools still loaded here

@Fedik
Copy link
Copy Markdown
Member Author

Fedik commented Oct 20, 2014

@infograf768 yes right, because it required by the modal script that used for select the article (example),
and JHtml::_('behavior.formvalidation'); still call mootools, this part hope will be fixed by related pull #4475

maybe I made a bad description,
this pull remove mootools usage in the menu editing template, but some fields that on this page still can load mootools

@dgrammatiko
Copy link
Copy Markdown
Contributor

@infograf768 @Fedik Also the toolbar buttons have hard coded call to mootools #4475 takes care of that but needs some fixes on unit tests (the old behavior.core was injecting mt, the new is not…). As it is right now I realize that is quite hard to review and test it, so I will break it in more parts so it will be easier to reviewed and tested 😃

@infograf768
Copy link
Copy Markdown
Member

Shall we then merge this one as it solves the validation ?

@infograf768 infograf768 added this to the Joomla! 3.3.7 milestone Oct 22, 2014
infograf768 added a commit that referenced this pull request Oct 22, 2014
@infograf768 infograf768 merged commit ccc3615 into joomla:staging Oct 22, 2014
@dgrammatiko
Copy link
Copy Markdown
Contributor

@infograf768 Hathor seems to have overrides for all these views https://github.com/joomla/joomla-cms/blob/staging/administrator/templates/hathor/html/com_menus/item/edit.php#L48-L76

Shall we change that as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants