WEBDEV-8464 Make ia-dropdown-search-bar propagate selection changes immediately#46
Merged
Merged
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #46 +/- ##
==========================================
+ Coverage 78.56% 78.75% +0.19%
==========================================
Files 16 16
Lines 639 645 +6
Branches 165 168 +3
==========================================
+ Hits 502 508 +6
Misses 95 95
Partials 42 42 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rebecca-shoptaw
approved these changes
May 19, 2026
rebecca-shoptaw
left a comment
Collaborator
There was a problem hiding this comment.
Nice workaround, and helpful explanation!
jbuckner
added a commit
that referenced
this pull request
May 28, 2026
* origin/main: (28 commits) WEBDEV-8518: Add CI caching and standardize workflow hygiene (#55) WEBDEV-8464 Make ia-dropdown-search-bar propagate selection changes immediately (#46) WEBDEV-8447 Upgrade ia-dropdown version to address z-index bug (#45) v0.2.5 (#44) WEBDEV-8378 Migrate dropdown-style search bar from Offshoot (#41) 0.2.3 (#43) WEBDEV-8393 Add full OTP form (#42) WEBDEV-8327 Add basic OTP input (#40) Update instructions for adding component stories (#38) Demo page enhancements WEBDEV-8131 Encapsulate property settings (#36) WEBDEV-8167: Add demo and publishing sections to readme (#35) 0.2.2 WEBDEV-8162: Support Lit 2/3, Combobox fixes (#34) 0.2.1 WEBDEV-8151: Improve build compatibility (#32) v0.2.0 (#31) WEBDEV-8119 Add basic combo-box component (#24) Update npm-publish workflow Update npm-publish action ... # Conflicts: # demo/app-root.ts # demo/story-template.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently for
<ia-dropdown-search-bar>, if one resets theselectedCategoryproperty directly after a dropdown option is selected, the change does not propagate down to the inner ia-dropdown component via Lit's usual update cycle due to the property-binding diff seeing no change. This PR just propagates the new value immediately viawillUpdateto ensure the same change is seen by every component in the tree.