Skip to content

WEBDEV-8131 Encapsulate property settings#36

Merged
rebecca-shoptaw merged 14 commits into
mainfrom
webdev-8131-encapsulate-property-settings
Mar 9, 2026
Merged

WEBDEV-8131 Encapsulate property settings#36
rebecca-shoptaw merged 14 commits into
mainfrom
webdev-8131-encapsulate-property-settings

Conversation

@rebecca-shoptaw

Copy link
Copy Markdown
Collaborator

Encapsulates property settings for easy reuse, which can be extended gradually to be used for i.e. ia-combo-box and other more complicated components.

Also extracts property settings and style settings out of the story-template and encapsulates exampleUsage inside template (with the option to override)

@github-actions

github-actions Bot commented Feb 27, 2026

Copy link
Copy Markdown
PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-03-09 19:00 UTC

@codecov-commenter

codecov-commenter commented Feb 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.41%. Comparing base (92c532d) to head (106baa7).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #36   +/-   ##
=======================================
  Coverage   86.41%   86.41%           
=======================================
  Files           7        7           
  Lines         368      368           
  Branches       90       90           
=======================================
  Hits          318      318           
  Misses         24       24           
  Partials       26       26           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bfalling bfalling left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

** Redacted Claude-generated single-post code review here in favor of having it post inline **

@bfalling bfalling left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inline code review comments below. (via Claude)

Comment thread demo/story-components/story-prop-settings.ts
Comment thread demo/story-components/story-styles-settings.ts Outdated
Comment thread demo/story-components/story-prop-settings.ts
Comment thread demo/story-template.ts Outdated
Comment thread demo/story-template.ts
Comment thread demo/story-template.ts
Comment thread demo/story-components/story-prop-settings.ts
Comment thread README.md
Comment thread demo/story-template.ts
Comment thread demo/story-components/story-prop-settings.ts
@rebecca-shoptaw rebecca-shoptaw requested a review from bfalling March 5, 2026 16:37
Comment thread demo/story-components/story-prop-settings.ts Fixed
Comment thread demo/story-components/story-prop-settings.ts Fixed

@bfalling bfalling left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rebecca-shoptaw rebecca-shoptaw merged commit 547c42c into main Mar 9, 2026
3 checks passed
@rebecca-shoptaw rebecca-shoptaw deleted the webdev-8131-encapsulate-property-settings branch March 9, 2026 18:59
jbuckner added a commit that referenced this pull request May 28, 2026
* origin/main: (28 commits)
  WEBDEV-8518: Add CI caching and standardize workflow hygiene (#55)
  WEBDEV-8464 Make ia-dropdown-search-bar propagate selection changes immediately (#46)
  WEBDEV-8447 Upgrade ia-dropdown version to address z-index bug (#45)
  v0.2.5 (#44)
  WEBDEV-8378 Migrate dropdown-style search bar from Offshoot (#41)
  0.2.3 (#43)
  WEBDEV-8393 Add full OTP form (#42)
  WEBDEV-8327 Add basic OTP input (#40)
  Update instructions for adding component stories (#38)
  Demo page enhancements
  WEBDEV-8131 Encapsulate property settings (#36)
  WEBDEV-8167: Add demo and publishing sections to readme (#35)
  0.2.2
  WEBDEV-8162: Support Lit 2/3, Combobox fixes (#34)
  0.2.1
  WEBDEV-8151: Improve build compatibility (#32)
  v0.2.0 (#31)
  WEBDEV-8119 Add basic combo-box component (#24)
  Update npm-publish workflow
  Update npm-publish action
  ...

# Conflicts:
#	demo/app-root.ts
#	demo/story-template.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants