WEBDEV-8378 Migrate dropdown-style search bar from Offshoot#41
Merged
Conversation
ba9c07c to
70df15a
Compare
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #41 +/- ##
==========================================
+ Coverage 77.55% 78.56% +1.00%
==========================================
Files 15 16 +1
Lines 606 639 +33
Branches 156 165 +9
==========================================
+ Hits 470 502 +32
Misses 95 95
- Partials 41 42 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jbuckner
reviewed
May 1, 2026
jbuckner
approved these changes
May 4, 2026
665e2e6 to
89a496c
Compare
5a83a83 to
1dec141
Compare
1dec141 to
f65177b
Compare
jbuckner
added a commit
that referenced
this pull request
May 28, 2026
* origin/main: (28 commits) WEBDEV-8518: Add CI caching and standardize workflow hygiene (#55) WEBDEV-8464 Make ia-dropdown-search-bar propagate selection changes immediately (#46) WEBDEV-8447 Upgrade ia-dropdown version to address z-index bug (#45) v0.2.5 (#44) WEBDEV-8378 Migrate dropdown-style search bar from Offshoot (#41) 0.2.3 (#43) WEBDEV-8393 Add full OTP form (#42) WEBDEV-8327 Add basic OTP input (#40) Update instructions for adding component stories (#38) Demo page enhancements WEBDEV-8131 Encapsulate property settings (#36) WEBDEV-8167: Add demo and publishing sections to readme (#35) 0.2.2 WEBDEV-8162: Support Lit 2/3, Combobox fixes (#34) 0.2.1 WEBDEV-8151: Improve build compatibility (#32) v0.2.0 (#31) WEBDEV-8119 Add basic combo-box component (#24) Update npm-publish workflow Update npm-publish action ... # Conflicts: # demo/app-root.ts # demo/story-template.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We currently have a search bar component in Offshoot that incorporates a built-in dropdown menu with search categories. We'd like to use this in contexts outside of Offshoot too, so we are migrating it into Elements.
The component has a custom
categoriesproperty defining what options to show in the dropdown, as well several further options like whether/how to show an Advanced Search link and whether to show its loading state. One may also omit the dropdown piece entirely to use it as a plain search bar if desired.Notably, this component presently depends on two other packages
@internetarchive/ia-dropdownand@internetarchive/ia-clearable-text-inputwhich are slated to eventually be migrated here as well.