Skip to content

WEBDEV-8327 Add basic OTP input#40

Merged
rebecca-shoptaw merged 11 commits into
mainfrom
webdev-8327-add-otp-input
Apr 30, 2026
Merged

WEBDEV-8327 Add basic OTP input#40
rebecca-shoptaw merged 11 commits into
mainfrom
webdev-8327-add-otp-input

Conversation

@rebecca-shoptaw

Copy link
Copy Markdown
Collaborator

Builds out a simple OTP input component (just the boxes and pasting/arrow key behavior), migrated from an existing Offshoot component.

Also expands the prop settings to support boolean and number props.

@github-actions

github-actions Bot commented Apr 29, 2026

Copy link
Copy Markdown
PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-04-30 18:35 UTC

@codecov-commenter

codecov-commenter commented Apr 29, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 77.35849% with 24 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.72%. Comparing base (1e05e3a) to head (890a14a).

Files with missing lines Patch % Lines
demo/story-components/story-prop-settings.ts 0.00% 10 Missing ⚠️
demo/story-template.ts 50.00% 5 Missing and 5 partials ⚠️
src/elements/ia-otp-input/ia-otp-input.ts 94.73% 0 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #40      +/-   ##
==========================================
+ Coverage   76.36%   77.72%   +1.35%     
==========================================
  Files          13       14       +1     
  Lines         495      579      +84     
  Branches      122      147      +25     
==========================================
+ Hits          378      450      +72     
- Misses         83       91       +8     
- Partials       34       38       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@latonv latonv left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Mostly just noted a couple of small nitpicks in the story settings.

Comment thread demo/story-components/story-prop-settings.ts Outdated
Comment thread demo/story-components/story-prop-settings.ts Outdated
Comment thread src/elements/ia-otp-input/ia-otp-input.ts
Comment thread src/elements/ia-otp-input/ia-otp-input.ts Outdated
@rebecca-shoptaw rebecca-shoptaw merged commit 9e65956 into main Apr 30, 2026
3 checks passed
@rebecca-shoptaw rebecca-shoptaw deleted the webdev-8327-add-otp-input branch April 30, 2026 18:34
jbuckner added a commit that referenced this pull request May 28, 2026
* origin/main: (28 commits)
  WEBDEV-8518: Add CI caching and standardize workflow hygiene (#55)
  WEBDEV-8464 Make ia-dropdown-search-bar propagate selection changes immediately (#46)
  WEBDEV-8447 Upgrade ia-dropdown version to address z-index bug (#45)
  v0.2.5 (#44)
  WEBDEV-8378 Migrate dropdown-style search bar from Offshoot (#41)
  0.2.3 (#43)
  WEBDEV-8393 Add full OTP form (#42)
  WEBDEV-8327 Add basic OTP input (#40)
  Update instructions for adding component stories (#38)
  Demo page enhancements
  WEBDEV-8131 Encapsulate property settings (#36)
  WEBDEV-8167: Add demo and publishing sections to readme (#35)
  0.2.2
  WEBDEV-8162: Support Lit 2/3, Combobox fixes (#34)
  0.2.1
  WEBDEV-8151: Improve build compatibility (#32)
  v0.2.0 (#31)
  WEBDEV-8119 Add basic combo-box component (#24)
  Update npm-publish workflow
  Update npm-publish action
  ...

# Conflicts:
#	demo/app-root.ts
#	demo/story-template.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants