WEBDEV-8119 Add basic combo-box component#24
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #24 +/- ##
===========================================
+ Coverage 68.42% 87.15% +18.73%
===========================================
Files 5 7 +2
Lines 57 366 +309
Branches 7 87 +80
===========================================
+ Hits 39 319 +280
- Misses 15 24 +9
- Partials 3 23 +20 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
12274bc to
31b9185
Compare
latonv
commented
Jan 22, 2026
latonv
commented
Jan 22, 2026
latonv
commented
Jan 22, 2026
jbuckner
reviewed
Jan 26, 2026
jbuckner
reviewed
Jan 26, 2026
jbuckner
left a comment
Collaborator
There was a problem hiding this comment.
This looks really nice! 👏
Since this is going into production pretty soon, what do you think of moving it out of labs and into the main elements section?
jbuckner
reviewed
Jan 26, 2026
jbuckner
reviewed
Jan 26, 2026
ab293f4 to
6fbb3ce
Compare
jbuckner
reviewed
Jan 27, 2026
rebecca-shoptaw
approved these changes
Jan 27, 2026
rebecca-shoptaw
left a comment
Collaborator
There was a problem hiding this comment.
Looking great! One note re: possible CSS structure to avoid too many variables (and any in :host that aren't also reflect in theme-styles.ts which I feel should be our standard).
jbuckner
approved these changes
Jan 27, 2026
f7c558d to
dddb2f6
Compare
|
(because the former fires for modifier keys that shouldn't open the menu)
dddb2f6 to
c048a1d
Compare
jbuckner
reviewed
Jan 29, 2026
jbuckner
reviewed
Jan 29, 2026
jbuckner
added a commit
that referenced
this pull request
May 28, 2026
* origin/main: (28 commits) WEBDEV-8518: Add CI caching and standardize workflow hygiene (#55) WEBDEV-8464 Make ia-dropdown-search-bar propagate selection changes immediately (#46) WEBDEV-8447 Upgrade ia-dropdown version to address z-index bug (#45) v0.2.5 (#44) WEBDEV-8378 Migrate dropdown-style search bar from Offshoot (#41) 0.2.3 (#43) WEBDEV-8393 Add full OTP form (#42) WEBDEV-8327 Add basic OTP input (#40) Update instructions for adding component stories (#38) Demo page enhancements WEBDEV-8131 Encapsulate property settings (#36) WEBDEV-8167: Add demo and publishing sections to readme (#35) 0.2.2 WEBDEV-8162: Support Lit 2/3, Combobox fixes (#34) 0.2.1 WEBDEV-8151: Improve build compatibility (#32) v0.2.0 (#31) WEBDEV-8119 Add basic combo-box component (#24) Update npm-publish workflow Update npm-publish action ... # Conflicts: # demo/app-root.ts # demo/story-template.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creates a new combo-box component in the labs directory. This component is intended to act as a flexible form control allowing users to select from predefined options, search & filter those options with text input, and optionally enter their own custom values entirely.
To that end, the component supports three levels of behavior:
select-only: Functions like a<select>dropdown widget, disallowing text input and requiring a selection to be made from the options presented.list(default): Retains the dropdown behavior as above, but also allows the dropdown options to be filtered by entering a partial value in the widget's text box. It can still only take on values from the predefined options. Implements W3C recommendations for thecomboboxrole with list autocompletefreeform: Presents a filterable dropdown of options likelistbut does not restrict its held values to these options, instead allowing any text value to be held in the widget. This is essentially just a text input with autocomplete suggestions.