Skip to content

WEBDEV-8162: Support Lit 2/3, Combobox fixes#34

Merged
jbuckner merged 8 commits into
mainfrom
lit-version
Feb 10, 2026
Merged

WEBDEV-8162: Support Lit 2/3, Combobox fixes#34
jbuckner merged 8 commits into
mainfrom
lit-version

Conversation

@jbuckner

@jbuckner jbuckner commented Feb 4, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@github-actions

github-actions Bot commented Feb 4, 2026

Copy link
Copy Markdown
PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-02-10 17:24 UTC

@codecov-commenter

codecov-commenter commented Feb 4, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 80.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.41%. Comparing base (a34b6f1) to head (d4196c9).

Files with missing lines Patch % Lines
src/elements/ia-combo-box/ia-combo-box.ts 80.00% 0 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #34      +/-   ##
==========================================
- Coverage   87.15%   86.41%   -0.75%     
==========================================
  Files           7        7              
  Lines         366      368       +2     
  Branches       87       90       +3     
==========================================
- Hits          319      318       -1     
  Misses         24       24              
- Partials       23       26       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread src/elements/ia-combo-box/ia-combo-box.ts
Comment thread package.json Outdated
@jbuckner jbuckner marked this pull request as ready for review February 9, 2026 20:35
@jbuckner jbuckner requested a review from latonv February 9, 2026 20:41
@jbuckner jbuckner changed the title WEBDEV-8162: Update lit to support 2 or 3 WEBDEV-8162: Support Lit 2/3, Combobox fixes Feb 9, 2026

@latonv latonv left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, no blockers. Just a small curiosity about the version constraint, but no concerns about it either way.

Comment thread package.json Outdated
@jbuckner

jbuckner commented Feb 9, 2026

Copy link
Copy Markdown
Collaborator Author

LGTM, no blockers. Just a small curiosity about the version constraint, but no concerns about it either way.

Yeah that's fair. This was copy pasta from the lit3 migration site but yeah we're using the latest everywhere so I'll update it.

@jbuckner jbuckner merged commit b85a1bd into main Feb 10, 2026
3 checks passed
@jbuckner jbuckner deleted the lit-version branch February 10, 2026 17:23
jbuckner added a commit that referenced this pull request Feb 11, 2026
* main:
  0.2.2
  WEBDEV-8162: Support Lit 2/3, Combobox fixes (#34)
jbuckner added a commit that referenced this pull request May 28, 2026
* origin/main: (28 commits)
  WEBDEV-8518: Add CI caching and standardize workflow hygiene (#55)
  WEBDEV-8464 Make ia-dropdown-search-bar propagate selection changes immediately (#46)
  WEBDEV-8447 Upgrade ia-dropdown version to address z-index bug (#45)
  v0.2.5 (#44)
  WEBDEV-8378 Migrate dropdown-style search bar from Offshoot (#41)
  0.2.3 (#43)
  WEBDEV-8393 Add full OTP form (#42)
  WEBDEV-8327 Add basic OTP input (#40)
  Update instructions for adding component stories (#38)
  Demo page enhancements
  WEBDEV-8131 Encapsulate property settings (#36)
  WEBDEV-8167: Add demo and publishing sections to readme (#35)
  0.2.2
  WEBDEV-8162: Support Lit 2/3, Combobox fixes (#34)
  0.2.1
  WEBDEV-8151: Improve build compatibility (#32)
  v0.2.0 (#31)
  WEBDEV-8119 Add basic combo-box component (#24)
  Update npm-publish workflow
  Update npm-publish action
  ...

# Conflicts:
#	demo/app-root.ts
#	demo/story-template.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants