Skip to content

ref(onboarding): Use same hover as focus for platform picker#13468

Merged
evanpurkhiser merged 1 commit intomasterfrom
refonboarding-use-same-hover-as-focus-for-platform-picker
May 30, 2019
Merged

ref(onboarding): Use same hover as focus for platform picker#13468
evanpurkhiser merged 1 commit intomasterfrom
refonboarding-use-same-hover-as-focus-for-platform-picker

Conversation

@evanpurkhiser
Copy link
Member

@evanpurkhiser evanpurkhiser commented May 30, 2019

Fixes an issue where the hover background was the same as the onboarding background, making it hard to see what you were hovering over.

image

@evanpurkhiser evanpurkhiser requested review from a team and ckj May 30, 2019 18:22
Copy link
Member

@ckj ckj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

In the future we should consider a different color here, but good with this a fix for the more immediate problem.

Fixes an issue where the hover background was the same as the onboarding
background, making it hard to see what you were hovering over.
@evanpurkhiser evanpurkhiser force-pushed the refonboarding-use-same-hover-as-focus-for-platform-picker branch from 33b17b0 to f4d5f1e Compare May 30, 2019 18:40
@evanpurkhiser evanpurkhiser merged commit 2226337 into master May 30, 2019
@evanpurkhiser evanpurkhiser deleted the refonboarding-use-same-hover-as-focus-for-platform-picker branch May 30, 2019 19:30
jan-auer added a commit that referenced this pull request May 30, 2019
* master: (30 commits)
  ref(ui): Avoid full-page load indicator after project creation (#12842)
  ref(events-v2) Use an object target instead building URLs (#13471)
  ref(onboarding): Improve alerts from wizard docs (#13469)
  feat(app-platform): integration feature models, serializer, endpoints (#13377)
  ref(onboarding): Improve platform picker hover color (#13468)
  chore: New SDK versions (#13465)
  feat(events-v2) Add rough sketch of event modal (#13415)
  chore(south) Update south state to use new jsonfield (#13466)
  fix(events-v2): Fix search filter (#13454)
  chore: Vendor JSONField to fix runtime warnings and reduce future upgrade pain (#13397)
  test(events-v2): Fix dynamic values in Percy (#13463)
  dx(notion): Upgrade from `notion` to `volta` (#13452)
  feat(onboarding): Add warning for when docs are missing examples (#13445)
  misc(metrics): First pass at un-sampled single metric paths. (#13434)
  fix(integrations) Fix missing identity link on re-install (#13450)
  fix(api): Fix bug when creating incident comments while logged in as another user.
  fix(api): Fix task error on incident creation
  chore(SDK's): Update various SDK versions/urls (#13225)
  chore: Make exports and imports match (#13449)
  feat(ui): Add message in Incidents list for creating an incident [SEN-694] (#13436)
  ...
@github-actions github-actions bot locked and limited conversation to collaborators Dec 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants