ref(ui): Avoid full-page load indicator after project creation#12842
Conversation
|
We still use the old context APIs in a few places. Will they drop state updates with this? |
|
I'm not sure. I'm working on a new onboarding flow, and part of it creates a project for them (which happens after they select a platform) and right now for a split second it displays a loading indicator. |
|
It should be fine because fetchData updates the state when it's completed? |
|
My concern here is around usage of the old context API. From the docs:
which is maybe why we have been completely remounting? |
|
Probably going to try and get this merged soon. It affects the onboarding experience since the page effectively reloads when they create the project during that flow. |
837c463 to
fdcec74
Compare
|
I think this is safe. Could I get an approval on this. The new onboarding experience isn't great without it, since it effectively reloads the page. |
* master: (30 commits) ref(ui): Avoid full-page load indicator after project creation (#12842) ref(events-v2) Use an object target instead building URLs (#13471) ref(onboarding): Improve alerts from wizard docs (#13469) feat(app-platform): integration feature models, serializer, endpoints (#13377) ref(onboarding): Improve platform picker hover color (#13468) chore: New SDK versions (#13465) feat(events-v2) Add rough sketch of event modal (#13415) chore(south) Update south state to use new jsonfield (#13466) fix(events-v2): Fix search filter (#13454) chore: Vendor JSONField to fix runtime warnings and reduce future upgrade pain (#13397) test(events-v2): Fix dynamic values in Percy (#13463) dx(notion): Upgrade from `notion` to `volta` (#13452) feat(onboarding): Add warning for when docs are missing examples (#13445) misc(metrics): First pass at un-sampled single metric paths. (#13434) fix(integrations) Fix missing identity link on re-install (#13450) fix(api): Fix bug when creating incident comments while logged in as another user. fix(api): Fix task error on incident creation chore(SDK's): Update various SDK versions/urls (#13225) chore: Make exports and imports match (#13449) feat(ui): Add message in Incidents list for creating an incident [SEN-694] (#13436) ...
I had originally fixed the same problem in [0] and then looks like it was refactored in [1], without the `silent` flag that I had introduced [2] for trialing [0]: #12842 [1]: 7ff0f57#diff-b53a62e33ed69961e43e0cc24634616eR101 [2]: #15165
Currently after project creation, the entire org context component would
remount. This should be unneeded, we should be able to just propegate
org context downThis is un-needed, instead we can just propegate org
context down.
Not positive 100% positive though, the old context API might be the reason we have to do this.