feat(events-v2) Add rough sketch of event modal#13415
Merged
Conversation
lynnagara
reviewed
May 28, 2019
Member
lynnagara
left a comment
There was a problem hiding this comment.
I think the eventSlug format + adding browser history entry works well (imo could probably just be named "event" though since it goes without saying that it's a slug)
Member
There was a problem hiding this comment.
We'll probably need to extend the existing location.query to keep the cursor, project, and other values around
Member
There was a problem hiding this comment.
Oops, just saw your comment above
billyvg
reviewed
May 28, 2019
src/sentry/static/sentry/app/views/organizationEventsV2/eventDetails.jsx
Outdated
Show resolved
Hide resolved
This is a rough sketch of how the single event view could work. There are numerous prop-type warnings that I plan on addressing before merging this. The styling is not perfect either as I wasn't sure on how the scrolling should be handled as the modal could be taller or shorter than the viewport and I wanted to discuss how that should be handled. Refs SEN-648
Member
Author
|
Now with a rough version of the tags table, more representative styling and some cursory integration tests. |
Extract title/message/location generation logic into util functions making it easier to reuse and less coupled to the specific styling.
billyvg
reviewed
May 30, 2019
src/sentry/static/sentry/app/views/organizationEventsV2/eventDetails.jsx
Show resolved
Hide resolved
billyvg
approved these changes
May 30, 2019
Member
billyvg
left a comment
There was a problem hiding this comment.
It would be nice in follow-up PRs, to break down eventDetails a bit, and maybe have data fetching handled in an AyncComponent, but this PR looks 👍 as is
| <Container> | ||
| <Link | ||
| css={overflowEllipsis} | ||
| to={`/organizations/${organization.slug}/events/?${newQuery}`} |
Member
There was a problem hiding this comment.
Instead of making our own query string, we could pass to an object with pathname and query keys.
jan-auer
added a commit
that referenced
this pull request
May 30, 2019
* master: (30 commits) ref(ui): Avoid full-page load indicator after project creation (#12842) ref(events-v2) Use an object target instead building URLs (#13471) ref(onboarding): Improve alerts from wizard docs (#13469) feat(app-platform): integration feature models, serializer, endpoints (#13377) ref(onboarding): Improve platform picker hover color (#13468) chore: New SDK versions (#13465) feat(events-v2) Add rough sketch of event modal (#13415) chore(south) Update south state to use new jsonfield (#13466) fix(events-v2): Fix search filter (#13454) chore: Vendor JSONField to fix runtime warnings and reduce future upgrade pain (#13397) test(events-v2): Fix dynamic values in Percy (#13463) dx(notion): Upgrade from `notion` to `volta` (#13452) feat(onboarding): Add warning for when docs are missing examples (#13445) misc(metrics): First pass at un-sampled single metric paths. (#13434) fix(integrations) Fix missing identity link on re-install (#13450) fix(api): Fix bug when creating incident comments while logged in as another user. fix(api): Fix task error on incident creation chore(SDK's): Update various SDK versions/urls (#13225) chore: Make exports and imports match (#13449) feat(ui): Add message in Incidents list for creating an incident [SEN-694] (#13436) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a rough sketch of how the single event view could work. There are numerous prop-type warnings that I plan on addressing before merging this.
The styling is not perfect either as I wasn't sure on how the scrolling should be handled as the modal could be taller or shorter than the viewport and I wanted to discuss how that should be handled.
I wanted to get feedback on:
eventSlugquery string parameter. The current APIs need both an event id and projectId. My thinking was that using a single parameter will allow us to have fewer query parameters to manage when handling history state.renderFuncfeatures to trigger different modals for different event/issue types.Refs SEN-648