chore(south) Update south state to use new jsonfield#13466
Merged
Conversation
Update all the south snapshots to reference the new JSONField implementation. This makes it possible to remove jsonfield library in the future and removes the effected tables from being caught in the next south diff. Refs SEN-686
markstory
commented
May 30, 2019
| if 'south' in settings.INSTALLED_APPS: | ||
| from south.modelsinspector import add_introspection_rules | ||
| add_introspection_rules([], ['^sentry\.db\.models\.fields\.JSONField']) | ||
| add_introspection_rules([], ['^sentry\.db\.models\.fields\.jsonfield.JSONField']) |
Member
Author
There was a problem hiding this comment.
south is very picky about the module path and won't accept aliases.
| from sentry.cache import default_cache | ||
| from sentry.constants import KNOWN_DIF_FORMATS | ||
| from sentry.db.models import FlexibleForeignKey, Model, sane_repr, BaseManager | ||
| from sentry.db.models import FlexibleForeignKey, Model, sane_repr, BaseManager, JSONField |
Member
Author
There was a problem hiding this comment.
I missed this last time.
wedamija
approved these changes
May 30, 2019
jan-auer
added a commit
that referenced
this pull request
May 30, 2019
* master: (30 commits) ref(ui): Avoid full-page load indicator after project creation (#12842) ref(events-v2) Use an object target instead building URLs (#13471) ref(onboarding): Improve alerts from wizard docs (#13469) feat(app-platform): integration feature models, serializer, endpoints (#13377) ref(onboarding): Improve platform picker hover color (#13468) chore: New SDK versions (#13465) feat(events-v2) Add rough sketch of event modal (#13415) chore(south) Update south state to use new jsonfield (#13466) fix(events-v2): Fix search filter (#13454) chore: Vendor JSONField to fix runtime warnings and reduce future upgrade pain (#13397) test(events-v2): Fix dynamic values in Percy (#13463) dx(notion): Upgrade from `notion` to `volta` (#13452) feat(onboarding): Add warning for when docs are missing examples (#13445) misc(metrics): First pass at un-sampled single metric paths. (#13434) fix(integrations) Fix missing identity link on re-install (#13450) fix(api): Fix bug when creating incident comments while logged in as another user. fix(api): Fix task error on incident creation chore(SDK's): Update various SDK versions/urls (#13225) chore: Make exports and imports match (#13449) feat(ui): Add message in Incidents list for creating an incident [SEN-694] (#13436) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update all the south snapshots to reference the new JSONField implementation. This makes it possible to remove jsonfield library in the future and removes the effected tables from being caught in the next south diff.
Refs SEN-686