Conversation
The packaged version of this library contains metaclass warnings in Django1.8. We could upgrade but newer versions of the library are unwilling to serialize datetimes and decimal objects. Vendoring the library will allow us to maintain compatibility for our use cases and upgrade django at the same time. Refs SEN-686
We can't yet remove the jsonfield dependency as getsentry is using it.
Member
|
Would it be better to stick this in |
Member
Author
|
@evanpurkhiser We could. There is is no real chance that we'd be able to pull in upstream changes though. Newer versions cannot serialize datetimes, and future django's JSONField uses postgres' |
Member
|
Ahh so this is not an interim thing, we are just pulling this in for good |
Member
Author
Yes, JSONField would become ours forever. Do you think it is worthwhile pulling in tests, or moving it to a separate directory in src? |
Member
|
+1 on pulling in the tests related to this. I don't know that we need a separate directory in src since this is just a single file. |
Capture the intended behavior from the point we forked off.
wedamija
approved these changes
May 28, 2019
jan-auer
added a commit
that referenced
this pull request
May 30, 2019
* master: (30 commits) ref(ui): Avoid full-page load indicator after project creation (#12842) ref(events-v2) Use an object target instead building URLs (#13471) ref(onboarding): Improve alerts from wizard docs (#13469) feat(app-platform): integration feature models, serializer, endpoints (#13377) ref(onboarding): Improve platform picker hover color (#13468) chore: New SDK versions (#13465) feat(events-v2) Add rough sketch of event modal (#13415) chore(south) Update south state to use new jsonfield (#13466) fix(events-v2): Fix search filter (#13454) chore: Vendor JSONField to fix runtime warnings and reduce future upgrade pain (#13397) test(events-v2): Fix dynamic values in Percy (#13463) dx(notion): Upgrade from `notion` to `volta` (#13452) feat(onboarding): Add warning for when docs are missing examples (#13445) misc(metrics): First pass at un-sampled single metric paths. (#13434) fix(integrations) Fix missing identity link on re-install (#13450) fix(api): Fix bug when creating incident comments while logged in as another user. fix(api): Fix task error on incident creation chore(SDK's): Update various SDK versions/urls (#13225) chore: Make exports and imports match (#13449) feat(ui): Add message in Incidents list for creating an incident [SEN-694] (#13436) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The packaged version of this library contains metaclass warnings in Django1.8. We could upgrade but newer versions of the library are unwilling to serialize datetimes and decimal objects. Vendoring the library will allow us to maintain compatibility for our use cases and upgrade django at the same time.
Refs SEN-686