Skip to content

chore(SDK's): Update various SDK versions/urls#13225

Merged
lobsterkatie merged 3 commits intomasterfrom
kmclb-update-sdk-versions-may-2019
May 29, 2019
Merged

chore(SDK's): Update various SDK versions/urls#13225
lobsterkatie merged 3 commits intomasterfrom
kmclb-update-sdk-versions-may-2019

Conversation

@lobsterkatie
Copy link
Member

@lobsterkatie lobsterkatie commented May 15, 2019 •
edited
Loading

... so that the UI will correctly report when the SDK used to capture an event is out of date.

NB: This is not comprehensive, because it's a band-aid on the real problem, which is that ideally these would get updated automatically. Working on that in a separate PR. (Will update this PR with a link to it once it's up.)

@HazAT I notice JS isn't in here. Is that on purpose, or should I add it while I'm here?

[UPDATE: There are a few others missing, too. Worth adding them?]

@lobsterkatie lobsterkatie requested a review from HazAT May 15, 2019 19:51
@HazAT
Copy link
Member

HazAT commented May 20, 2019

@lobsterkatie Would be awesome if you could add it.
Also, we could think of using the release registry for the version numbers + SDKs so we don't have to update it manually anymore.
Basically this todo:
https://github.com/getsentry/sentry/pull/13225/files#diff-fd5d9dbc87e18a510a3520831899b63eL1485

Wouldn't be that hard to do, let me know what you think.

@lobsterkatie
Copy link
Member Author

lobsterkatie commented May 21, 2019 •
edited
Loading

Yeah, would be great to not have to do it manually. I don't know much about the release registry (I just found it and poked around a bit, but don't know how best to get data out of it), but if you can point me in the right direction, I can give it a shot.

We do have one problem to solve in the meantime, though: the format of SDK names has changed, or at least diversified. Everything used to be raven-language or sentry-language, possibly followed by a more specific identifier: raven-language:something or sentry-language:something (the example given in the relevant docstring is raven-java:logback). But now there's sentry.javascript.browser and friends, which don't fit the pattern.

There are two options:

  1. If we're happy to list sentry.javascript.browser, sentry.javascript.node, sentry.javascript.electron, etc separately, then the current logic (around "do we show the hey, yo, your SDK is out of date! message?") works, because what comes through will be an exact match.

  2. We make the logic smart enough to handle both formats, so that it can map both sentry.javascript.browser and sentry.javascript.node back to sentry.javascript.

Option 1 is obviously easier, and maybe there are few enough SDK flavors we don't mind listing them all. Further, if browser and node might ever have different version numbers* (the way electron already does), this is a necessity. Finally, IDK how the release registry handles things, but my gut says it'd be possible to make it list everything separately.

So, leaning towards 1), but would love your take on it.

*Actually, I just realized they already do, though I don't know if that's on purpose or not. Right now browser is at 5.2.1 and node is at 5.2.0.

**Also, if I'm reading things correctly, sentry-rust/sentry.rust seems not totally in agreement with the release registry about what its name is. See 1 and 2.

@HazAT
Copy link
Member

HazAT commented May 23, 2019

@lobsterkatie Good catch!
We will fix the rust identifier.

I would merge this for now and go with the pragmatic approach.
We can hop on a quick call next week so I can guide you in the right direction regarding using the release registry.

@lobsterkatie lobsterkatie changed the title chore(SDK's): Update php/laravel versions/urls chore(SDK's): Update various SDK versions/urls May 29, 2019
@lobsterkatie lobsterkatie merged commit 93128ef into master May 29, 2019
@lobsterkatie lobsterkatie deleted the kmclb-update-sdk-versions-may-2019 branch May 29, 2019 18:25
@HazAT
Copy link
Member

HazAT commented May 29, 2019

🎉

jan-auer added a commit that referenced this pull request May 30, 2019
@jan-auer
Merge branch 'master' into feat/release-artifacts-assemble
0c6c6d2 
* master: (30 commits)
  ref(ui): Avoid full-page load indicator after project creation (#12842)
  ref(events-v2) Use an object target instead building URLs (#13471)
  ref(onboarding): Improve alerts from wizard docs (#13469)
  feat(app-platform): integration feature models, serializer, endpoints (#13377)
  ref(onboarding): Improve platform picker hover color (#13468)
  chore: New SDK versions (#13465)
  feat(events-v2) Add rough sketch of event modal (#13415)
  chore(south) Update south state to use new jsonfield (#13466)
  fix(events-v2): Fix search filter (#13454)
  chore: Vendor JSONField to fix runtime warnings and reduce future upgrade pain (#13397)
  test(events-v2): Fix dynamic values in Percy (#13463)
  dx(notion): Upgrade from `notion` to `volta` (#13452)
  feat(onboarding): Add warning for when docs are missing examples (#13445)
  misc(metrics): First pass at un-sampled single metric paths. (#13434)
  fix(integrations) Fix missing identity link on re-install (#13450)
  fix(api): Fix bug when creating incident comments while logged in as another user.
  fix(api): Fix task error on incident creation
  chore(SDK's): Update various SDK versions/urls (#13225)
  chore: Make exports and imports match (#13449)
  feat(ui): Add message in Incidents list for creating an incident [SEN-694] (#13436)
  ...
@github-actions github-actions bot locked and limited conversation to collaborators Dec 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@HazAT HazAT HazAT approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lobsterkatie @HazAT