Conversation
PB-413 Correct location pop up links
that supports 0.1 resolution
PB-555 : fix too many resolutions being filtered out with WMTS layers
PB-521 : add geolocation feedback on Cesium
PB-568 : guard against empty KML feature coordinate
in the same way we split the profile regarding LV95 bound, we now also cut it in portions/chunks of 3000 points, in order not to hit the hard limit of 5k point set in our backend
…st_too_long PB-538 : split profile too long for backend into chunks
Issue: users found that the search bar being focused (and expanded) on startup when they reloaded after searching for a layer or feature. Fix: We no longer focus the search bar at startup, effectively stopping it from being opened
…pening-on-startup PB-549: stopping searchbar focus on startup
Issue : The zoom in and out buttons were added to the cesium viewer near the compass, when it is a bit more logical to have them stay where they are in the 2D viewer. Fix : We move the logic of those buttons to the toolbox zoom buttons, use that logic when we are in 3d, and removed the cesium buttons. temp
removing comment
…t was moved from the cesium toolbox to the zoom buttons
lintint
removing the visible flag being used, we already remove the component altogether when the visibility flag is false, and it hinders aggregate from being displayed (sub-layers have their visibility flag set to false in the config for some reasons...) Also removing the subdomain for WMS, as we are fine landing always on the main URL endpoint (and can be problematic for external layer support)
PB-228 : add aggregate layer support to 3D
Cesium CSS was altering how our buttons were shown, adding some padding or margins there and there. As we were importing the Cesium CSS file just to place the canvas (and its Cesium generated parent divs) correctly, I've switched to declare this CSS ourselves and remove the import of the Cesium CSS file. Also removing a couple wrapping divs in the Cesium component that are not useful, as they clutter our "real" DOM with many empty divs
making the inject a factory method, so it won't be computed at startup (on mount) but only the first time it is being used
…over PB-543 : fix Cesium CSS spillover
Changes how the profile handles itself when the floating tooltip is active, closing the profile now only unselect the profile feature (and do not close the selected features anymore) While the feature info is at the bottom, the profile is now shown as an "off-shoot" or second tab of the selected features, taking the whole width of the screen. Adding a "Back" button at the top of the infobox panel to go back to feature details. Rework of the profile width management so that it doesn't overflow its parent. Also adding a little spacer between each profile information (going Composition API in the process)
using flex column to display both feature detail and profile within the infobox
PB-472 : profile in the context of the new floating tooltip
Passing run #2373 ↗︎Details:
Review all test suite changes for PR #878 ↗︎ |
|||||||||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test link